[dpdk-dev,08/12,v3] event/dpaa: add dequeue timeout conversion support

Message ID 1516125485-28919-9-git-send-email-nipun.gupta@nxp.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Nipun Gupta Jan. 16, 2018, 5:58 p.m. UTC
  From: Sunil Kumar Kori <sunil.kori@nxp.com>

Signed-off-by: Sunil Kumar Kori <sunil.kori@nxp.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/event/dpaa/dpaa_eventdev.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Jerin Jacob Jan. 16, 2018, 11:50 a.m. UTC | #1
-----Original Message-----
> Date: Tue, 16 Jan 2018 23:28:01 +0530
> From: Nipun Gupta <nipun.gupta@nxp.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, sunil.kori@nxp.com, hemant.agrawal@nxp.com
> Subject: [PATCH 08/12 v3] event/dpaa: add dequeue timeout conversion support
> X-Mailer: git-send-email 1.9.1
> 
> From: Sunil Kumar Kori <sunil.kori@nxp.com>
> 
> Signed-off-by: Sunil Kumar Kori <sunil.kori@nxp.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  drivers/event/dpaa/dpaa_eventdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
> index 82362d5..b4b7aed 100644
> --- a/drivers/event/dpaa/dpaa_eventdev.c
> +++ b/drivers/event/dpaa/dpaa_eventdev.c
> @@ -361,6 +361,7 @@
>  	.port_release       = dpaa_event_port_release,
>  	.port_link        = dpaa_event_port_link,
>  	.port_unlink      = dpaa_event_port_unlink,
> +	.timeout_ticks    = dpaa_event_dequeue_timeout_ticks,

This patch is almost empty. Please define dpaa_event_dequeue_timeout_ticks() in this patch

>  };
>  
>  static int
> -- 
> 1.9.1
>
  
Nipun Gupta Jan. 16, 2018, 1:35 p.m. UTC | #2
> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Tuesday, January 16, 2018 17:21
> To: Nipun Gupta <nipun.gupta@nxp.com>
> Cc: dev@dpdk.org; Sunil Kumar Kori <sunil.kori@nxp.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Subject: Re: [PATCH 08/12 v3] event/dpaa: add dequeue timeout conversion
> support
> 
> -----Original Message-----
> > Date: Tue, 16 Jan 2018 23:28:01 +0530
> > From: Nipun Gupta <nipun.gupta@nxp.com>
> > To: jerin.jacob@caviumnetworks.com
> > CC: dev@dpdk.org, sunil.kori@nxp.com, hemant.agrawal@nxp.com
> > Subject: [PATCH 08/12 v3] event/dpaa: add dequeue timeout conversion
> support
> > X-Mailer: git-send-email 1.9.1
> >
> > From: Sunil Kumar Kori <sunil.kori@nxp.com>
> >
> > Signed-off-by: Sunil Kumar Kori <sunil.kori@nxp.com>
> > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> >  drivers/event/dpaa/dpaa_eventdev.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/event/dpaa/dpaa_eventdev.c
> b/drivers/event/dpaa/dpaa_eventdev.c
> > index 82362d5..b4b7aed 100644
> > --- a/drivers/event/dpaa/dpaa_eventdev.c
> > +++ b/drivers/event/dpaa/dpaa_eventdev.c
> > @@ -361,6 +361,7 @@
> >  	.port_release       = dpaa_event_port_release,
> >  	.port_link        = dpaa_event_port_link,
> >  	.port_unlink      = dpaa_event_port_unlink,
> > +	.timeout_ticks    = dpaa_event_dequeue_timeout_ticks,
> 
> This patch is almost empty. Please define dpaa_event_dequeue_timeout_ticks()
> in this patch

Hi Jerin,

As dpaa_event_dequeue_timeout_ticks() is used in patch 5/12 (in function
dpaa_event_dev_configure), I would prefer squashing this in the same patch.
Is this okay with you?

Regards,
Nipun

> 
> >  };
> >
> >  static int
> > --
> > 1.9.1
> >
  

Patch

diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
index 82362d5..b4b7aed 100644
--- a/drivers/event/dpaa/dpaa_eventdev.c
+++ b/drivers/event/dpaa/dpaa_eventdev.c
@@ -361,6 +361,7 @@ 
 	.port_release       = dpaa_event_port_release,
 	.port_link        = dpaa_event_port_link,
 	.port_unlink      = dpaa_event_port_unlink,
+	.timeout_ticks    = dpaa_event_dequeue_timeout_ticks,
 };
 
 static int