diff mbox

[dpdk-dev,v3,1/6] test: fix memory leak in bitmap test

Message ID 8ccde502aee6921dd4fc74718309d60b8c82f444.1516178976.git.anatoly.burakov@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Anatoly Burakov Jan. 17, 2018, 11:15 a.m. UTC 
  Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Fixes: c7e4a134e769 ("test: verify bitmap operations")
Cc: pbhagavatula@caviumnetworks.com

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 test/test/test_bitmap.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thomas Monjalon Feb. 1, 2018, 12:10 a.m. UTC | #1 
17/01/2018 12:15, Anatoly Burakov:
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Fixes: c7e4a134e769 ("test: verify bitmap operations")
> Cc: pbhagavatula@caviumnetworks.com
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

I think you missed to report some previous acks in this series.
Anatoly Burakov Feb. 1, 2018, 5:04 p.m. UTC | #2 
On 01-Feb-18 12:10 AM, Thomas Monjalon wrote:
> 17/01/2018 12:15, Anatoly Burakov:
>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>
>> Fixes: c7e4a134e769 ("test: verify bitmap operations")
>> Cc: pbhagavatula@caviumnetworks.com
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> I think you missed to report some previous acks in this series.
> 
> 
> 

Which ones were there? I can only see two new acks for v3 from Olivier. 
Everything else seems in order, unless my email client is lying to me :)
Thomas Monjalon Feb. 2, 2018, 9:08 a.m. UTC | #3 
01/02/2018 18:04, Burakov, Anatoly:
> On 01-Feb-18 12:10 AM, Thomas Monjalon wrote:
> > 17/01/2018 12:15, Anatoly Burakov:
> >> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>
> >> Fixes: c7e4a134e769 ("test: verify bitmap operations")
> >> Cc: pbhagavatula@caviumnetworks.com
> >>
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > 
> > I think you missed to report some previous acks in this series.
> > 
> > 
> > 
> 
> Which ones were there? I can only see two new acks for v3 from Olivier. 
> Everything else seems in order, unless my email client is lying to me :)

There are some acks from Cristian.
Anatoly Burakov Feb. 2, 2018, 10:31 a.m. UTC | #4 
On 02-Feb-18 9:08 AM, Thomas Monjalon wrote:
> 01/02/2018 18:04, Burakov, Anatoly:
>> On 01-Feb-18 12:10 AM, Thomas Monjalon wrote:
>>> 17/01/2018 12:15, Anatoly Burakov:
>>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>
>>>> Fixes: c7e4a134e769 ("test: verify bitmap operations")
>>>> Cc: pbhagavatula@caviumnetworks.com
>>>>
>>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>>>
>>> I think you missed to report some previous acks in this series.
>>>
>>>
>>>
>>
>> Which ones were there? I can only see two new acks for v3 from Olivier.
>> Everything else seems in order, unless my email client is lying to me :)
> 
> There are some acks from Cristian.
> 
They are all already in the patchset.
Thomas Monjalon Feb. 2, 2018, 5:08 p.m. UTC | #5 
02/02/2018 11:31, Burakov, Anatoly:
> On 02-Feb-18 9:08 AM, Thomas Monjalon wrote:
> > 01/02/2018 18:04, Burakov, Anatoly:
> >> On 01-Feb-18 12:10 AM, Thomas Monjalon wrote:
> >>> 17/01/2018 12:15, Anatoly Burakov:
> >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>>
> >>>> Fixes: c7e4a134e769 ("test: verify bitmap operations")
> >>>> Cc: pbhagavatula@caviumnetworks.com
> >>>>
> >>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >>>
> >>> I think you missed to report some previous acks in this series.
> >>>
> >>>
> >>>
> >>
> >> Which ones were there? I can only see two new acks for v3 from Olivier.
> >> Everything else seems in order, unless my email client is lying to me :)
> > 
> > There are some acks from Cristian.
> > 
> They are all already in the patchset.

Oh, I didn't see them because they are at the beginning or middle of
the message. They should be in chronological order after your Signed-off.
Anatoly Burakov Feb. 5, 2018, 10:06 a.m. UTC | #6 
On 02-Feb-18 5:08 PM, Thomas Monjalon wrote:
> 02/02/2018 11:31, Burakov, Anatoly:
>> On 02-Feb-18 9:08 AM, Thomas Monjalon wrote:
>>> 01/02/2018 18:04, Burakov, Anatoly:
>>>> On 01-Feb-18 12:10 AM, Thomas Monjalon wrote:
>>>>> 17/01/2018 12:15, Anatoly Burakov:
>>>>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>>>
>>>>>> Fixes: c7e4a134e769 ("test: verify bitmap operations")
>>>>>> Cc: pbhagavatula@caviumnetworks.com
>>>>>>
>>>>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>>>>>
>>>>> I think you missed to report some previous acks in this series.
>>>>>
>>>>>
>>>>>
>>>>
>>>> Which ones were there? I can only see two new acks for v3 from Olivier.
>>>> Everything else seems in order, unless my email client is lying to me :)
>>>
>>> There are some acks from Cristian.
>>>
>> They are all already in the patchset.
> 
> Oh, I didn't see them because they are at the beginning or middle of
> the message. They should be in chronological order after your Signed-off.
> 
> 

That's a bit hard to do since my signoff is generated by 
git-format-patch rather than manually, but OK, i'll see what i can do. 
Apologies for the confusion.
Thomas Monjalon Feb. 5, 2018, 10:25 a.m. UTC | #7 
05/02/2018 11:06, Burakov, Anatoly:
> On 02-Feb-18 5:08 PM, Thomas Monjalon wrote:
> > 02/02/2018 11:31, Burakov, Anatoly:
> >> On 02-Feb-18 9:08 AM, Thomas Monjalon wrote:
> >>> 01/02/2018 18:04, Burakov, Anatoly:
> >>>> On 01-Feb-18 12:10 AM, Thomas Monjalon wrote:
> >>>>> 17/01/2018 12:15, Anatoly Burakov:
> >>>>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>>>>
> >>>>>> Fixes: c7e4a134e769 ("test: verify bitmap operations")
> >>>>>> Cc: pbhagavatula@caviumnetworks.com
> >>>>>>
> >>>>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >>>>>
> >>>>> I think you missed to report some previous acks in this series.
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>> Which ones were there? I can only see two new acks for v3 from Olivier.
> >>>> Everything else seems in order, unless my email client is lying to me :)
> >>>
> >>> There are some acks from Cristian.
> >>>
> >> They are all already in the patchset.
> > 
> > Oh, I didn't see them because they are at the beginning or middle of
> > the message. They should be in chronological order after your Signed-off.
> > 
> > 
> 
> That's a bit hard to do since my signoff is generated by 
> git-format-patch rather than manually, but OK, i'll see what i can do. 
> Apologies for the confusion.

Your signed-off should be generated when creating the commit:
	git commit -s
Then you add acks by updating the commit:
	git commit --amend
diff mbox

Patch

diff --git a/test/test/test_bitmap.c b/test/test/test_bitmap.c
index 05d547e..c3169e9 100644
--- a/test/test/test_bitmap.c
+++ b/test/test/test_bitmap.c
@@ -158,6 +158,9 @@  test_bitmap(void)
 	if (test_bitmap_scan_operations(bmp) < 0)
 		return TEST_FAILED;
 
+	rte_bitmap_free(bmp);
+	rte_free(mem);
+
 	return TEST_SUCCESS;
 }