Message ID | 1516209855-139507-1-git-send-email-motih@mellanox.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 771E51B2A9; Wed, 17 Jan 2018 18:24:28 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0079.outbound.protection.outlook.com [104.47.1.79]) by dpdk.org (Postfix) with ESMTP id 6EFB41B29F for <dev@dpdk.org>; Wed, 17 Jan 2018 18:24:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EdOOnJUFV+BD78Heh6jvayPr0SLIzE56v739tkqBy+o=; b=CJcH4DArn9o6qYvwjKIIacbBceecK5Mxs+DxT3QN/Kh6mWjqnf+iMcIF2tOU1h322SPYHpdCKD4n+V+EqDpeX90Z0U85/NVOKRuDDvKqohcpA9JW9ymUmhGalFnKw7T5sf9DS8als6oEA8WGY3pr1beBly5mnrbZk0d3IzBahLw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR05MB3214.eurprd05.prod.outlook.com (2603:10a6:802:1b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Wed, 17 Jan 2018 17:24:25 +0000 From: Moti Haimovsky <motih@mellanox.com> To: thomas@monjalon.net Cc: dev@dpdk.org, Moti Haimovsky <motih@mellanox.com>, Hemant Agrawal <hemant.agrawal@nxp.com> Date: Wed, 17 Jan 2018 19:24:15 +0200 Message-Id: <1516209855-139507-1-git-send-email-motih@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1516206196-137537-1-git-send-email-motih@mellanox.com> References: <1516206196-137537-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR02CA0043.eurprd02.prod.outlook.com (2603:10a6:802:14::14) To VI1PR05MB3214.eurprd05.prod.outlook.com (2603:10a6:802:1b::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 47c8348a-c638-46d0-11a8-08d55dcf2897 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB3214; X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3214; 3:dr0vegHoJJB+OdzttzeekLvo6T/9PWLC+gBgKChRnZkjr7m+ChDi6+WBu6YYY/nb3aMfLKXDjkrf8e44ADtg99yKkqH2+zU9AriLxu0ys2t2GEjQ0CE1IjZa68FB0crcx697a+qNA6XE/c0PrlPAu8UJEULruKyEYwCFjN1uwVdWWDZ7N5DLqYFe/4z/IuMc5YZoZdpEFBc53llALgo5mwbeFYhDzdFv/q/Tzw6tWRNJjZ3tHqne5SFi/GiPllZF; 25:W7Y5Nx6yPdjyWUvf6ZlVbULaJ47Dbw1Ti0FWlTMl4qfEQ32IqkgrAXdtJraNikwPbOPxSygpm+cnoqHk5qRATjmMG+sx5J3qOs8L9BJOZiYJIjrET7NcblZtGXbNnw8bi+m+wXXQpFI1YSm/YRnh5TD6YhNpbFVzyVEz9f+Zgv9G5A1jQSmWPxQEFzkwXkuU6NwrJ8acvMqAd2WcFkvjKOUnEY8h6xinJf7AuM+Zw/EuvsyqOpb/s9In0zhS2pPxaVHTa7hYyIUg8EqS6bBfHa1eKpknFVOtFvcuwdtDIpJhN0ddJXuIB+gsazlbWrMcpxz9PaywfRcyhz1XYcf3KQ==; 31:CF4qFhx9hP9xy/2tH0NhrkcfRoZNg1QqIA+rZVZJ7NQDmKkOpFPAWca+O7Sxwyj0L82y9duGaV4yYvTgxrOlkPcvuHJcDmnEfVREQGRIYXxbmA8Bl4J3RfMIQpqKLo4PGVAsM+uEZzRn6AH2mWqxaDw6l3ptSj8Q4eCsCsRsb4zDQ4Z8vun+DVOHZlSMiVDGWG3aK/xa0YFoMrdAikNODPRx2BDbsGo0v3vveKEij/w= X-MS-TrafficTypeDiagnostic: VI1PR05MB3214: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3214; 20:jiPVvaCUx8OJucc0VD42nQgPAVu2qKSgwtAWzltrCCdmMa2xl0eoJBM2wwP5bdZ4sLtdcm3D+JJpJBGOX+3kWY3aG1HhzdMqNUC6RMAE6dWY7HMn3jfzpol6sWf90u0G+4JxAzWAm4uHdKoDV/Sr3x8/mYmB3qIDaOqDdA+A0h6wgSALHnhf5oEzm6De5B8ujmyRt2M0mJa80DbhHRaSR1gKLoypoMIRdsNqXEc0kAzBVKBqTKTA3lYkQVm0P01kFj6W/NCv/3PYu+A6MSaVCp9Sjbe+SGOWJ0KbsZnz7RlM+ymHsogBAcDWNbmBpdMY1UwoWppicLcp8RFUFvAN7WV6YHadNBdIC2Gmcqh0ubG7QmdYkv/LD8Sv0eSS/BTPfTTh8zG6q8gIEpSrrhdzmnJEc/kE0XW9VHeJluujYB6ScNu4jO/FA99HhC/npD/Jmfk5oox5y0Ps3cQ+PdK/BlndTJWonbVcdRbdJJ1OUiQR/dIIoGJ3+w3Qaa3KFmyg; 4:7mQ9lgcMamMwqk6ZFJY/ysfe3swuZuonjCuRNC9LTnueQL1Dn+fgPrhrxv+W2nBZcVNj6M/l8WSqxUUcmYTSTfeASy39/eesUQxEJ1EmT7eU9fJlWF2rONXbWQc4cLe5oYJZzCFsT/eoGuUFCazHLonobktGkZMSkOgUfwHfNmRQdOKj9Rs2MpSGTROc4VoUmM7aHX4cPFek89sZ50PE6N7pMQr6biNH/xN5bDjH17RoY+7GOPt91SXTUEFmS+aeX8+m6mNkjgbE8yf4Xq8/SEKiTh+dQGwThQvmpjH7O8Ni8XsDAN+52zE9gRsO8TyLLOMIjrQag6rbPBmSrxDIlonmo+FJiWg/7ngtJTormVA= X-Microsoft-Antispam-PRVS: <VI1PR05MB3214652422EB1879FAD7DF63D2E90@VI1PR05MB3214.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3231023)(2400048)(944501161)(93006095)(93001095)(3002001)(6055026)(6041268)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR05MB3214; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB3214; X-Forefront-PRVS: 0555EC8317 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(366004)(39380400002)(376002)(189003)(199004)(8676002)(81156014)(81166006)(68736007)(86362001)(25786009)(69596002)(8936002)(50226002)(7696005)(51416003)(47776003)(386003)(3846002)(7736002)(6116002)(26005)(97736004)(52116002)(4326008)(2906002)(2361001)(2351001)(54906003)(53936002)(305945005)(33026002)(478600001)(55016002)(5660300001)(48376002)(50466002)(4720700003)(76176011)(16526018)(36756003)(59450400001)(66066001)(21086003)(105586002)(316002)(8656006)(106356001)(16586007)(6666003)(6916009)(2950100002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3214; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR05MB3214; 23:gFmIE4UKN6krj1b+y0VVMKEefx3FA/3CdrhaZ4ERe?= 2HsHrmL/0dQGSjp5JzdIg1DeHzsHlO1Z/BoPieHpzOPUdKNzhoqu3dgZBUmBSnH4+ZRhRrG8dY06P6LfUDFogR8mIyGucbXHVjdi34uLqCkfvXMqWryakqEc5jBncsQsIhp6QkRIQ4C+Fg6hPRWljIAX8C3pQzVBoqLj9yiBO08daP2ah0pqOIedHcERpu4Gr6eaw3k4vbYEwI3sb5zdua4nNUc6kYnKIE5/nPkKjni97W55qJsrqPPk/kZyrSd+jkhs87wgQmLUg/ndoA/l6ZODdpvsx3LJ0JUX5j7IJDXenBFMewl5v9sm7NEjoiQt1kep7Lwbwigm+PrR533IYklyuQ36QDlxTHt8kLPlQ/b4OMyMj1skRaZuI5fxZTHGDy0dbT+nOTEJ5yH9R9vP6NcS/f+lx+q4KqYIv3ybZkqc5yBt3mmkDzgHUduh+8YKBy+3r7vg8RwNDP7b+xylK3vZCt8wDoT/vuP4F153l1vj/9i38mXsn7fhIl2zFTGAdJJte0ZYvJF4OyGqY9TfvJYH/4XgevYtoaIMyWbe0bl4gumvTuXzKLnFTw6SU1zV1rTgh5nBZu4P72APbOytAP8BDN+dFInOlTkcZhuqO44drHq0o9ZunTs8dpe8NhkPksSW1MLuLkziresnMvS3xSnZDQzvhkFtkI3fIRZb11jcKMOswgvkWsxChYkULqJ8vC+Q88pgdcu2AHS3k8o6dadR+ZbMnqgKzqCWSkWe1kPcw2dnIg2Tf9RQOrx6+uYBvKwEb5XIem7e5yFZ7Yy/y7+4SfFzDRnJdW7gKlNT1ttumxNFHf0Qh1mUcay2MCUs4PNFRMueOgpE5BbOxILBimW3p/ov498hqiaBtkNSOEgKLmPGP0k/+sIwWxs/BwVHKrV4JnNveUebtGrQUvcdnC+C6mBn9YSeObsOjme4gptJ1sG0x56K/DTWdYjSlPgMua96WbYaJkDgxzx91qTDo3j10QhDPWrzt2jwoumPSeyaJx2FFp1QWD3PKUdEzBsv2c+gQ0kMvKEDi4++NpG6132NVU/XavHxYOrJjq2SW39wcnpIKFZ2bOfImIJ3RKt9uhy8WDqrcJKePSRLt5kZKIaazCkTh2UL/vj9kX07YMgZALFnIcTk44J7N0sl47kFj1OwBCthwRK+5BxKOOf6DIC49fe9XquEyakEFtQahs18+WqprDXU6RTMRju5gt/UXxj6HVR+1xZzyF+JqXoX0lF X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3214; 6:JKu2pa05B6YwVli69MtwTxi0l83mtaNGdayx/wB2++MgwrilcZ0KCIedwGqQUj7mOhTiU2kz4fmm5hHE79diFb6YIOQaxMWDjSPItBmhfum8wD2LzhbUkyWM3qscKzxolg7HS0neFgVigzz9vDPRtpJ+S7HhOLCJ2v81PdmaHio1RiuZQ5GEQIcZ5abxrw5lAv7u/qnEBwk/Z9dF5DjB1SpuoD9hkBSLJcWiBOiut12LVXx/k7iVFhH9gWl/D2bs6y3FAfVexSvgGXn1yty33+GgtSrcfs+LYd+YSYqWEwTvwqmv7+SMvlbB+UcRSNWHwsSFDvmQ6iP1pf3yXofXpcu0AJgNysQWyVJUQ+Clh1k=; 5:scHQGjn08AGtGOH/+biOR2SKbBQP9Hv7G7qT8kndec5T6JDuIKUwEslAkedQNVdksVNM1BkZt/wZF/Lkd9hfR4Vq1uNYLsppWcQOCCkK0BnAwFylBRouL0zRGO0GvjwnEO/l4pKpG70QPkrpPjGy40r87RHAJ/BQzGbZAI1bbhA=; 24:86trR7JlScLWtkR+LJR5N5ASEezr4OrZ8j+6t7N4qobpgk3N0BaOwPEykxGqFySrQob4uAAv96JtkBNk0C4j1zRDbdGe/yLIEzi5fQm2muM=; 7:TZKMc7uuSOp+O853P/dkQcStMlo0tcmFHx9P916hdeSyzkQTNZA6LWU9HTid1A9+0/boRIFS4PNMIm9cv6aa2uyLJfB77y/g8aR0oTKf4Xcc5vMnFazBqkuctCaaYpzP7W54Z2xcotDHV6UiJMp7MW6WBHzBRH55dfPYWzQZaWr359hq59TotlD9PLJ2ovmIXCXAiJkT02U5jxe56Yt4Yg4FI0WIdqA50Mc1Z5PexktcNTM7+ixk7uHMKVgsZga9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2018 17:24:25.8551 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 47c8348a-c638-46d0-11a8-08d55dcf2897 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3214 Subject: [dpdk-dev] [PATCH v2] vfio: fix compilation errors in bsdapp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | warning | coding style issues |
ci/Intel-compilation | fail | Compilation issues |
Commit Message
Moti Haimovsky
Jan. 17, 2018, 5:24 p.m. UTC
This patch fixes the following compilation errors in bsdapp
/home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:5:
error: no previous prototype for function 'rte_vfio_clear_group'
[-Werror,-Wmissing-prototypes]
int rte_vfio_clear_group(int vfio_group_fd)
^
/home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:30:
error: unused parameter 'vfio_group_fd' [-Werror,-Wunused-parameter]
int rte_vfio_clear_group(int vfio_group_fd)
^
Fixes: c564a2a20093 ("vfio: expose clear group function for internal usages")
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
V2:
* Added a stub routine instead of including the rte_vfio.h file which is only valid
in Linux applications
---
lib/librte_eal/bsdapp/eal/eal.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
17/01/2018 18:24, Moti Haimovsky: > This patch fixes the following compilation errors in bsdapp > /home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:5: > error: no previous prototype for function 'rte_vfio_clear_group' > [-Werror,-Wmissing-prototypes] > int rte_vfio_clear_group(int vfio_group_fd) > ^ > /home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:30: > error: unused parameter 'vfio_group_fd' [-Werror,-Wunused-parameter] > int rte_vfio_clear_group(int vfio_group_fd) > ^ > Fixes: c564a2a20093 ("vfio: expose clear group function for internal usages") > Cc: Hemant Agrawal <hemant.agrawal@nxp.com> > > Signed-off-by: Moti Haimovsky <motih@mellanox.com> Applied, thanks
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 7239243..04cbd81 100644 --- a/lib/librte_eal/bsdapp/eal/eal.c +++ b/lib/librte_eal/bsdapp/eal/eal.c @@ -748,6 +748,7 @@ int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr, int rte_vfio_enable(const char *modname); int rte_vfio_is_enabled(const char *modname); int rte_vfio_noiommu_is_enabled(void); +int rte_vfio_clear_group(int vfio_group_fd); int rte_vfio_setup_device(__rte_unused const char *sysfs_base, __rte_unused const char *dev_addr, @@ -779,7 +780,7 @@ int rte_vfio_noiommu_is_enabled(void) return 0; } -int rte_vfio_clear_group(int vfio_group_fd) +int rte_vfio_clear_group(__rte_unused int vfio_group_fd) { return 0; }