[dpdk-dev] net/sfc/base: fix unused argument warning

Message ID 1516344426-17965-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Andrew Rybchenko Jan. 19, 2018, 6:47 a.m. UTC
  From: Andy Moreton <amoreton@solarflare.com>

The type_data argument to ef10_rx_qcreate is only used
in builds with EFSYS_OPT_RX_PACKED_STREAM. note this as
an usued argument to avoid warnings in builds without
packed stream support.

Fixes: b749646dade4 ("net/sfc/base: add function to create packed stream RxQ")

Signed-off-by: Andy Moreton <amoreton@solarflare.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/base/ef10_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit Jan. 19, 2018, 7:50 p.m. UTC | #1
On 1/19/2018 6:47 AM, Andrew Rybchenko wrote:
> From: Andy Moreton <amoreton@solarflare.com>
> 
> The type_data argument to ef10_rx_qcreate is only used
> in builds with EFSYS_OPT_RX_PACKED_STREAM. note this as
> an usued argument to avoid warnings in builds without
> packed stream support.
> 
> Fixes: b749646dade4 ("net/sfc/base: add function to create packed stream RxQ")
> 
> Signed-off-by: Andy Moreton <amoreton@solarflare.com>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/sfc/base/ef10_rx.c b/drivers/net/sfc/base/ef10_rx.c
index 85110ef..2bb6705 100644
--- a/drivers/net/sfc/base/ef10_rx.c
+++ b/drivers/net/sfc/base/ef10_rx.c
@@ -940,7 +940,7 @@  ef10_rx_qcreate(
 	boolean_t want_inner_classes;
 	unsigned int ps_buf_size;
 
-	_NOTE(ARGUNUSED(id, erp))
+	_NOTE(ARGUNUSED(id, erp, type_data))
 
 	EFX_STATIC_ASSERT(EFX_EV_RX_NLABELS == (1 << ESF_DZ_RX_QLABEL_WIDTH));
 	EFSYS_ASSERT3U(label, <, EFX_EV_RX_NLABELS);