[dpdk-dev] net/failsafe: fix default Rx offload capabilities

Message ID 1516354968-13992-1-git-send-email-motih@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Moti Haimovsky Jan. 19, 2018, 9:42 a.m. UTC
  This commit enhances the default Rx offload capabilities of the
failsafe device to initially support all possible capabilities.
This is done in order to support a wider range of Rx offloads
provided by different slave devices.

Fixes: 2199a208232e ("net/failsafe: use new Rx offloads API")
Cc: stable@dpdk.org

Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
 drivers/net/failsafe/failsafe_ops.c | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)
  

Comments

Gaëtan Rivet Jan. 19, 2018, 10:33 a.m. UTC | #1
Hi Moti,

On Fri, Jan 19, 2018 at 11:42:48AM +0200, Moti Haimovsky wrote:
> This commit enhances the default Rx offload capabilities of the
> failsafe device to initially support all possible capabilities.
> This is done in order to support a wider range of Rx offloads
> provided by different slave devices.
> 
> Fixes: 2199a208232e ("net/failsafe: use new Rx offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
  
Ferruh Yigit Jan. 19, 2018, 8:06 p.m. UTC | #2
On 1/19/2018 10:33 AM, Gaëtan Rivet wrote:
> Hi Moti,
> 
> On Fri, Jan 19, 2018 at 11:42:48AM +0200, Moti Haimovsky wrote:
>> This commit enhances the default Rx offload capabilities of the
>> failsafe device to initially support all possible capabilities.
>> This is done in order to support a wider range of Rx offloads
>> provided by different slave devices.
>>
>> Fixes: 2199a208232e ("net/failsafe: use new Rx offloads API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Squashed into relevant commit in next-net, thanks.
  

Patch

diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
index a2c74f5..3384c3d 100644
--- a/drivers/net/failsafe/failsafe_ops.c
+++ b/drivers/net/failsafe/failsafe_ops.c
@@ -72,18 +72,38 @@ 
 	 */
 	.rx_offload_capa =
 		DEV_RX_OFFLOAD_VLAN_STRIP |
-		DEV_RX_OFFLOAD_QINQ_STRIP |
 		DEV_RX_OFFLOAD_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_UDP_CKSUM |
 		DEV_RX_OFFLOAD_TCP_CKSUM |
-		DEV_RX_OFFLOAD_TCP_LRO,
+		DEV_RX_OFFLOAD_TCP_LRO |
+		DEV_RX_OFFLOAD_QINQ_STRIP |
+		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
+		DEV_RX_OFFLOAD_MACSEC_STRIP |
+		DEV_RX_OFFLOAD_HEADER_SPLIT |
+		DEV_RX_OFFLOAD_VLAN_FILTER |
+		DEV_RX_OFFLOAD_VLAN_EXTEND |
+		DEV_RX_OFFLOAD_JUMBO_FRAME |
+		DEV_RX_OFFLOAD_CRC_STRIP |
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_TIMESTAMP |
+		DEV_RX_OFFLOAD_SECURITY,
 	.rx_queue_offload_capa =
 		DEV_RX_OFFLOAD_VLAN_STRIP |
-		DEV_RX_OFFLOAD_QINQ_STRIP |
 		DEV_RX_OFFLOAD_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_UDP_CKSUM |
 		DEV_RX_OFFLOAD_TCP_CKSUM |
-		DEV_RX_OFFLOAD_TCP_LRO,
+		DEV_RX_OFFLOAD_TCP_LRO |
+		DEV_RX_OFFLOAD_QINQ_STRIP |
+		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
+		DEV_RX_OFFLOAD_MACSEC_STRIP |
+		DEV_RX_OFFLOAD_HEADER_SPLIT |
+		DEV_RX_OFFLOAD_VLAN_FILTER |
+		DEV_RX_OFFLOAD_VLAN_EXTEND |
+		DEV_RX_OFFLOAD_JUMBO_FRAME |
+		DEV_RX_OFFLOAD_CRC_STRIP |
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_TIMESTAMP |
+		DEV_RX_OFFLOAD_SECURITY,
 	.tx_offload_capa = 0x0,
 	.flow_type_rss_offloads = 0x0,
 };