diff mbox

[dpdk-dev] eal: fix a memory leak in regexp log level set API

Message ID 1516554310-28232-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Andrew Rybchenko Jan. 21, 2018, 5:05 p.m. UTC 
  From: Ivan Malov <ivan.malov@oktetlabs.ru>

Fixes: a5279180f510 ("eal: change several log levels matching a regexp")
Cc: stable@dpdk.org

Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_eal/common/eal_common_log.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ferruh Yigit Jan. 22, 2018, 2:46 a.m. UTC | #1 
On 1/21/2018 5:05 PM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> 
> Fixes: a5279180f510 ("eal: change several log levels matching a regexp")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Olivier Matz Jan. 22, 2018, 1:17 p.m. UTC | #2 
On Sun, Jan 21, 2018 at 05:05:10PM +0000, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> 
> Fixes: a5279180f510 ("eal: change several log levels matching a regexp")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thomas Monjalon Jan. 25, 2018, 10:33 p.m. UTC | #3 
22/01/2018 14:17, Olivier Matz:
> On Sun, Jan 21, 2018 at 05:05:10PM +0000, Andrew Rybchenko wrote:
> > From: Ivan Malov <ivan.malov@oktetlabs.ru>
> > 
> > Fixes: a5279180f510 ("eal: change several log levels matching a regexp")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index 5a3400e..37b2e20 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -110,6 +110,8 @@  rte_log_set_level_regexp(const char *pattern, uint32_t level)
 			rte_logs.dynamic_types[i].loglevel = level;
 	}
 
+	regfree(&r);
+
 	return 0;
 }