diff mbox

[dpdk-dev] app/testpmd: fix dereference null return valiue

Message ID 20180122154553.108360-1-jasvinder.singh@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Jasvinder Singh Jan. 22, 2018, 3:45 p.m. UTC 
  Calloc() function might returns NULL due to insufficient space. Therefore,
check for handling memory allocation failure is added.

Coverity issue: 257030
Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 app/test-pmd/tm.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Monjalon Jan. 31, 2018, 10:29 p.m. UTC | #1 
22/01/2018 16:45, Jasvinder Singh:
> Calloc() function might returns NULL due to insufficient space. Therefore,
> check for handling memory allocation failure is added.
> 
> Coverity issue: 257030
> Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/app/test-pmd/tm.c b/app/test-pmd/tm.c
index b76335c..7231552 100644
--- a/app/test-pmd/tm.c
+++ b/app/test-pmd/tm.c
@@ -575,6 +575,10 @@  softport_tm_tc_node_add(portid_t port_id, struct tm_hierarchy *h,
 				tc_parent_node_id = h->pipe_node_id[i][j];
 				tnp.shared_shaper_id =
 					(uint32_t *)calloc(1, sizeof(uint32_t));
+				if (tnp.shared_shaper_id == NULL) {
+					printf("Shared shaper mem alloc err\n");
+					return -1;
+				}
 				tnp.shared_shaper_id[0] = k;
 				pos = j + (i * PIPE_NODES_PER_SUBPORT);
 				h->tc_node_id[pos][k] =