diff mbox

[dpdk-dev] net/bonding: check dequeue result before proceeding

Message ID 1516639436-15040-1-git-send-email-radu.nicolau@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Radu Nicolau Jan. 22, 2018, 4:43 p.m. UTC 
  Fixes Coverity issue 257015

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

John McNamara Jan. 23, 2018, 5:43 p.m. UTC | #1 
> -----Original Message-----
> From: Nicolau, Radu
> Sent: Monday, January 22, 2018 4:44 PM
> To: dev@dpdk.org
> Cc: Kovacevic, Marko <marko.kovacevic@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> Yigit, Ferruh <ferruh.yigit@intel.com>; Nicolau, Radu
> <radu.nicolau@intel.com>
> Subject: [PATCH] net/bonding: check dequeue result before proceeding
> 
> Fixes Coverity issue 257015
> 

Hi Radu,

You should also include the fixes line in the commit message and CC stable@dpdk.org as well:

    Fixes: 09150784a776 ("net/bonding: burst mode hash calculation")
    Coverity issue: 257015
    Cc: stable@dpdk.org

John
diff mbox

Patch

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 158f3aa..cc06ff4 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1435,17 +1435,17 @@  bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
 		if (likely(rte_ring_empty(port->tx_ring)))
 			continue;
 
-		rte_ring_dequeue(port->tx_ring,	(void **)&ctrl_pkt);
-
-		slave_tx_count = rte_eth_tx_burst(slave_port_ids[i],
+		if (rte_ring_dequeue(port->tx_ring,
+				     (void **)&ctrl_pkt) != -ENOENT) {
+			slave_tx_count = rte_eth_tx_burst(slave_port_ids[i],
 					bd_tx_q->queue_id, &ctrl_pkt, 1);
-
-		/*
-		 * re-enqueue LAG control plane packets to buffering
-		 * ring if transmission fails so the packet isn't lost.
-		 */
-		if (slave_tx_count != 1)
-			rte_ring_enqueue(port->tx_ring,	ctrl_pkt);
+			/*
+			 * re-enqueue LAG control plane packets to buffering
+			 * ring if transmission fails so the packet isn't lost.
+			 */
+			if (slave_tx_count != 1)
+				rte_ring_enqueue(port->tx_ring,	ctrl_pkt);
+		}
 	}
 
 	return total_tx_count;