diff mbox

[dpdk-dev] drivers/event: fix resource leak in selftest

Message ID 20180122174601.19217-1-pbhagavatula@caviumnetworks.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Pavan Nikhilesh Jan. 22, 2018, 5:46 p.m. UTC 
  Free resources leak in eventdev selftests.

Coverity issue: 257044
Coverity issue: 257047
Coverity issue: 257009
Fixes: 9ef576176db0 ("test/eventdev: add octeontx multi queue and multi port")
Fixes: 3a17ff401f1e ("test/eventdev: add basic SW tests")
Fixes: 5e6eb5ccd788 ("event/sw: make test standalone")

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 drivers/event/octeontx/ssovf_evdev_selftest.c | 4 +++-
 drivers/event/sw/sw_evdev_selftest.c          | 6 +++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

Comments

Van Haaren, Harry Jan. 23, 2018, 2:17 p.m. UTC | #1 
> From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> Sent: Monday, January 22, 2018 5:46 PM
> To: jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] drivers/event: fix resource leak in selftest
> 
> Free resources leak in eventdev selftests.
> 
> Coverity issue: 257044
> Coverity issue: 257047
> Coverity issue: 257009
> Fixes: 9ef576176db0 ("test/eventdev: add octeontx multi queue and multi
> port")
> Fixes: 3a17ff401f1e ("test/eventdev: add basic SW tests")
> Fixes: 5e6eb5ccd788 ("event/sw: make test standalone")
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Thomas Monjalon Jan. 24, 2018, 6:01 p.m. UTC | #2 
23/01/2018 15:17, Van Haaren, Harry:
> > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Monday, January 22, 2018 5:46 PM
> > To: jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> > <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] drivers/event: fix resource leak in selftest
> > 
> > Free resources leak in eventdev selftests.
> > 
> > Coverity issue: 257044
> > Coverity issue: 257047
> > Coverity issue: 257009
> > Fixes: 9ef576176db0 ("test/eventdev: add octeontx multi queue and multi
> > port")
> > Fixes: 3a17ff401f1e ("test/eventdev: add basic SW tests")
> > Fixes: 5e6eb5ccd788 ("event/sw: make test standalone")
> > 
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/event/octeontx/ssovf_evdev_selftest.c b/drivers/event/octeontx/ssovf_evdev_selftest.c
index 3866ba968..5e012a95a 100644
--- a/drivers/event/octeontx/ssovf_evdev_selftest.c
+++ b/drivers/event/octeontx/ssovf_evdev_selftest.c
@@ -624,8 +624,10 @@  launch_workers_and_wait(int (*master_worker)(void *),
 
 	ret = rte_event_dequeue_timeout_ticks(evdev,
 		rte_rand() % 10000000/* 10ms */, &dequeue_tmo_ticks);
-	if (ret)
+	if (ret) {
+		free(param);
 		return -1;
+	}
 
 	param[0].total_events = &atomic_total_events;
 	param[0].sched_type = sched_type;
diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c
index 8c2eef569..78d30e07a 100644
--- a/drivers/event/sw/sw_evdev_selftest.c
+++ b/drivers/event/sw/sw_evdev_selftest.c
@@ -3016,9 +3016,12 @@  static struct rte_mempool *eventdev_func_mempool;
 int
 test_sw_eventdev(void)
 {
-	struct test *t = malloc(sizeof(struct test));
+	struct test *t;
 	int ret;
 
+	t = malloc(sizeof(struct test));
+	if (t == NULL)
+		return -1;
 	/* manually initialize the op, older gcc's complain on static
 	 * initialization of struct elements that are a bitfield.
 	 */
@@ -3236,6 +3239,7 @@  test_sw_eventdev(void)
 	printf("SW Eventdev Selftest Successful.\n");
 	return 0;
 test_fail:
+	free(t);
 	printf("SW Eventdev Selftest Failed.\n");
 	return -1;
 }