[dpdk-dev] examples/flow_filtering: fix incorrect port id size

Message ID 20180124061006.38304-1-zhiyong.yang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Yang, Zhiyong Jan. 24, 2018, 6:10 a.m. UTC
  Ethdev port id has been extended 16bits from 8bits in DPDK 17.11 release,
the patch fixes mismatch use.

Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API")
Cc: stable@dpdk.org
Cc: orika@mellanox.com
Cc: ferruh.yigit@intel.com
Cc: thomas@monjalon.net

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 examples/flow_filtering/flow_blocks.c | 4 ++--
 examples/flow_filtering/main.c        | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
  

Comments

Ferruh Yigit Jan. 25, 2018, 2:05 p.m. UTC | #1
On 1/24/2018 6:10 AM, Zhiyong Yang wrote:
> Ethdev port id has been extended 16bits from 8bits in DPDK 17.11 release,
> the patch fixes mismatch use.
> 
> Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API")
> Cc: stable@dpdk.org
> Cc: orika@mellanox.com
> Cc: ferruh.yigit@intel.com
> Cc: thomas@monjalon.net
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
  
Ferruh Yigit Jan. 25, 2018, 2:11 p.m. UTC | #2
On 1/25/2018 2:05 PM, Ferruh Yigit wrote:
> On 1/24/2018 6:10 AM, Zhiyong Yang wrote:
>> Ethdev port id has been extended 16bits from 8bits in DPDK 17.11 release,
>> the patch fixes mismatch use.
>>
>> Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API")
>> Cc: stable@dpdk.org
>> Cc: orika@mellanox.com
>> Cc: ferruh.yigit@intel.com
>> Cc: thomas@monjalon.net
>>
>> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/examples/flow_filtering/flow_blocks.c b/examples/flow_filtering/flow_blocks.c
index f92df1024..61b045af3 100644
--- a/examples/flow_filtering/flow_blocks.c
+++ b/examples/flow_filtering/flow_blocks.c
@@ -33,7 +33,7 @@ 
 #define MAX_PATTERN_NUM		4
 
 struct rte_flow *
-generate_ipv4_flow(uint8_t port_id, uint16_t rx_q,
+generate_ipv4_flow(uint16_t port_id, uint16_t rx_q,
 		uint32_t src_ip, uint32_t src_mask,
 		uint32_t dest_ip, uint32_t dest_mask,
 		struct rte_flow_error *error);
@@ -62,7 +62,7 @@  generate_ipv4_flow(uint8_t port_id, uint16_t rx_q,
  *   A flow if the rule could be created else return NULL.
  */
 struct rte_flow *
-generate_ipv4_flow(uint8_t port_id, uint16_t rx_q,
+generate_ipv4_flow(uint16_t port_id, uint16_t rx_q,
 		uint32_t src_ip, uint32_t src_mask,
 		uint32_t dest_ip, uint32_t dest_mask,
 		struct rte_flow_error *error)
diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
index 58e26859f..cc955cd90 100644
--- a/examples/flow_filtering/main.c
+++ b/examples/flow_filtering/main.c
@@ -58,7 +58,7 @@ 
 
 static volatile bool force_quit;
 
-static uint8_t port_id;
+static uint16_t port_id;
 static uint16_t nr_queues = 5;
 static uint8_t selected_queue = 1;
 struct rte_mempool *mbuf_pool;