diff mbox

[dpdk-dev] usertools/devbind: fix kernel module reporting

Message ID 31ffe6155e29c0f5f05e8b03aa82e7b2fb2448df.1516789244.git.anatoly.burakov@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Anatoly Burakov Jan. 24, 2018, 10:26 a.m. UTC 
  lspci reports kernel modules in "Module" string, but devbind
expects it to be "Module_str". Fix it up similar to how we fix
up "Driver" to be "Driver_str".

Cc: stable@dpdk.org

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---

Notes:
    devbind status before changes:
    
    Other Network devices
    =====================
    0000:08:00.0 '82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb' unused=igb_uio
    
    devbind status after changes:
    
    Other Network devices
    =====================
    0000:08:00.0 '82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb' unused=ixgbe,igb_uio
    
    Note that "ixgbe" driver is now shown as "unused" for unbound device.
    
    Also, no idea if this was ever working to begin with, so no fixline tag.

 usertools/dpdk-devbind.py | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon Feb. 6, 2018, 1:17 a.m. UTC | #1 
24/01/2018 11:26, Anatoly Burakov:
> lspci reports kernel modules in "Module" string, but devbind
> expects it to be "Module_str". Fix it up similar to how we fix
> up "Driver" to be "Driver_str".
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Fixes: c3ce205d5729 ("usertools: optimize lspci invocation")

Applied, thanks
diff mbox

Patch

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 894b519..6bdb291 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -249,6 +249,8 @@  def get_device_details(devices_type):
                 # of dictionary key names
                 if "Driver" in dev.keys():
                     dev["Driver_str"] = dev.pop("Driver")
+                if "Module" in dev.keys():
+                    dev["Module_str"] = dev.pop("Module")
                 # use dict to make copy of dev
                 devices[dev["Slot"]] = dict(dev)
             # Clear previous device's data