[dpdk-dev] net/mlx5: use the RSS table max size from config

Message ID 0a5f6aa5e5801d57ec8c77377d78eeb2b54a4b85.1516868356.git.nelio.laranjeiro@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Nélio Laranjeiro Jan. 25, 2018, 8:19 a.m. UTC
  Maximum indirection table size has not been updated accordingly.

Fixes: 7fe24446e946 ("net/mlx5: add device configuration structure")
Cc: shahafs@mellanox.com

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 drivers/net/mlx5/mlx5.h     | 1 -
 drivers/net/mlx5/mlx5_rxq.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
  

Comments

Shahaf Shuler Jan. 25, 2018, 3:56 p.m. UTC | #1
Thursday, January 25, 2018 10:20 AM, Nelio Laranjeiro:
> Subject: [PATCH] net/mlx5: use the RSS table max size from config
> 
> Maximum indirection table size has not been updated accordingly.
> 
> Fixes: 7fe24446e946 ("net/mlx5: add device configuration structure")
> Cc: shahafs@mellanox.com
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
>  drivers/net/mlx5/mlx5.h     | 1 -
>  drivers/net/mlx5/mlx5_rxq.c | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index
> a7ec607c3..2602267c3 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -160,7 +160,6 @@ struct priv {
>  	unsigned int txqs_n; /* TX queues array size. */
>  	struct mlx5_rxq_data *(*rxqs)[]; /* RX queues. */
>  	struct mlx5_txq_data *(*txqs)[]; /* TX queues. */
> -	unsigned int ind_table_max_size; /* Maximum indirection table size.
> */
>  	struct rte_eth_rss_conf rss_conf; /* RSS configuration. */
>  	struct rte_intr_handle intr_handle; /* Interrupt handler. */
>  	unsigned int (*reta_idx)[]; /* RETA index table. */ diff --git
> a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index
> 0274ccf31..3c716b960 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -1203,7 +1203,7 @@ mlx5_priv_ind_table_ibv_new(struct priv *priv,
> uint16_t queues[],
>  	struct mlx5_ind_table_ibv *ind_tbl;
>  	const unsigned int wq_n = rte_is_power_of_2(queues_n) ?
>  		log2above(queues_n) :
> -		log2above(priv->ind_table_max_size);
> +		log2above(priv->config.ind_table_max_size);
>  	struct ibv_wq *wq[1 << wq_n];
>  	unsigned int i;
>  	unsigned int j;

Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Merged to next-net-mlx, thanks. 

> --
> 2.11.0
  

Patch

diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index a7ec607c3..2602267c3 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -160,7 +160,6 @@  struct priv {
 	unsigned int txqs_n; /* TX queues array size. */
 	struct mlx5_rxq_data *(*rxqs)[]; /* RX queues. */
 	struct mlx5_txq_data *(*txqs)[]; /* TX queues. */
-	unsigned int ind_table_max_size; /* Maximum indirection table size. */
 	struct rte_eth_rss_conf rss_conf; /* RSS configuration. */
 	struct rte_intr_handle intr_handle; /* Interrupt handler. */
 	unsigned int (*reta_idx)[]; /* RETA index table. */
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 0274ccf31..3c716b960 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -1203,7 +1203,7 @@  mlx5_priv_ind_table_ibv_new(struct priv *priv, uint16_t queues[],
 	struct mlx5_ind_table_ibv *ind_tbl;
 	const unsigned int wq_n = rte_is_power_of_2(queues_n) ?
 		log2above(queues_n) :
-		log2above(priv->ind_table_max_size);
+		log2above(priv->config.ind_table_max_size);
 	struct ibv_wq *wq[1 << wq_n];
 	unsigned int i;
 	unsigned int j;