diff mbox

[dpdk-dev] net/mlx5: fix reception of multiple mac addresses

Message ID 8d4931d99cd295d8779aefa21900a4e2779e7000.1516868517.git.nelio.laranjeiro@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Nélio Laranjeiro Jan. 25, 2018, 8:22 a.m. UTC 
  When promiscuous is disabled, adding/removing a mac address is ignored
causing the packet to not be received or still being received corresponding
to the add or remove request.

Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
Cc: stable@dpdk.org

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 drivers/net/mlx5/mlx5_mac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Shahaf Shuler Jan. 25, 2018, 4 p.m. UTC | #1 
Thursday, January 25, 2018 10:22 AM, Nelio Laranjeiro:
> Subject: [PATCH] net/mlx5: fix reception of multiple mac addresses
> 
> When promiscuous is disabled, adding/removing a mac address is ignored
> causing the packet to not be received or still being received corresponding to
> the add or remove request.
> 
> Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
>  drivers/net/mlx5/mlx5_mac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c
> index a5e78ec8d..a1cb987cb 100644
> --- a/drivers/net/mlx5/mlx5_mac.c
> +++ b/drivers/net/mlx5/mlx5_mac.c
> @@ -95,7 +95,7 @@ mlx5_mac_addr_remove(struct rte_eth_dev *dev,
> uint32_t index)  {
>  	assert(index < MLX5_MAX_MAC_ADDRESSES);
>  	memset(&dev->data->mac_addrs[index], 0, sizeof(struct
> ether_addr));
> -	if (!dev->data->promiscuous && !dev->data->all_multicast)
> +	if (!dev->data->promiscuous)
>  		mlx5_traffic_restart(dev);
>  }
> 
> @@ -134,7 +134,7 @@ mlx5_mac_addr_add(struct rte_eth_dev *dev, struct
> ether_addr *mac,
>  		return EADDRINUSE;
>  	}
>  	dev->data->mac_addrs[index] = *mac;
> -	if (!dev->data->promiscuous && !dev->data->all_multicast)
> +	if (!dev->data->promiscuous)
>  		mlx5_traffic_restart(dev);
>  	return ret;
>  }
> --

Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Applied to next-net-mlx, thanks. 


> 2.11.0
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c
index a5e78ec8d..a1cb987cb 100644
--- a/drivers/net/mlx5/mlx5_mac.c
+++ b/drivers/net/mlx5/mlx5_mac.c
@@ -95,7 +95,7 @@  mlx5_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index)
 {
 	assert(index < MLX5_MAX_MAC_ADDRESSES);
 	memset(&dev->data->mac_addrs[index], 0, sizeof(struct ether_addr));
-	if (!dev->data->promiscuous && !dev->data->all_multicast)
+	if (!dev->data->promiscuous)
 		mlx5_traffic_restart(dev);
 }
 
@@ -134,7 +134,7 @@  mlx5_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac,
 		return EADDRINUSE;
 	}
 	dev->data->mac_addrs[index] = *mac;
-	if (!dev->data->promiscuous && !dev->data->all_multicast)
+	if (!dev->data->promiscuous)
 		mlx5_traffic_restart(dev);
 	return ret;
 }