diff mbox

[dpdk-dev] doc: announce control mbuf removal

Message ID 20180129093027.16357-1-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Olivier Matz Jan. 29, 2018, 9:30 a.m. UTC 
  Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html
Link: http://dpdk.org/dev/patchwork/patch/32041/

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Jerin Jacob Jan. 29, 2018, 10:04 a.m. UTC | #1 
-----Original Message-----
> Date: Mon, 29 Jan 2018 10:30:27 +0100
> From: Olivier Matz <olivier.matz@6wind.com>
> To: dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>, John McNamara
>  <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>
> CC: Kevin Wilson <wkevils@gmail.com>, Konstantin Ananyev
>  <konstantin.ananyev@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: announce control mbuf removal
> X-Mailer: git-send-email 2.11.0
> 
> Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html
> Link: http://dpdk.org/dev/patchwork/patch/32041/
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index d59ad5988..e98ce6a0a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -59,3 +59,16 @@ Deprecation Notices
>    be added between the producer and consumer structures. The size of the
>    structure and the offset of the fields will remain the same on
>    platforms with 64B cache line, but will change on other platforms.
> +
> +* mbuf: The control mbuf API will be removed in v18.05. The impacted
> +  functions and macros are:
> +
> +  - ``rte_ctrlmbuf_init()``
> +  - ``rte_ctrlmbuf_alloc()``
> +  - ``rte_ctrlmbuf_free()``
> +  - ``rte_ctrlmbuf_data()``
> +  - ``rte_ctrlmbuf_len()``
> +  - ``rte_is_ctrlmbuf()``
> +  - ``CTRL_MBUF_FLAG``
> +
> +  The packet mbuf API should be used as a replacement.
> -- 
> 2.11.0
>
Olivier Matz Feb. 12, 2018, 10:22 a.m. UTC | #2 
Hi,

Please, any other comments or acks for this one?

Thanks
Olivier


On Mon, Jan 29, 2018 at 10:30:27AM +0100, Olivier Matz wrote:
> Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html
> Link: http://dpdk.org/dev/patchwork/patch/32041/
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index d59ad5988..e98ce6a0a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -59,3 +59,16 @@ Deprecation Notices
>    be added between the producer and consumer structures. The size of the
>    structure and the offset of the fields will remain the same on
>    platforms with 64B cache line, but will change on other platforms.
> +
> +* mbuf: The control mbuf API will be removed in v18.05. The impacted
> +  functions and macros are:
> +
> +  - ``rte_ctrlmbuf_init()``
> +  - ``rte_ctrlmbuf_alloc()``
> +  - ``rte_ctrlmbuf_free()``
> +  - ``rte_ctrlmbuf_data()``
> +  - ``rte_ctrlmbuf_len()``
> +  - ``rte_is_ctrlmbuf()``
> +  - ``CTRL_MBUF_FLAG``
> +
> +  The packet mbuf API should be used as a replacement.
> -- 
> 2.11.0
>
Cristian Dumitrescu Feb. 12, 2018, 10:33 a.m. UTC | #3 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz
> Sent: Monday, February 12, 2018 10:22 AM
> To: dev@dpdk.org; Neil Horman <nhorman@tuxdriver.com>; Mcnamara,
> John <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>
> Cc: Kevin Wilson <wkevils@gmail.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: announce control mbuf removal
> 
> Hi,
> 
> Please, any other comments or acks for this one?
> 
> Thanks
> Olivier
> 
> 
> On Mon, Jan 29, 2018 at 10:30:27AM +0100, Olivier Matz wrote:
> > Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html
> > Link: http://dpdk.org/dev/patchwork/patch/32041/
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>


> > ---
> >  doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> > index d59ad5988..e98ce6a0a 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -59,3 +59,16 @@ Deprecation Notices
> >    be added between the producer and consumer structures. The size of the
> >    structure and the offset of the fields will remain the same on
> >    platforms with 64B cache line, but will change on other platforms.
> > +
> > +* mbuf: The control mbuf API will be removed in v18.05. The impacted
> > +  functions and macros are:
> > +
> > +  - ``rte_ctrlmbuf_init()``
> > +  - ``rte_ctrlmbuf_alloc()``
> > +  - ``rte_ctrlmbuf_free()``
> > +  - ``rte_ctrlmbuf_data()``
> > +  - ``rte_ctrlmbuf_len()``
> > +  - ``rte_is_ctrlmbuf()``
> > +  - ``CTRL_MBUF_FLAG``
> > +
> > +  The packet mbuf API should be used as a replacement.
> > --
> > 2.11.0
> >

We use control messages extensively in examples/ip_pipeline. Every time we needed control messages, we found that the control mbuf was too heavy and did not add any value, so we ended up creating custom data structures.
Bruce Richardson Feb. 12, 2018, 11:05 a.m. UTC | #4 
On Mon, Feb 12, 2018 at 11:22:15AM +0100, Olivier Matz wrote:
> Hi,
> 
> Please, any other comments or acks for this one?
> 
> Thanks
> Olivier

I would tend to support leaving the flag in place. Other than that, I
think the functions for it can go.
> 
> 
> On Mon, Jan 29, 2018 at 10:30:27AM +0100, Olivier Matz wrote:
> > Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html
> > Link: http://dpdk.org/dev/patchwork/patch/32041/
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> >  doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index d59ad5988..e98ce6a0a 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -59,3 +59,16 @@ Deprecation Notices
> >    be added between the producer and consumer structures. The size of the
> >    structure and the offset of the fields will remain the same on
> >    platforms with 64B cache line, but will change on other platforms.
> > +
> > +* mbuf: The control mbuf API will be removed in v18.05. The impacted
> > +  functions and macros are:
> > +
> > +  - ``rte_ctrlmbuf_init()``
> > +  - ``rte_ctrlmbuf_alloc()``
> > +  - ``rte_ctrlmbuf_free()``
> > +  - ``rte_ctrlmbuf_data()``
> > +  - ``rte_ctrlmbuf_len()``
> > +  - ``rte_is_ctrlmbuf()``
> > +  - ``CTRL_MBUF_FLAG``
> > +
> > +  The packet mbuf API should be used as a replacement.
> > -- 
> > 2.11.0
> >
Hemant Agrawal Feb. 13, 2018, 3:49 a.m. UTC | #5 
On 2/12/2018 3:52 PM, Olivier Matz wrote:
> On Mon, Jan 29, 2018 at 10:30:27AM +0100, Olivier Matz wrote:
>> Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html
>> Link: http://dpdk.org/dev/patchwork/patch/32041/
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>   doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index d59ad5988..e98ce6a0a 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -59,3 +59,16 @@ Deprecation Notices
>>     be added between the producer and consumer structures. The size of the
>>     structure and the offset of the fields will remain the same on
>>     platforms with 64B cache line, but will change on other platforms.
>> +
>> +* mbuf: The control mbuf API will be removed in v18.05. The impacted
>> +  functions and macros are:
>> +
>> +  - ``rte_ctrlmbuf_init()``
>> +  - ``rte_ctrlmbuf_alloc()``
>> +  - ``rte_ctrlmbuf_free()``
>> +  - ``rte_ctrlmbuf_data()``
>> +  - ``rte_ctrlmbuf_len()``
>> +  - ``rte_is_ctrlmbuf()``
>> +  - ``CTRL_MBUF_FLAG``
>> +
>> +  The packet mbuf API should be used as a replacement.
>> -- 
>> 2.11.0
>>
>
Thomas Monjalon Feb. 14, 2018, 12:02 a.m. UTC | #6 
29/01/2018 10:30, Olivier Matz:
> Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html
> Link: http://dpdk.org/dev/patchwork/patch/32041/
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> +* mbuf: The control mbuf API will be removed in v18.05. The impacted
> +  functions and macros are:
> +
> +  - ``rte_ctrlmbuf_init()``
> +  - ``rte_ctrlmbuf_alloc()``
> +  - ``rte_ctrlmbuf_free()``
> +  - ``rte_ctrlmbuf_data()``
> +  - ``rte_ctrlmbuf_len()``
> +  - ``rte_is_ctrlmbuf()``
> +  - ``CTRL_MBUF_FLAG``
> +
> +  The packet mbuf API should be used as a replacement.

Acked-by: Thomas Monjalon <thomas@monjalon.net>
Thomas Monjalon Feb. 14, 2018, 3:41 p.m. UTC | #7 
14/02/2018 01:02, Thomas Monjalon:
> 29/01/2018 10:30, Olivier Matz:
> > Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html
> > Link: http://dpdk.org/dev/patchwork/patch/32041/
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> > +* mbuf: The control mbuf API will be removed in v18.05. The impacted
> > +  functions and macros are:
> > +
> > +  - ``rte_ctrlmbuf_init()``
> > +  - ``rte_ctrlmbuf_alloc()``
> > +  - ``rte_ctrlmbuf_free()``
> > +  - ``rte_ctrlmbuf_data()``
> > +  - ``rte_ctrlmbuf_len()``
> > +  - ``rte_is_ctrlmbuf()``
> > +  - ``CTRL_MBUF_FLAG``
> > +
> > +  The packet mbuf API should be used as a replacement.
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied
diff mbox

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d59ad5988..e98ce6a0a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -59,3 +59,16 @@  Deprecation Notices
   be added between the producer and consumer structures. The size of the
   structure and the offset of the fields will remain the same on
   platforms with 64B cache line, but will change on other platforms.
+
+* mbuf: The control mbuf API will be removed in v18.05. The impacted
+  functions and macros are:
+
+  - ``rte_ctrlmbuf_init()``
+  - ``rte_ctrlmbuf_alloc()``
+  - ``rte_ctrlmbuf_free()``
+  - ``rte_ctrlmbuf_data()``
+  - ``rte_ctrlmbuf_len()``
+  - ``rte_is_ctrlmbuf()``
+  - ``CTRL_MBUF_FLAG``
+
+  The packet mbuf API should be used as a replacement.