diff mbox

[dpdk-dev] doc: announce PMD API change for set default MAC

Message ID 20180129171339.20896-1-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Olivier Matz Jan. 29, 2018, 5:13 p.m. UTC 
  Announce internal PMD API change in the function to set the default MAC
address. The objective is to be able to notify errors occurring in the
PMD.

Link: https://dpdk.org/dev/patchwork/patch/32284/

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 doc/guides/rel_notes/deprecation.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Andrew Rybchenko Jan. 30, 2018, 6:06 a.m. UTC | #1 
On 01/29/2018 08:13 PM, Olivier Matz wrote:
> Announce internal PMD API change in the function to set the default MAC
> address. The objective is to be able to notify errors occurring in the
> PMD.
>
> Link: https://dpdk.org/dev/patchwork/patch/32284/
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 43a39d827..8ad4407c2 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -76,3 +76,11 @@ Deprecation Notices
>   * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are
>     respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old
>     names will be removed in v18.08.
> +
> +* ethdev: The prototype and the behavior of
> +  ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code
> +  will be added to notify the caller if an error occurred in the PMD. In
> +  ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address
> +  will be copied in ``dev->data->mac_addrs[0]`` only if the operation is
> +  succesfull. This modification will only impact the PMDs, not the
> +  applications.

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Ferruh Yigit Jan. 31, 2018, 7:11 p.m. UTC | #2 
On 1/30/2018 6:06 AM, Andrew Rybchenko wrote:
> On 01/29/2018 08:13 PM, Olivier Matz wrote:
>> Announce internal PMD API change in the function to set the default MAC
>> address. The objective is to be able to notify errors occurring in the
>> PMD.
>>
>> Link: https://dpdk.org/dev/patchwork/patch/32284/
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>> ---
>>   doc/guides/rel_notes/deprecation.rst | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 43a39d827..8ad4407c2 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -76,3 +76,11 @@ Deprecation Notices
>>   * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are
>>     respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old
>>     names will be removed in v18.08.
>> +
>> +* ethdev: The prototype and the behavior of
>> +  ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code
>> +  will be added to notify the caller if an error occurred in the PMD. In
>> +  ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address
>> +  will be copied in ``dev->data->mac_addrs[0]`` only if the operation is
>> +  succesfull. This modification will only impact the PMDs, not the
>> +  applications.
> 
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Shahaf Shuler Feb. 13, 2018, 12:42 p.m. UTC | #3 
Wednesday, January 31, 2018 9:12 PM, Ferruh Yigit:
> On 1/30/2018 6:06 AM, Andrew Rybchenko wrote:

> > On 01/29/2018 08:13 PM, Olivier Matz wrote:

> >> Announce internal PMD API change in the function to set the default

> >> MAC address. The objective is to be able to notify errors occurring

> >> in the PMD.

> >>

> >> Link:

> >>

> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdp

> >>

> dk.org%2Fdev%2Fpatchwork%2Fpatch%2F32284%2F&data=02%7C01%7Csha

> hafs%40

> >>

> mellanox.com%7C5a25d2b43a32440d2e5c08d568de7559%7Ca652971c7d2e4d

> 9ba6a

> >>

> 4d149256f461b%7C0%7C0%7C636530227046083042&sdata=uMIQfiMB7pEFwi

> ELWH4Z

> >> gvHBpq%2FXuYDYr7B6ICB34kE%3D&reserved=0

> >>

> >> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

> >> ---

> >>   doc/guides/rel_notes/deprecation.rst | 8 ++++++++

> >>   1 file changed, 8 insertions(+)

> >>

> >> diff --git a/doc/guides/rel_notes/deprecation.rst

> >> b/doc/guides/rel_notes/deprecation.rst

> >> index 43a39d827..8ad4407c2 100644

> >> --- a/doc/guides/rel_notes/deprecation.rst

> >> +++ b/doc/guides/rel_notes/deprecation.rst

> >> @@ -76,3 +76,11 @@ Deprecation Notices

> >>   * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT``

> are

> >>     respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The

> old

> >>     names will be removed in v18.08.

> >> +

> >> +* ethdev: The prototype and the behavior of

> >> +  ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return

> >> +code

> >> +  will be added to notify the caller if an error occurred in the

> >> +PMD. In

> >> +  ``rte_eth_dev_default_mac_addr_set()``, the new default MAC

> >> +address

> >> +  will be copied in ``dev->data->mac_addrs[0]`` only if the

> >> +operation is

> >> +  succesfull. This modification will only impact the PMDs, not the

> >> +  applications.

> >

> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

> 

> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>


Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Thomas Monjalon Feb. 14, 2018, midnight UTC | #4 
> > >> +* ethdev: The prototype and the behavior of
> > >> +  ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return
> > >> +code
> > >> +  will be added to notify the caller if an error occurred in the
> > >> +PMD. In
> > >> +  ``rte_eth_dev_default_mac_addr_set()``, the new default MAC
> > >> +address
> > >> +  will be copied in ``dev->data->mac_addrs[0]`` only if the
> > >> +operation is
> > >> +  succesfull. This modification will only impact the PMDs, not the
> > >> +  applications.
> > >
> > > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > 
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>
Thomas Monjalon Feb. 14, 2018, 5:05 p.m. UTC | #5 
14/02/2018 01:00, Thomas Monjalon:
> > > >> +* ethdev: The prototype and the behavior of
> > > >> +  ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return
> > > >> +code
> > > >> +  will be added to notify the caller if an error occurred in the
> > > >> +PMD. In
> > > >> +  ``rte_eth_dev_default_mac_addr_set()``, the new default MAC
> > > >> +address
> > > >> +  will be copied in ``dev->data->mac_addrs[0]`` only if the
> > > >> +operation is
> > > >> +  succesfull. This modification will only impact the PMDs, not the
> > > >> +  applications.
> > > >
> > > > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > > 
> > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied
diff mbox

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 43a39d827..8ad4407c2 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -76,3 +76,11 @@  Deprecation Notices
 * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are
   respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old
   names will be removed in v18.08.
+
+* ethdev: The prototype and the behavior of
+  ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code
+  will be added to notify the caller if an error occurred in the PMD. In
+  ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address
+  will be copied in ``dev->data->mac_addrs[0]`` only if the operation is
+  succesfull. This modification will only impact the PMDs, not the
+  applications.