diff mbox

[dpdk-dev] app/testbbdev: fix unchecked return value

Message ID 1517406868-130533-1-git-send-email-amr.mokhtar@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Mokhtar, Amr Jan. 31, 2018, 1:54 p.m. UTC 
  add check for rte_bbdev_callback_register() retun

Coverity issue: 257027
Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")

Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
---
 app/test-bbdev/test_bbdev_perf.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon Jan. 31, 2018, 3:25 p.m. UTC | #1 
31/01/2018 14:54, Amr Mokhtar:
> add check for rte_bbdev_callback_register() retun
> 
> Coverity issue: 257027
> Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
> 
> Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index f7b51ca..21efad4 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -1557,9 +1557,11 @@  throughput_test(struct active_device *ad,
 			throughput_function = throughput_intr_lcore_enc;
 
 		/* Dequeue interrupt callback registration */
-		rte_bbdev_callback_register(ad->dev_id, RTE_BBDEV_EVENT_DEQUEUE,
-				dequeue_event_callback,
+		ret = rte_bbdev_callback_register(ad->dev_id,
+				RTE_BBDEV_EVENT_DEQUEUE, dequeue_event_callback,
 				&t_params);
+		if (ret < 0)
+			return ret;
 	} else {
 		if (test_vector.op_type == RTE_BBDEV_OP_TURBO_DEC)
 			throughput_function = throughput_pmd_lcore_dec;