diff mbox

[dpdk-dev] net/tap: fix ICC compilation fails

Message ID 20180201044300.12332-1-zhiyong.yang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yang, Zhiyong Feb. 1, 2018, 4:43 a.m. UTC 
  The following error is reported when compiling 18.02-rc2 usng ICC,
"transfer of control bypasses initialization of".
The patch fixes the issue.

Fixes: 1911c5edc6cd ("net/tap: fix eBPF RSS map key handling")
Cc: stable@dpdk.org
Cc: pascal.mazon@6wind.com
Cc: ferruh.yigit@intel.com
Cc: thomas@monjalon.net
Cc: ophirmu@mellanox.com

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 drivers/net/tap/tap_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon Feb. 1, 2018, 10:02 a.m. UTC | #1 
01/02/2018 05:43, Zhiyong Yang:
> The following error is reported when compiling 18.02-rc2 usng ICC,
> "transfer of control bypasses initialization of".
> The patch fixes the issue.
> 
> Fixes: 1911c5edc6cd ("net/tap: fix eBPF RSS map key handling")
> Cc: stable@dpdk.org

stable is not needed here

> Cc: pascal.mazon@6wind.com
> Cc: ferruh.yigit@intel.com
> Cc: thomas@monjalon.net
> Cc: ophirmu@mellanox.com
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c
index 212992e49..65657f0a0 100644
--- a/drivers/net/tap/tap_flow.c
+++ b/drivers/net/tap/tap_flow.c
@@ -1930,6 +1930,7 @@  static int bpf_rss_key(enum bpf_rss_key_e cmd, __u32 *key_idx)
 	static __u32 num_used_keys;
 	static __u32 rss_keys[MAX_RSS_KEYS] = {KEY_STAT_UNSPEC};
 	static __u32 rss_keys_initialized;
+	__u32 key;
 
 	switch (cmd) {
 	case KEY_CMD_GET:
@@ -1975,7 +1976,7 @@  static int bpf_rss_key(enum bpf_rss_key_e cmd, __u32 *key_idx)
 		 * map index as an out-of-range value and the release operation
 		 * will be silently ignored.
 		 */
-		__u32 key = *key_idx - KEY_IDX_OFFSET;
+		key = *key_idx - KEY_IDX_OFFSET;
 		if (key >= RTE_DIM(rss_keys))
 			break;