[dpdk-dev,v2] net/failsafe: fix strerror call in sub-eal
Checks
Commit Message
Ownership API returns a negative value, strerror expects a valid errno
value, thus positive.
Coverity issue: 260401
Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves")
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
v2: Fix coverity reference syntax in commit log.
drivers/net/failsafe/failsafe_eal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 2/1/2018 10:59 AM, Gaetan Rivet wrote:
> Ownership API returns a negative value, strerror expects a valid errno
> value, thus positive.
>
> Coverity issue: 260401
> Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves")
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied to dpdk-next-net/master, thanks.
@@ -79,9 +79,9 @@ fs_bus_init(struct rte_eth_dev *dev)
" %d named %s", i, da->name);
}
ret = rte_eth_dev_owner_set(pid, &PRIV(dev)->my_owner);
- if (ret) {
+ if (ret < 0) {
INFO("sub_device %d owner set failed (%s),"
- " will try again later", i, strerror(ret));
+ " will try again later", i, strerror(-ret));
continue;
} else if (strncmp(rte_eth_devices[pid].device->name, da->name,
strlen(da->name)) != 0) {