[dpdk-dev] net/ena: fix jumbo support in Rx offloads flags
Checks
Commit Message
ENA device supports Rx jumbo frames and such information needs to
be provided in the offloads flags.
Fixes: 7369f88f88c0 ("net/ena: convert to new Rx offloads API")
Signed-off-by: Rafal Kozik <rk@semihalf.com>
---
drivers/net/ena/ena_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
Comments
2018-02-01 14:06 GMT+01:00 Rafal Kozik <rk@semihalf.com>:
>
> ENA device supports Rx jumbo frames and such information needs to
> be provided in the offloads flags.
>
> Fixes: 7369f88f88c0 ("net/ena: convert to new Rx offloads API")
>
> Signed-off-by: Rafal Kozik <rk@semihalf.com>
Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>
> ---
> drivers/net/ena/ena_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index 83e0ae2..3588384 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -1561,6 +1561,8 @@ static void ena_infos_get(struct rte_eth_dev *dev,
> DEV_RX_OFFLOAD_UDP_CKSUM |
> DEV_RX_OFFLOAD_TCP_CKSUM;
>
> + rx_feat |= DEV_RX_OFFLOAD_JUMBO_FRAME;
> +
> /* Inform framework about available features */
> dev_info->rx_offload_capa = rx_feat;
> dev_info->rx_queue_offload_capa = rx_feat;
> --
> 2.7.4
>
On 2/1/2018 4:36 PM, Michał Krawczyk wrote:
> 2018-02-01 14:06 GMT+01:00 Rafal Kozik <rk@semihalf.com>:
>>
>> ENA device supports Rx jumbo frames and such information needs to
>> be provided in the offloads flags.
>>
>> Fixes: 7369f88f88c0 ("net/ena: convert to new Rx offloads API")
>>
>> Signed-off-by: Rafal Kozik <rk@semihalf.com>
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
Hi Michał,
Are you claiming your right on the patch as developer?
Or is the intention to ack the patch?
Acked-by: Michal Krawczyk <mk@semihalf.com>
>>
>> ---
>> drivers/net/ena/ena_ethdev.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
>> index 83e0ae2..3588384 100644
>> --- a/drivers/net/ena/ena_ethdev.c
>> +++ b/drivers/net/ena/ena_ethdev.c
>> @@ -1561,6 +1561,8 @@ static void ena_infos_get(struct rte_eth_dev *dev,
>> DEV_RX_OFFLOAD_UDP_CKSUM |
>> DEV_RX_OFFLOAD_TCP_CKSUM;
>>
>> + rx_feat |= DEV_RX_OFFLOAD_JUMBO_FRAME;
>> +
>> /* Inform framework about available features */
>> dev_info->rx_offload_capa = rx_feat;
>> dev_info->rx_queue_offload_capa = rx_feat;
>> --
>> 2.7.4
>>
2018-02-01 17:49 GMT+01:00 Ferruh Yigit <ferruh.yigit@intel.com>:
> On 2/1/2018 4:36 PM, Michał Krawczyk wrote:
>> 2018-02-01 14:06 GMT+01:00 Rafal Kozik <rk@semihalf.com>:
>>>
>>> ENA device supports Rx jumbo frames and such information needs to
>>> be provided in the offloads flags.
>>>
>>> Fixes: 7369f88f88c0 ("net/ena: convert to new Rx offloads API")
>>>
>>> Signed-off-by: Rafal Kozik <rk@semihalf.com>
>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>
> Hi Michał,
>
> Are you claiming your right on the patch as developer?
>
> Or is the intention to ack the patch?
> Acked-by: Michal Krawczyk <mk@semihalf.com>
>
Hi Ferruh,
yes, sorry. I meant to ack the patch.
Thanks,
Michal
>>>
>>> ---
>>> drivers/net/ena/ena_ethdev.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
>>> index 83e0ae2..3588384 100644
>>> --- a/drivers/net/ena/ena_ethdev.c
>>> +++ b/drivers/net/ena/ena_ethdev.c
>>> @@ -1561,6 +1561,8 @@ static void ena_infos_get(struct rte_eth_dev *dev,
>>> DEV_RX_OFFLOAD_UDP_CKSUM |
>>> DEV_RX_OFFLOAD_TCP_CKSUM;
>>>
>>> + rx_feat |= DEV_RX_OFFLOAD_JUMBO_FRAME;
>>> +
>>> /* Inform framework about available features */
>>> dev_info->rx_offload_capa = rx_feat;
>>> dev_info->rx_queue_offload_capa = rx_feat;
>>> --
>>> 2.7.4
>>>
>
On 2/1/2018 4:52 PM, Michał Krawczyk wrote:
> 2018-02-01 17:49 GMT+01:00 Ferruh Yigit <ferruh.yigit@intel.com>:
>> On 2/1/2018 4:36 PM, Michał Krawczyk wrote:
>>> 2018-02-01 14:06 GMT+01:00 Rafal Kozik <rk@semihalf.com>:
>>>>
>>>> ENA device supports Rx jumbo frames and such information needs to
>>>> be provided in the offloads flags.
>>>>
>>>> Fixes: 7369f88f88c0 ("net/ena: convert to new Rx offloads API")
>>>>
>>>> Signed-off-by: Rafal Kozik <rk@semihalf.com>
>> Acked-by: Michal Krawczyk <mk@semihalf.com>
Applied to dpdk-next-net/master, thanks.
@@ -1561,6 +1561,8 @@ static void ena_infos_get(struct rte_eth_dev *dev,
DEV_RX_OFFLOAD_UDP_CKSUM |
DEV_RX_OFFLOAD_TCP_CKSUM;
+ rx_feat |= DEV_RX_OFFLOAD_JUMBO_FRAME;
+
/* Inform framework about available features */
dev_info->rx_offload_capa = rx_feat;
dev_info->rx_queue_offload_capa = rx_feat;