diff mbox

[dpdk-dev,v3] app/testpmd: fix port DCB configuration

Message ID 20180205084820.5387-1-yanglong.wu@intel.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yanglong Wu Feb. 5, 2018, 8:48 a.m. UTC 
  The port_conf for the DCB configuration should
inherit the same configuration of the port.

Fix:0074d02fc("app/testpmd: convert to new Rx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
changing patch accoding to review
---
v3:
changing patch accoding to comments
---
 app/test-pmd/testpmd.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Shahaf Shuler Feb. 5, 2018, 8:59 a.m. UTC | #1 
Monday, February 5, 2018 10:48 AM, Yanglong Wu:
> Fix:0074d02fc("app/testpmd: convert to new Rx offloads API")

The fix line is still wrong. Use the one I suggested.

> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> v2:
> changing patch accoding to review
> ---
> v3:
> changing patch accoding to comments
> ---
>  app/test-pmd/testpmd.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 5dc8ccac5..da1d9bd3a 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid,
>  	/* Enter DCB configuration status */
>  	dcb_config = 1;
> 
> +	port_conf.rxmode = rte_port->dev_conf.rxmode;
> +	port_conf.txmode = rte_port->dev_conf.txmode;
> +
>  	/*set configuration of DCB in vt mode and DCB in non-vt mode*/
>  	retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs,
> pfc_en);
>  	if (retval < 0)
> --
> 2.11.0

Acked-by: Shahaf Shuler <shahafs@mellanox.com> (please include this on the next version if any).
diff mbox

Patch

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 5dc8ccac5..da1d9bd3a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2324,6 +2324,9 @@  init_port_dcb_config(portid_t pid,
 	/* Enter DCB configuration status */
 	dcb_config = 1;
 
+	port_conf.rxmode = rte_port->dev_conf.rxmode;
+	port_conf.txmode = rte_port->dev_conf.txmode;
+
 	/*set configuration of DCB in vt mode and DCB in non-vt mode*/
 	retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en);
 	if (retval < 0)