diff mbox

[dpdk-dev] net/mlx5: fix link speed

Message ID 1517832104-2800-1-git-send-email-yliu@fridaylinux.org (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yuanhan Liu Feb. 5, 2018, 12:01 p.m. UTC 
  When the link is down, mlx5 kernel driver reports the link speed as -1
(UNKNOWN_SPEED). We need turn it to 0 for such case, otherwise, it
will be re-queried again due to the link_speed is not 0, due to following
code:

  1201   if (((link->link_speed == 0) && link->link_status) ||
  1202           ((link->link_speed != 0) && !link->link_status)) {
  1203           /*
  1204            * Inconsistent status. Event likely occurred before the
  1205            * kernel netdevice exposes the new status.
  1206            */

Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")

Cc: stable@dpdk.org
Signed-off-by: Yuanhan Liu <yliu@fridaylinux.org>
---
 drivers/net/mlx5/mlx5_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Nélio Laranjeiro Feb. 5, 2018, 12:28 p.m. UTC | #1 
On Mon, Feb 05, 2018 at 08:01:44PM +0800, Yuanhan Liu wrote:
> When the link is down, mlx5 kernel driver reports the link speed as -1
> (UNKNOWN_SPEED). We need turn it to 0 for such case, otherwise, it
> will be re-queried again due to the link_speed is not 0, due to following
> code:
> 
>   1201   if (((link->link_speed == 0) && link->link_status) ||
>   1202           ((link->link_speed != 0) && !link->link_status)) {
>   1203           /*
>   1204            * Inconsistent status. Event likely occurred before the
>   1205            * kernel netdevice exposes the new status.
>   1206            */
> 
> Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")
> 
> Cc: stable@dpdk.org
> Signed-off-by: Yuanhan Liu <yliu@fridaylinux.org>

Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

> ---
>  drivers/net/mlx5/mlx5_ethdev.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index 6665076..492ca07 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -808,6 +808,10 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete)
>  		return -1;
>  	}
>  	dev_link.link_speed = ecmd->speed;
> +	if (link_speed == -1)
> +		dev_link.link_speed = 0;
> +	else
> +		dev_link.link_speed = link_speed;
>  	sc = ecmd->link_mode_masks[0] |
>  		((uint64_t)ecmd->link_mode_masks[1] << 32);
>  	priv->link_speed_capa = 0;
> -- 
> 2.7.4
> 

Thanks,
Shahaf Shuler Feb. 5, 2018, 1:39 p.m. UTC | #2 
Monday, February 5, 2018 2:29 PM, Nélio Laranjeiro:
> Subject: Re: [PATCH] net/mlx5: fix link speed
> 
> On Mon, Feb 05, 2018 at 08:01:44PM +0800, Yuanhan Liu wrote:
> > When the link is down, mlx5 kernel driver reports the link speed as -1
> > (UNKNOWN_SPEED). We need turn it to 0 for such case, otherwise, it
> > will be re-queried again due to the link_speed is not 0, due to
> > following
> > code:
> >
> >   1201   if (((link->link_speed == 0) && link->link_status) ||
> >   1202           ((link->link_speed != 0) && !link->link_status)) {
> >   1203           /*
> >   1204            * Inconsistent status. Event likely occurred before the
> >   1205            * kernel netdevice exposes the new status.
> >   1206            */
> >
> > Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")
> >
> > Cc: stable@dpdk.org
> > Signed-off-by: Yuanhan Liu <yliu@fridaylinux.org>
> 
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> 
> > ---
> >  drivers/net/mlx5/mlx5_ethdev.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> > b/drivers/net/mlx5/mlx5_ethdev.c index 6665076..492ca07 100644
> > --- a/drivers/net/mlx5/mlx5_ethdev.c
> > +++ b/drivers/net/mlx5/mlx5_ethdev.c
> > @@ -808,6 +808,10 @@ mlx5_link_update_unlocked_gs(struct
> rte_eth_dev *dev, int wait_to_complete)
> >  		return -1;
> >  	}
> >  	dev_link.link_speed = ecmd->speed;
> > +	if (link_speed == -1)

Looks like link_speed is not defined (code is not compiling).

> > +		dev_link.link_speed = 0;
> > +	else
> > +		dev_link.link_speed = link_speed;
> >  	sc = ecmd->link_mode_masks[0] |
> >  		((uint64_t)ecmd->link_mode_masks[1] << 32);
> >  	priv->link_speed_capa = 0;
> > --
> > 2.7.4
> >
> 
> Thanks,
> 
> --
> Nélio Laranjeiro
> 6WIND
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index 6665076..492ca07 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -808,6 +808,10 @@  mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete)
 		return -1;
 	}
 	dev_link.link_speed = ecmd->speed;
+	if (link_speed == -1)
+		dev_link.link_speed = 0;
+	else
+		dev_link.link_speed = link_speed;
 	sc = ecmd->link_mode_masks[0] |
 		((uint64_t)ecmd->link_mode_masks[1] << 32);
 	priv->link_speed_capa = 0;