Message ID | 1517839763-24122-2-git-send-email-matan@mellanox.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40D411B3D0; Mon, 5 Feb 2018 15:10:20 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10069.outbound.protection.outlook.com [40.107.1.69]) by dpdk.org (Postfix) with ESMTP id 70A2B1B37B; Mon, 5 Feb 2018 15:10:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Rzhbv4Tk6uDzlGmYsZmMXQx70d7bKYf2No1INwP00BE=; b=o8b0lD9inah1kY5A5BpmfCNmTlzp1Bo3LGWjWhsBtc/4Ve3sNDDCAUsw+/5ElBt1TLyfm72WyrwAln1On2AiuTLVgyEIOrMP3Xtzl54TKme24Mt9xb1jh+laLIsLb24Bjp5eEI2rk/GePC9hscioHAHO6kiscGm/J7N3/9SOIZQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0501MB2666.eurprd05.prod.outlook.com (2603:10a6:3:cb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Mon, 5 Feb 2018 14:10:16 +0000 From: Matan Azrad <matan@mellanox.com> To: Wenzhuo Lu <wenzhuo.lu@intel.com> Cc: dev@dpdk.org, stable@dpdk.org Date: Mon, 5 Feb 2018 14:09:21 +0000 Message-Id: <1517839763-24122-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1517839763-24122-1-git-send-email-matan@mellanox.com> References: <1517765225-11117-1-git-send-email-matan@mellanox.com> <1517839763-24122-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR02CA0061.eurprd02.prod.outlook.com (2603:10a6:802:14::32) To HE1PR0501MB2666.eurprd05.prod.outlook.com (2603:10a6:3:cb::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 52bd3bb8-e18b-4dae-c99e-08d56ca22f01 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR0501MB2666; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2666; 3:WuLbDnMJGt+ZXH20CPGB2Aa1EZ49AkDxJOTmxm0fZJp1Wlhs9bm8TNDN4LDCVvYo1i5KZxPW+BRtI9OPX+JndsnOND+KTRvTRa/MkfICTwhjtxThmu/YVWCARLsNX0qDmiWdiayUiWDZ9hAqpIZn0wPpBcEmExDbnhNED2V/89wUVx4yH2Lry1jTuD8jO3bk7GRS39gxpFDLYUUOqvX1PL+L3p1Y41Sgm/k/2dnNfkqxC9mmHkX26+kH47FmcssF; 25:znV9iyaJSKQpY3acLDwGAMzfNGlWIr8ni0X0cokZefSNXqyNDFt3A4oGsauH1U6TpqUCZVKWoIpcInVkaNhdyHvXJJRXnwnMneDOBG2joG4MeQGc41IhBbq2wAjOLBi0AO4AYt5K5g3PgK88msP0MoVQ6m82dAaDuBtN+jtYmnMIMOHzajVb19IMDUYU7cAztwPJaPirjmMtj9RJHm/WeujBF3G7GHt4gTJB8AT4T5ym4+U3ZckfrB4Gjq3qc65vGUaB5N4KaA6GZmpe7eirHiiBO45a+k6C4EVPhQe6uVMrHud3+c9D8JLSgZZ4pczOrJp84G1/q07+Lcu/gXFT/Q==; 31:vDOVSBlKK0leMzSvnDPaLvLVvqy0nd5O+BSdau9m8oO4/fFwEALk0/Jh8XkV7k1R7RF35wcQZvc57Vf+ROZHTmaeBMedTgx9aLAmO1kgj/FJPou2S+WzOU64Q1C1+Fbh59DLFJibm/e3G4WeO+ZUP6sCsh12EOTO79mCRfLt7Ke6isUtoQk4tYOCoyzLOX4483QdKpjH8Vio/yWBpJBheqfKOlgdei39AkOaOLkxUdc= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2666: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2666; 20:ATIYf986XqAPG5kXxzhzzHDvcOyewxSpBHQ8Rc13dh/pzXWO7KZTEXEehphogz9P1ybj7ul5LahakjAYnABg6HD3XiMqyw8F9PB9sJbExOVDRXBhKsSS0uk/gHkNiob6xRGi5K3+rFx4Tgonqzd0WcRNSOHXskEDfsDoEUxhrY3lcgn4mWZVt9ySllngbwtd0hlldwRAWj/Y2YcqF5Lfbv6aF5A6P1vn5rYWYbMMrmXbfbMCooENU0YfxhdJFW+cyp7wkKaowRCIV4RFeqNmd3JL1KRQbD/yKrQ3BhBPriJAldg2gKtLQT7ClQdAb0s3mzP/wAzOIJUh8NAxH1MxVq0H4VbQTCUEaVM53CrA8boQ0nHhJbPhsDSTN8E6SdaqT8p9VmZiDzhKkvvUzoo0/Q6avFe1rHeyacFX18R4AvvadvqtSo5wKsoaHdABNZHRJE8yT/dADMuiMFIsdocOEluJY6hvV2GrB3+6zIp61J9zeTOolvX3AaF3TGZ9fRBj; 4:svnuCzLGzHW+Rhjufepq1aaOV8m1s2i+7+gTTDx2F5KiW0iHXohq1tdpMA2c+a57Kihyto8te9FnEMYSJRzWbc8Mu1+qJD9/8vvMpOrUkMbpXgYafPKNHj14nyBchYA9W0IbDOCArP/nnpI3rBkwTXBc55tferoYdsQlCDKv5mobJR7tZgzDWpVH9SToj/7s1hHs/UQ7F43eJTg2+FK0BG+jUvBX2PcUSgz4vSFyYEnTKwn8hU1wCSZ8D1tL56HFkg9EdahqSCuTR5yGtJYEQg== X-Microsoft-Antispam-PRVS: <HE1PR0501MB2666885458266C0243EFBB16D2FE0@HE1PR0501MB2666.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231101)(2400082)(944501161)(6055026)(6041288)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0501MB2666; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2666; X-Forefront-PRVS: 0574D4712B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(346002)(39380400002)(376002)(366004)(189003)(199004)(3846002)(6116002)(316002)(26005)(305945005)(7736002)(8676002)(81166006)(6916009)(2950100002)(50466002)(5660300001)(6666003)(4720700003)(53936002)(8936002)(36756003)(33026002)(48376002)(68736007)(50226002)(106356001)(55016002)(51416003)(478600001)(25786009)(105586002)(47776003)(81156014)(21086003)(4326008)(66066001)(86362001)(76176011)(16526019)(2906002)(7696005)(52116002)(69596002)(386003)(97736004)(16586007)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2666; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2666; 23:vd0SDJagAt4uQRq3UcWfx/CWHegjBBp694GC+i7?= ToGKuejhzW21/v1sS6w06Ngb+TxE//6rbOahjNbbCzkozNI5424IZBflpkbHxL377YynG6mV7cnMr7p9Bsq1YIMA5lOPy0YKu17PpZQBwedipwHsqamMZDQP8r0Eg0eQ2+OzoH9/z4rmvir7b4JKUVNp7OHQwDPE9E40CFlUpirCVIFBojGjVwyZ4xl3koLAtgla/CBeRt+AO6jqoabeTEb8lo/bSIMqgNXYCPyxpMA2I2h/pc1p8hZBhQOs+vYXo9oUsaWUiXU+W6bs/UvnsZ2KNZ+nrOlH/eb3fcSvPdu+CB62QoOnIQEZ13aZlbSKZ7IJeBe3jQNZshz+/ZbmMfi/ka7/MFQk426oxxUCb+qLf5foAkNCF4Iru1Rqtx8B6hx3wrSJYY/NBUWaIZcnVRssctk6sPMPIRVHa6d423kbbTIxD3ZG89xX5rtp/8UQsh0wEIKgzOL7gH0BqeNxYWfMTGS1RpLxo2sbtScLDV2WO3BCF9KAcAHKze+DV8G+onbqkCJIqBKUaWb6kwoELGT1lwGwj8PqIBjNNxiAFwKgO+ToCrek7fCg83EsBfbEt3znFUad20EPPKZqKF2m/ueSGEU1jOL4WSWhVXme1lbLsfHXuzbmoJgwgDj0JIfBTgh4+eREYlomHGbH16ID4ZuvprNkaQNTgllqWjxMVAcQIyE73Po262xkEeW0YxtPjClkP3KlLPdbymq298OimlQycxa2VTJWsYEs1vs038Fp8f+93UNtZL6NRUwu8t8kOk+tzuNN/fD6OV9PJxi9UKfbz0J80+kSAnFzeT4dzguvzLEUKJsAN6W0SjETYYNSM3l3YX7Tlcp5cSu/XyBPacoKXXBEUJ0U3WnzZ4ZjyRjF0NumQvW4VzlL0UOWw8PUMsdBZ6D59q4CU8bFw8KMzoM+L28SfDKAeSjQNah/N5msZZQz90rHfETY2AFGsPKpP3+y3bnYDngFoC8dzSxaM1F8Cp7wbM4RGBXh1vlPLCVOTFHyDRTQxgL98mv67q90Oq8IUG1gsypfac2LK1z3e+5GeEonEVQZuzX/O1Ig+MzG3Q+ERgtQCiGCfm8SdPmLihDdwnv9uccVUJgU/D0k3PuID1oZEThaeh2xv6eTQK67jD0JbitmOWHjEdwUL+4V6foc= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2666; 6:iX8tZlJPTvVl5P/bUR43MjED4SY3bmzSskMMVdvzDeV9UCtwyY6ZRIFiXvy5ZIGcHXpI/gw6belJddOnBWv1VXHNZEGrHlFhFoyHSCaDhvT3o3W83TUpI3u2bBO5/hZ3jsaGFmrRTDUu3/cEI8QHIjilK8RYc68+gbTN2KK7AePpK8jDte5I9UdJ/q3rCQDvOGwLjFEfeyplj3vfSKbGClc8dpFR6EsreDH+NhBsBj0dN2W4BM/SYpnlVtgcocMx1lAZJpTzfG9CZE6YaOkSnBm2NRk6/3khdZyjuZOHmUD+jOxtKAoZehAxzMaKjz9ZFnN2bQux9uU+hETcGii4eeZ9Bx+PwJzF+FwMWhckFHQ=; 5:qk707AnAhywKSa5vA/HjHCCwH3W/q90FLmWV/mMdD1j04/1gka93HNefRx1vMUudtgT33th5/0UQUmGahONXIoTwhl8s0TvccFBGC3DmJdkjI2oaykxF9l/aorDWGzGhDMvDPGY8rybtqhy1+xMgC9nbi9Thp/DIJikgrJ8ed4U=; 24:WXDGJkoQWB+5MSJ5/S+oBMsAPpDb/gkVQntnbVdN7UPq7LDx544ZOD453ElDpSsQnGhCnhxzxmk85Xb2X0TNaeuT3NrXgEWENiBf9row4Ag=; 7:h1qTlsGiUmNwb9kjSMcX7LmxmrbEWvB5ZBiwebVtuzOObbZQKLHwyus9ApVZZ2k7PVyPFHhd64YG246tc539QJpwtVthkUUK/Mo4aUU4Fcp8hr0zmG3m4AWO3wB/00fo+avQ3wzAQmeclyPO1Fa9koW73xQKCl8hJQC1gj0CJQjIsEhCrdSoXJ1osgZdlFyo+Ex7b963u4ZBH9d/TW+OVMQ1waC0YaFfwanKi2RNI16NW+UfOw+I0/vjM3AqPqb7 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2018 14:10:16.4597 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52bd3bb8-e18b-4dae-c99e-08d56ca22f01 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2666 Subject: [dpdk-dev] [PATCH v2 1/3] app/testpmd: fix port index in RSS fwd config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Matan Azrad
Feb. 5, 2018, 2:09 p.m. UTC
When multi-queue ports are configured by the user, the testpmd streams
are created by rss_fwd_config_setup() function.
This function may configure to the streams either invalid Rx ports or
invalid Tx ports.
An invalid Tx port is configured when the number of ports is odd.
In this case, the last Tx port will be always invalid.
An invalid Rx port is configured when NUMA support is configured by the
user and the number of forward ports is much smaller than the number of
all ports. In this case, also the Tx port is invalid.
Change calculations to get valid ports.
Fixes: af75078 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
app/test-pmd/config.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 7f2afa2..3053b56 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1989,7 +1989,8 @@ struct igb_ring_desc_16_bytes { * if we are in loopback, simply send stuff out through the * ingress port */ - if (port_topology == PORT_TOPOLOGY_LOOP) + if (port_topology == PORT_TOPOLOGY_LOOP || + txp >= cur_fwd_config.nb_fwd_ports) txp = rxp; fs->rx_port = fwd_ports_ids[rxp]; @@ -2006,11 +2007,7 @@ struct igb_ring_desc_16_bytes { * Restart from RX queue 0 on next RX port */ rxq = 0; - if (numa_support && (nb_fwd_ports <= (nb_ports >> 1))) - rxp = (portid_t) - (rxp + ((nb_ports >> 1) / nb_fwd_ports)); - else - rxp = (portid_t) (rxp + 1); + rxp++; } }