[dpdk-dev,v2] doc: announce ABI change for RSS configuration structure

Message ID 20180206073848.55060-1-xuemingl@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xueming Li Feb. 6, 2018, 7:38 a.m. UTC
  Update deprecation notice for the new rss_level field of
rte_eth_rss_conf.

Link: http://www.dpdk.org/dev/patchwork/patch/31891

Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Shahaf Shuler Feb. 13, 2018, 6:52 a.m. UTC | #1
Tuesday, February 6, 2018 9:39 AM, Xueming Li:
> Subject: [PATCH v2] doc: announce ABI change for RSS configuration
> structure
> 
> Update deprecation notice for the new rss_level field of rte_eth_rss_conf.
> 
> Link: http://www.dpdk.org/dev/patchwork/patch/31891
> 
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index d59ad5988..4bfce3bd7 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -59,3 +59,7 @@ Deprecation Notices
>    be added between the producer and consumer structures. The size of the
>    structure and the offset of the fields will remain the same on
>    platforms with 64B cache line, but will change on other platforms.
> +
> +* ethdev: A new rss level field planned in 18.05.
> +  The new API add rss_level field to ``rte_eth_rss_conf`` to enable a
> +choice
> +  of RSS hash calculation on outer or inner header of tunneled packet.

Acked-By: Shahaf Shuler <shahafs@mellanox.com>

> --
> 2.13.3
  
Ferruh Yigit Feb. 13, 2018, 11:27 a.m. UTC | #2
On 2/13/2018 6:52 AM, Shahaf Shuler wrote:
> Tuesday, February 6, 2018 9:39 AM, Xueming Li:
>> Subject: [PATCH v2] doc: announce ABI change for RSS configuration
>> structure
>>
>> Update deprecation notice for the new rss_level field of rte_eth_rss_conf.
>>
>> Link: http://www.dpdk.org/dev/patchwork/patch/31891
>>
>> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
>> ---
>>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>> index d59ad5988..4bfce3bd7 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -59,3 +59,7 @@ Deprecation Notices
>>    be added between the producer and consumer structures. The size of the
>>    structure and the offset of the fields will remain the same on
>>    platforms with 64B cache line, but will change on other platforms.
>> +
>> +* ethdev: A new rss level field planned in 18.05.
>> +  The new API add rss_level field to ``rte_eth_rss_conf`` to enable a
>> +choice
>> +  of RSS hash calculation on outer or inner header of tunneled packet.
> 
> Acked-By: Shahaf Shuler <shahafs@mellanox.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
  
Jerin Jacob Feb. 13, 2018, 12:10 p.m. UTC | #3
-----Original Message-----
> Date: Tue, 13 Feb 2018 11:27:34 +0000
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: Shahaf Shuler <shahafs@mellanox.com>, "Xueming(Steven) Li"
>  <xuemingl@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>, Neil
>  Horman <nhorman@tuxdriver.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for RSS
>  configuration structure
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>  Thunderbird/52.6.0
> 
> On 2/13/2018 6:52 AM, Shahaf Shuler wrote:
> > Tuesday, February 6, 2018 9:39 AM, Xueming Li:
> >> Subject: [PATCH v2] doc: announce ABI change for RSS configuration
> >> structure
> >>
> >> Update deprecation notice for the new rss_level field of rte_eth_rss_conf.
> >>
> >> Link: http://www.dpdk.org/dev/patchwork/patch/31891
> >>
> >> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> >> ---
> >>  doc/guides/rel_notes/deprecation.rst | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/doc/guides/rel_notes/deprecation.rst
> >> b/doc/guides/rel_notes/deprecation.rst
> >> index d59ad5988..4bfce3bd7 100644
> >> --- a/doc/guides/rel_notes/deprecation.rst
> >> +++ b/doc/guides/rel_notes/deprecation.rst
> >> @@ -59,3 +59,7 @@ Deprecation Notices
> >>    be added between the producer and consumer structures. The size of the
> >>    structure and the offset of the fields will remain the same on
> >>    platforms with 64B cache line, but will change on other platforms.
> >> +
> >> +* ethdev: A new rss level field planned in 18.05.
> >> +  The new API add rss_level field to ``rte_eth_rss_conf`` to enable a
> >> +choice
> >> +  of RSS hash calculation on outer or inner header of tunneled packet.
> > 
> > Acked-By: Shahaf Shuler <shahafs@mellanox.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
  
Thomas Monjalon Feb. 14, 2018, 4:28 p.m. UTC | #4
> > >> Update deprecation notice for the new rss_level field of rte_eth_rss_conf.
> > >>
> > >> Link: http://www.dpdk.org/dev/patchwork/patch/31891
> > >>
> > >> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> > >> ---
> > >> +* ethdev: A new rss level field planned in 18.05.
> > >> +  The new API add rss_level field to ``rte_eth_rss_conf`` to enable a
> > >> +choice
> > >> +  of RSS hash calculation on outer or inner header of tunneled packet.
> > > 
> > > Acked-By: Shahaf Shuler <shahafs@mellanox.com>
> > 
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d59ad5988..4bfce3bd7 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -59,3 +59,7 @@  Deprecation Notices
   be added between the producer and consumer structures. The size of the
   structure and the offset of the fields will remain the same on
   platforms with 64B cache line, but will change on other platforms.
+
+* ethdev: A new rss level field planned in 18.05.
+  The new API add rss_level field to ``rte_eth_rss_conf`` to enable a choice
+  of RSS hash calculation on outer or inner header of tunneled packet.