Message ID | 20180207142336.95200-1-shahafs@mellanox.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6DF2E1B74C; Wed, 7 Feb 2018 15:23:55 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0041.outbound.protection.outlook.com [104.47.1.41]) by dpdk.org (Postfix) with ESMTP id E223E1B740 for <dev@dpdk.org>; Wed, 7 Feb 2018 15:23:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3JWdYrp6VbbEFKdM2kAdLyV7nIb+D/5XBHu+YUTowNo=; b=EuQQqLte9XaH2whmoFZZBs51FbkZYJla5iMTuYRrvPMTcZ1cpdOOUeQH+W2uxt0i1YXQ7HAp5iTe8HdQP8DtXHaQFVoJU0msGgD7v26HwVzfrAmpIGjj77aWx1kYmcdluRi3ZvH65GFaPrU6eVNOJXpM2OUE6UmMc6MVzwrlghk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by HE1PR05MB3145.eurprd05.prod.outlook.com (2603:10a6:7:36::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Wed, 7 Feb 2018 14:23:52 +0000 From: Shahaf Shuler <shahafs@mellanox.com> To: thomas@monjalon.net, nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org Date: Wed, 7 Feb 2018 16:23:36 +0200 Message-Id: <20180207142336.95200-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: AM5PR0102CA0033.eurprd01.prod.exchangelabs.com (2603:10a6:206::46) To HE1PR05MB3145.eurprd05.prod.outlook.com (2603:10a6:7:36::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 021a1635-4d36-4054-5de7-08d56e3669f6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR05MB3145; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3145; 3:bgkurnizNO3ktT7cFAZvbVpmpcCuUNyj4RRS6dY2tKGSGGdrsGASSv6uSdwsCJrh2tw0HejCICI3b0DcaPfETF2pUCiE0aaH3Va1/q9Jq4n0Lf3B5vlHCTViG7rEwqdH3Ul55Ceeer/uWJ8I+PIuEInf0C6CzsnQe6V4drzQg0fgfO8XVDf85vKbi0zQ1Z4d2QYvjBJf2JK4FeIEBuBJyGpcdDQS7bn8kXnxQ9wa4mZ4s5q5nShSEkg0VqBhywu0; 25:yzbQ0s3ke71tdzG1qVFb9t5vLZGdQ0NN8HkNs0aM6xyUFHhWS7XHduJhQnvhP+euUMHoTzJtW76R7kXp16vR4wSjgxOZBM4EwLvaTifPRAoW3cpCkYO/sqO4xyl/g3W/nBwJfPdZl1wdXh4MkeiEA0CbMf2SjCtNJztmD9nudBZtLSC5MFBtFmExXYzp2jtjk995rZbCs824bXdf++coRK7x2qpYlw/3CkINdnnXnpQLpo1gg2iwo3jxIx+AxBEWHwKZXDitXBYl8NWDLswdAfaketk2T5+N6xYZuP5lFxEh9VAMh13GedEZf73f0tZYAiltv5gF1WQ5eMUFhGLz7g==; 31:cPrWGHJoUXINe2n//GQL4jlMRPEHQtqSIB6j1aFS4V4ngXT6YHnnqycfKSvQ5q73FfUynjXu6fRV6pKC3gxDWYrYzfi3YWdES1ZNB6TWsRJxQmFSe+wWfxZo70VZwXPEUYE3Xz+B+mjFCzjlt6ZdVQ9GVCA+eIxcCtVayDEeuCSCRll2r5zwHSVFpbWxwxcueIqlpPCjBxOahqobwYhP3IoQ2mmwdwyY78Un/pn98HA= X-MS-TrafficTypeDiagnostic: HE1PR05MB3145: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3145; 20:4MDiDVDpXR692aWrai5fMenLqbN7uzaTXoKmR2poOa3PIvE1e7D6hQbTIOkMx2rooH7yxxmVVW3685u8aYGr7bPJ7dYBaJuN/56qnnELnWYntLoA/FVK4o6GbM2oxbjuS2Tm3apNDdZ2ZnayHNXl8OdZyKpmOHPUld0wL81QMlZqwqf2Ng+EvjKnxtEqdezHnRB5xbAr1r/De453L/zyl7w9uQpPGpb+tFY0dlUJYV59fHx7zty6KPUuM1sQAKzHjZH7aI37v5SPCzZdWYfuEIUhLWg+jkRrvXP9BuraBOAoWVE2/mm6R/SwPiy3uM6YBpMhc7eel4t32mEWm77IwbPIfboxPvmK5tJHCGTg4Rh7xras+U4GuqWwdtdmU4QUjAykGFmTQXmXWik6u/JaEPX9vsK/LsTN9ucpxnBz2HE+kyZPx28HtRufF4WhVIdcfFjaxkzflS9vAtAA3GbIzGMQ6IFStKJeXSCPLqahR5xr5vwhy9zBZ0PxgUBGgNyw; 4:Hsc3IbyBK08arkGVMCZdWys3NjvpRClILttn3u10O4x4HHSqDegRNCyiLDqnveLZ5k2PClO/5zeYTh7uVccrd35wbS5RlGS+ZNGBhhcKNdlFGEauQriL6/Ho1UOfQSG02Ms3ucS0+U5Q+zP9BwqsTQVKKNDrwc3lbVp8zKop7w7AchXlmvWI//WJOau0ukjS30zQ8NM3i70BtQQpWYgcP/IL+YUQsydLMGnQeXrB8H8ogQjMohNoN7Pmt9o5RKGvlpoTdietLQIewyy+0/un1w== X-Microsoft-Antispam-PRVS: <HE1PR05MB3145B08090065F251EBBA54FC3FC0@HE1PR05MB3145.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231101)(2400082)(944501161)(3002001)(6055026)(6041288)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR05MB3145; BCL:0; PCL:0; RULEID:; SRVR:HE1PR05MB3145; X-Forefront-PRVS: 0576145E86 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(39380400002)(396003)(376002)(199004)(189003)(66066001)(69596002)(6666003)(8676002)(478600001)(316002)(4326008)(7696005)(305945005)(47776003)(86362001)(81166006)(26005)(81156014)(53936002)(386003)(2906002)(25786009)(36756003)(6636002)(16586007)(50226002)(8936002)(1076002)(68736007)(55016002)(1857600001)(5660300001)(51416003)(3846002)(21086003)(7736002)(106356001)(16526019)(50466002)(6116002)(97736004)(105586002)(48376002)(186003)(52116002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB3145; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB3145; 23:HTS9NDlVy+yUMNK89RHcDfb3hbrjjQS9yRq0o7H4v?= QzrMtrSjIvy2vopX69jfMzag0HogyQeQD1GuRD9FQdQd6NE3TFYi8VcQCMWfouHE0f3wYrbIcyiJ90ZOcJK5Ws8S/B41a5pPeb5A71VplFKS3WgUIbw/OBT5+wPhHGluFWX3rqQhLJxHKsxX8FnV0kPmH8llGgEiv+yqjAdrGjg4YNf4f+oryaOTPyumXcM+Yn6ebE7vsFMtQedClkknhjifj0PO+tFLpf71hL73+c7MjxZr7bktnk5ff+8nxNrqPghG0GXx+6dWT+I5c3Boti4SUsQWV+Duz4H87NxucOfYW0lDpoNZcfUXMv4K2RpA7yAt2iBd7kzXOrtAgNRXYWNps4jR96hhJRaPkdivCTyJIzHZp6GRk85KoQM9iQDaYpSAMS1B3R9x2FrmFaUnXwwUhrHbHVZ99lh0JDBlb9YfFvwRwWA7k7h/WWVVSgxFCDyv5rXRK2zR5VrPZNJtpbKIRfgpusNl8U85wxakv9s0+xcpCes8Vja9qOx/NcBiKFU+tu5LoeT4085uzT1orDxUZUrGByQYqUPGs9ZFizdP4GcUeWo5i316ar92mEu5hKN/rx9v5j76PsCCi9hWSJq4O1U0Hr9sD/HDMA/j7qCEzbdh5BovMEwB0OKdIoheHtCMLwyJIIYU4qMgLcuHEkBH210sQwoF2d0EEWQWSkpZfYx8VPMsCb46QJlsaiC01waBZ9YULPqa9+t9MfH54DFD3T8BWcyG5FARS6PHmDewITVLtG7RKMFpx1w+AWaCPSI5VScmvuJ7CMOQLUnQgSTygPDC59arnf1PwsPE3rZ0yQlc84A7Ib6UK7xyhi9sxlpntroTs8oCw43snia35iLIaRWzmYEierIvIQvzEnbE5/coYviT39S2SVZGeJxaeF7ZHhspQZTpZ6GAKE+KAvb7pz2gchFs8D3dv6AkwB+DPHSBkn7NCzafADofVNrL70FuSpOOEzfiuUddu0/WxcT+cOx7+CtAXHcrAuhTJx9r8IEJxhPES8KsHclj8bROG4QdEyxUI2xGmcaRVU6zOMC9tY3U1UkxK6OBB1ZocNjSUFvfIHkOvF8SIIbpQWNrt8= X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB3145; 6:w9Jtu5BpKFxsOYM6tGRScNrt24H+D4rKVBRYjTaMfiR4ifVYbvyVGjX8JHrMqmxWNurMaAoLrR/x64DV0QIZ4RMULfB1uNQ6PuBblp7dsQ9a+EZocJwhgaakdjO1SD/O8Obu5xHTAMC1nrqOcYIXpY+kfN4fnP2Tc8WEu+F6SRaUTthSuvsQyNt9nEpRDZjaqLMU/dlQJEPoKsWgokNCmYvflvBNUgWzD+qC1Km565k6BHiFtSlr/gqvEj2jsXfYe5LzCNr30c2Kl92Bjj6TMjHlkYvgS1FNDFwH52Y+rfhdbSmwSG9RiwftnRNJXbUQqbs8xMNmFiYHn2V9rM0noEUJaq5U8BMQVyGXr24lnfI=; 5:1uj3Jwn/G2ooDJbZcxjLQc6X9rHQNleygHssbmBPHC0tlZN0eLkSHppUhxvMoMMbrCVLXDcRyYAsRbe7Kz+gRjFBggV1TbdOgphsw/9CCk7EjIxHJDWWGu/QoW1lrcch0ZRt13Qnzn4o6cs8QlL+KcN1/hch8YTbqN5GuqoOI4s=; 24:GC5lDm+f2CbegzTzn1vLl6XTkW0Ru0LU65cjTBAbdC3FLZSvnuQbustpYsrnasqvmbJyg350fJ4XE3u5H5E8TwFz9o7rheL+aI6HBzWTEzw=; 7:CU5EaEAX2Bg6fL9R3xPbN1faRFz1G/Zzx/WX3c97OKDfA6lUFO7hlGQUMvBFSkRYamOgeXvqhxHRi+EmzGhMm6YgSr4c4+Bpef4AJKrmMl6YpxLUOmZpaPMbGT9aVp1/HSIdp9zkxJcmeSe4pN5FjQGLAW+90WmUVRlnpiT0cO4F9DPCUdINg6iGose/6kvkIoMLl8kJArZ6xsxaGecD0Qa/XC6dvuIQQ+PMeT9ojcq+BgCR29JgtrYIDrLDyCyn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2018 14:23:52.1117 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 021a1635-4d36-4054-5de7-08d56e3669f6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB3145 Subject: [dpdk-dev] [PATCH] net/mlx5: revert support in IPv4 time-to-live filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Shahaf Shuler
Feb. 7, 2018, 2:23 p.m. UTC
Nor upstream kernel nor MLNX_OFED support such filter.
Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter")
Cc: nelio.laranjeiro@6wind.com
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
doc/guides/rel_notes/release_18_02.rst | 1 -
drivers/net/mlx5/mlx5_flow.c | 1 -
2 files changed, 2 deletions(-)
Comments
On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote: > Nor upstream kernel nor MLNX_OFED support such filter. > > Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter") > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com> > --- > doc/guides/rel_notes/release_18_02.rst | 1 - > drivers/net/mlx5/mlx5_flow.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst > index 32067969f..0d4630335 100644 > --- a/doc/guides/rel_notes/release_18_02.rst > +++ b/doc/guides/rel_notes/release_18_02.rst > @@ -94,7 +94,6 @@ New Features > * Improved multi-segment packet performance. > * Changed driver name to use the PCI address to be compatible with OVS-DPDK APIs. > * Extended statistics for physical port packet/byte counters. > - * Supported IPv4 time-to-live filter. > * Converted to the new offloads API. > * Supported device removal check operation. > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 822705060..f88ece123 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -313,7 +313,6 @@ static const struct mlx5_flow_items mlx5_flow_items[] = { > .dst_addr = -1, > .type_of_service = -1, > .next_proto_id = -1, > - .time_to_live = -1, > }, > }, > .default_mask = &rte_flow_item_ipv4_mask, > -- > 2.12.0 Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote: > On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote: >> Nor upstream kernel nor MLNX_OFED support such filter. >> >> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter") >> Cc: nelio.laranjeiro@6wind.com >> >> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com> > > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> Applied to dpdk-next-net/master, thanks.
08/02/2018 15:35, Ferruh Yigit: > On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote: > > On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote: > >> Nor upstream kernel nor MLNX_OFED support such filter. > >> > >> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter") > >> Cc: nelio.laranjeiro@6wind.com > >> > >> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com> > > > > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > Applied to dpdk-next-net/master, thanks. Have you applied the v1 or v2?
On 2/8/2018 2:38 PM, Thomas Monjalon wrote: > 08/02/2018 15:35, Ferruh Yigit: >> On 2/8/2018 12:26 PM, Nélio Laranjeiro wrote: >>> On Wed, Feb 07, 2018 at 04:23:36PM +0200, Shahaf Shuler wrote: >>>> Nor upstream kernel nor MLNX_OFED support such filter. >>>> >>>> Reverts commit 0fb2c9842b20 ("net/mlx5: support IPv4 time-to-live filter") >>>> Cc: nelio.laranjeiro@6wind.com >>>> >>>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com> >>> >>> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> >> >> Applied to dpdk-next-net/master, thanks. > > Have you applied the v1 or v2? v2 applied, but I reply to v1 by mistake.
diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index 32067969f..0d4630335 100644 --- a/doc/guides/rel_notes/release_18_02.rst +++ b/doc/guides/rel_notes/release_18_02.rst @@ -94,7 +94,6 @@ New Features * Improved multi-segment packet performance. * Changed driver name to use the PCI address to be compatible with OVS-DPDK APIs. * Extended statistics for physical port packet/byte counters. - * Supported IPv4 time-to-live filter. * Converted to the new offloads API. * Supported device removal check operation. diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 822705060..f88ece123 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -313,7 +313,6 @@ static const struct mlx5_flow_items mlx5_flow_items[] = { .dst_addr = -1, .type_of_service = -1, .next_proto_id = -1, - .time_to_live = -1, }, }, .default_mask = &rte_flow_item_ipv4_mask,