diff mbox

[dpdk-dev] net/mlx4: update Rx offload capabilities

Message ID 1518088467-21099-1-git-send-email-motih@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Moti Haimovsky Feb. 8, 2018, 11:14 a.m. UTC 
  This patch updates mlx4 Rx offload capabilities to also indicate that
Rx CRC stripping is (always) supported.
Since the device does not support disabeling CRC stripping the PMD
silently ignores such requests.

Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
 drivers/net/mlx4/mlx4_rxq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Adrien Mazarguil Feb. 8, 2018, 12:43 p.m. UTC | #1 
On Thu, Feb 08, 2018 at 01:14:27PM +0200, Moti Haimovsky wrote:
> This patch updates mlx4 Rx offload capabilities to also indicate that
> Rx CRC stripping is (always) supported.
> Since the device does not support disabeling CRC stripping the PMD

disabeling => disabling

> silently ignores such requests.
> 
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>

Except for the typo,

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Ferruh Yigit Feb. 8, 2018, 2:23 p.m. UTC | #2 
On 2/8/2018 12:43 PM, Adrien Mazarguil wrote:
> On Thu, Feb 08, 2018 at 01:14:27PM +0200, Moti Haimovsky wrote:
>> This patch updates mlx4 Rx offload capabilities to also indicate that
>> Rx CRC stripping is (always) supported.
>> Since the device does not support disabeling CRC stripping the PMD
> 
> disabeling => disabling

Fixed while applying.

>> silently ignores such requests.
>>
>> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> 
> Except for the typo,
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c
index 39268ea..7a036ed 100644
--- a/drivers/net/mlx4/mlx4_rxq.c
+++ b/drivers/net/mlx4/mlx4_rxq.c
@@ -649,7 +649,8 @@  struct mlx4_rss *
 uint64_t
 mlx4_get_rx_queue_offloads(struct priv *priv)
 {
-	uint64_t offloads = DEV_RX_OFFLOAD_SCATTER;
+	uint64_t offloads = DEV_RX_OFFLOAD_SCATTER |
+			    DEV_RX_OFFLOAD_CRC_STRIP;
 
 	if (priv->hw_csum)
 		offloads |= DEV_RX_OFFLOAD_CHECKSUM;