[dpdk-dev] doc: fix ethdev API port_id parameter size

Message ID 20180209095358.69136-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit Feb. 9, 2018, 9:53 a.m. UTC
  Fix rte_eth_dev_get_sec_ctx() parameter port_id storage size, form
uint8_t to uint16_t

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Boris Pismenny <borisp@mellanox.com>
Cc: Aviad Yehezkel <aviadye@mellanox.com>
Cc: Radu Nicolau <radu.nicolau@intel.com>
Cc: Declan Doherty <declan.doherty@intel.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Radu Nicolau Feb. 9, 2018, 1:18 p.m. UTC | #1
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, February 9, 2018 9:54 AM
> To: Neil Horman <nhorman@tuxdriver.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; Boris Pismenny <borisp@mellanox.com>; Aviad
> Yehezkel <aviadye@mellanox.com>; Nicolau, Radu
> <radu.nicolau@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: [PATCH] doc: fix ethdev API port_id parameter size
> 
> Fix rte_eth_dev_get_sec_ctx() parameter port_id storage size, form uint8_t
> to uint16_t
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
  
Hemant Agrawal Feb. 9, 2018, 3:01 p.m. UTC | #2
> >
> > Fix rte_eth_dev_get_sec_ctx() parameter port_id storage size, form
> > uint8_t to uint16_t
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
  
Jerin Jacob Feb. 10, 2018, 12:01 p.m. UTC | #3
-----Original Message-----
> Date: Fri, 9 Feb 2018 15:01:28 +0000
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: "Nicolau, Radu" <radu.nicolau@intel.com>, "Yigit, Ferruh"
>  <ferruh.yigit@intel.com>, Neil Horman <nhorman@tuxdriver.com>, "Mcnamara,
>  John" <john.mcnamara@intel.com>, "Kovacevic, Marko"
>  <marko.kovacevic@intel.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
>  Boris Pismenny <borisp@mellanox.com>, Aviad Yehezkel
>  <aviadye@mellanox.com>, "Doherty, Declan" <declan.doherty@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: fix ethdev API port_id parameter size
> 
> > >
> > > Fix rte_eth_dev_get_sec_ctx() parameter port_id storage size, form
> > > uint8_t to uint16_t
> > >
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > ---
> > Acked-by: Radu Nicolau <radu.nicolau@intel.com>
> 
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
  
Thomas Monjalon Feb. 14, 2018, 5:25 p.m. UTC | #4
> > > > Fix rte_eth_dev_get_sec_ctx() parameter port_id storage size, form
> > > > uint8_t to uint16_t
> > > >
> > > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > > ---
> > > Acked-by: Radu Nicolau <radu.nicolau@intel.com>
> > 
> > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d59ad5988..bbd9456a7 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -45,6 +45,10 @@  Deprecation Notices
   Target release for removal of the legacy API will be defined once most
   PMDs have switched to rte_flow.
 
+* ethdev: rte_eth_dev_get_sec_ctx() fix port id storage
+  rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be
+  uint16_t.
+
 * i40e: The default flexible payload configuration which extracts the first 16
   bytes of the payload for RSS will be deprecated starting from 18.02. If
   required the previous behavior can be configured using existing flow