diff mbox

[dpdk-dev,2/4] net/virtio-user: add data members to support server mode

Message ID 20180214145330.4679-3-zhiyong.yang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Maxime Coquelin
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yang, Zhiyong Feb. 14, 2018, 2:53 p.m. UTC 
  Add data members so as to support server mode.

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 drivers/net/virtio/virtio_user/virtio_user_dev.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Maxime Coquelin Feb. 27, 2018, 5:53 p.m. UTC | #1 
On 02/14/2018 03:53 PM, Zhiyong Yang wrote:
> Add data members so as to support server mode.
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
>   drivers/net/virtio/virtio_user/virtio_user_dev.h | 8 ++++++++
>   1 file changed, 8 insertions(+)


This patch can be squashed in patch 3.

> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> index 64467b4f9..e640a3438 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> @@ -6,13 +6,21 @@
>   #define _VIRTIO_USER_DEV_H
>   
>   #include <limits.h>
> +#include <stdbool.h>
>   #include "../virtio_pci.h"
>   #include "../virtio_ring.h"
>   #include "vhost.h"
> +#include "fd_man.h"
>   
>   struct virtio_user_dev {
>   	/* for vhost_user backend */
>   	int		vhostfd;
> +	int		listenfd;   /* listening fd  */
> +	bool		connected;  /* connection status */
> +
> +	/* support for server/clinet mode */
> +	bool		is_server;
> +	struct fdset	fdset;
>   
>   	/* for vhost_kernel backend */
>   	char		*ifname;
>
Yang, Zhiyong Feb. 28, 2018, 1:38 a.m. UTC | #2 
> -----Original Message-----

> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]

> Sent: Wednesday, February 28, 2018 1:53 AM

> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org;

> yliu@fridaylinux.org; Tan, Jianfeng <jianfeng.tan@intel.com>; Bie, Tiwei

> <tiwei.bie@intel.com>; Wang, Zhihong <zhihong.wang@intel.com>

> Cc: Wang, Dong1 <dong1.wang@intel.com>

> Subject: Re: [PATCH 2/4] net/virtio-user: add data members to support

> server mode

> 

> 

> 

> On 02/14/2018 03:53 PM, Zhiyong Yang wrote:

> > Add data members so as to support server mode.

> >

> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>

> > ---

> >   drivers/net/virtio/virtio_user/virtio_user_dev.h | 8 ++++++++

> >   1 file changed, 8 insertions(+)

> 

> 

> This patch can be squashed in patch 3.


Ok. 

Thanks
Zhiyong
diff mbox

Patch

diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h
index 64467b4f9..e640a3438 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
@@ -6,13 +6,21 @@ 
 #define _VIRTIO_USER_DEV_H
 
 #include <limits.h>
+#include <stdbool.h>
 #include "../virtio_pci.h"
 #include "../virtio_ring.h"
 #include "vhost.h"
+#include "fd_man.h"
 
 struct virtio_user_dev {
 	/* for vhost_user backend */
 	int		vhostfd;
+	int		listenfd;   /* listening fd  */
+	bool		connected;  /* connection status */
+
+	/* support for server/clinet mode */
+	bool		is_server;
+	struct fdset	fdset;
 
 	/* for vhost_kernel backend */
 	char		*ifname;