diff mbox

[dpdk-dev] event/sw: code refractor for counter set

Message ID 1519765822-133853-1-git-send-email-vipin.varghese@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Varghese, Vipin Feb. 27, 2018, 9:10 p.m. UTC 
  Counter variable 'out_pkts' had been set to 0, then updated. Current
code change elimates double assignment to direct assignment.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
 drivers/event/sw/sw_evdev_scheduler.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Kevin Laatz March 14, 2018, 1:16 p.m. UTC | #1 
On 27/02/2018 21:10, Vipin Varghese wrote:
> Counter variable 'out_pkts' had been set to 0, then updated. Current
> code change elimates double assignment to direct assignment.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
>
<...>

Acked-by: Kevin Laatz <kevin.laatz@intel.com>
Jerin Jacob March 20, 2018, 6:10 a.m. UTC | #2 
-----Original Message-----
> Date: Wed, 14 Mar 2018 13:16:11 +0000
> From: "Laatz, Kevin" <kevin.laatz@intel.com>
> To: Vipin Varghese <vipin.varghese@intel.com>
> CC: dev@dpdk.org, harry.van.haaren@intel.com
> Subject: Re: [dpdk-dev] [PATCH] event/sw: code refractor for counter set
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>  Thunderbird/52.6.0
> 
> 
> 
> On 27/02/2018 21:10, Vipin Varghese wrote:
> > Counter variable 'out_pkts' had been set to 0, then updated. Current
> > code change elimates double assignment to direct assignment.
> > 
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > 
> <...>
> 
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>

Applied to dpdk-next-eventdev/master. Thanks.
diff mbox

Patch

diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c
index 9143b93..e3a41e0 100644
--- a/drivers/event/sw/sw_evdev_scheduler.c
+++ b/drivers/event/sw/sw_evdev_scheduler.c
@@ -532,8 +532,7 @@  sw_event_schedule(struct rte_eventdev *dev)
 		} while (in_pkts > 4 &&
 				(int)in_pkts_this_iteration < sched_quanta);
 
-		out_pkts = 0;
-		out_pkts += sw_schedule_qid_to_cq(sw);
+		out_pkts = sw_schedule_qid_to_cq(sw);
 		out_pkts_total += out_pkts;
 		in_pkts_total += in_pkts_this_iteration;