diff mbox

[dpdk-dev,6/7] bus/fslmc: enabling dpaa2 compilation for other platforms

Message ID 1519752352-15442-7-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hemant Agrawal Feb. 27, 2018, 5:25 p.m. UTC 
  Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/bus/fslmc/qbman/qbman_sys_decl.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Bruce Richardson Feb. 28, 2018, 2:45 p.m. UTC | #1 
On Tue, Feb 27, 2018 at 10:55:51PM +0530, Hemant Agrawal wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  drivers/bus/fslmc/qbman/qbman_sys_decl.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 

With these patches should config/common_base be changed to enable all
these drivers globally for compilation testing?

/Bruce
Hemant Agrawal Feb. 28, 2018, 4:02 p.m. UTC | #2 
On 2/28/2018 8:15 PM, Bruce Richardson wrote:
> On Tue, Feb 27, 2018 at 10:55:51PM +0530, Hemant Agrawal wrote:
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>   drivers/bus/fslmc/qbman/qbman_sys_decl.h | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
> 
> With these patches should config/common_base be changed to enable all
> these drivers globally for compilation testing?
> 

currently we are planning to enable them in config/common_linuxapp only.

We still have issue with BSD compilations. some of the compat files are 
linux dependent.

> /Bruce
> 
>
Bruce Richardson Feb. 28, 2018, 4:33 p.m. UTC | #3 
> -----Original Message-----

> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]

> Sent: Wednesday, February 28, 2018 4:02 PM

> To: Richardson, Bruce <bruce.richardson@intel.com>

> Cc: dev@dpdk.org; thomas@monjalon.net; shreyansh.jain@nxp.com

> Subject: Re: [PATCH 6/7] bus/fslmc: enabling dpaa2 compilation for other

> platforms

> 

> On 2/28/2018 8:15 PM, Bruce Richardson wrote:

> > On Tue, Feb 27, 2018 at 10:55:51PM +0530, Hemant Agrawal wrote:

> >> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> >> ---

> >>   drivers/bus/fslmc/qbman/qbman_sys_decl.h | 14 ++++++++++++++

> >>   1 file changed, 14 insertions(+)

> >>

> >

> > With these patches should config/common_base be changed to enable all

> > these drivers globally for compilation testing?

> >

> 

> currently we are planning to enable them in config/common_linuxapp only.

> 

> We still have issue with BSD compilations. some of the compat files are

> linux dependent.

> 

Yes, of course. I should have spotted that from the checks in the meson files. :-)

/Bruce
diff mbox

Patch

diff --git a/drivers/bus/fslmc/qbman/qbman_sys_decl.h b/drivers/bus/fslmc/qbman/qbman_sys_decl.h
index 5640b04..fa6977f 100644
--- a/drivers/bus/fslmc/qbman/qbman_sys_decl.h
+++ b/drivers/bus/fslmc/qbman/qbman_sys_decl.h
@@ -36,4 +36,18 @@  static inline void prefetch_for_store(void *p)
 #define dccivac(p)	RTE_SET_USED(p)
 #define prefetch_for_load(p) { asm volatile ("pld [%0]" : : "r" (p)); }
 #define prefetch_for_store(p) { asm volatile ("pld [%0]" : : "r" (p)); }
+
+#else
+#define dcbz(p)	RTE_SET_USED(p)
+#define lwsync()
+#define dcbf(p)	RTE_SET_USED(p)
+#define dccivac(p)	RTE_SET_USED(p)
+static inline void prefetch_for_load(void *p)
+{
+	RTE_SET_USED(p);
+}
+static inline void prefetch_for_store(void *p)
+{
+	RTE_SET_USED(p);
+}
 #endif