[dpdk-dev,v2,39/41] net/qede: use contiguous allocation for DMA memory

  Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---

Notes:
    Doing "grep -R rte_memzone_reserve drivers/net/qede" returns the following:
    
    drivers/net/qede/qede_fdir.c:     mz = rte_memzone_reserve_aligned(mz_name, QEDE_MAX_FDIR_PKT_LEN,
    drivers/net/qede/base/bcm_osal.c: mz = rte_memzone_reserve_aligned_contig(mz_name, size,
    drivers/net/qede/base/bcm_osal.c: mz = rte_memzone_reserve_aligned_contig(mz_name, size, socket_id, 0,
    
    I took a brief look at memzone in qede_fdir and it didn't look like memzone
    was used for DMA, so i left it alone. Corrections welcome.

 drivers/net/qede/base/bcm_osal.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
  

-----Original Message-----
From: Anatoly Burakov <anatoly.burakov@intel.com>

Date: Wednesday, March 7, 2018 at 8:57 AM
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "Mody, Rasesh" <Rasesh.Mody@cavium.com>, Harish Patil
<Harish.Patil@cavium.com>, "Shaikh, Shahed" <Shahed.Shaikh@cavium.com>,
"keith.wiles@intel.com" <keith.wiles@intel.com>, "jianfeng.tan@intel.com"
<jianfeng.tan@intel.com>, "andras.kovacs@ericsson.com"
<andras.kovacs@ericsson.com>, "laszlo.vadkeri@ericsson.com"
<laszlo.vadkeri@ericsson.com>, "benjamin.walker@intel.com"
<benjamin.walker@intel.com>, "bruce.richardson@intel.com"
<bruce.richardson@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"kuralamudhan.ramakrishnan@intel.com"
<kuralamudhan.ramakrishnan@intel.com>, "louise.m.daly@intel.com"
<louise.m.daly@intel.com>, "nelio.laranjeiro@6wind.com"
<nelio.laranjeiro@6wind.com>, "yskoh@mellanox.com" <yskoh@mellanox.com>,
"pepperjo@japf.ch" <pepperjo@japf.ch>, "Jacob,  Jerin"
<Jerin.JacobKollanukkaran@cavium.com>, "hemant.agrawal@nxp.com"
<hemant.agrawal@nxp.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: [PATCH v2 39/41] net/qede: use contiguous allocation for DMA
memory

>Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

>---

>

>Notes:

>    Doing "grep -R rte_memzone_reserve drivers/net/qede" returns the

>following:

>    

>    drivers/net/qede/qede_fdir.c:     mz =

>rte_memzone_reserve_aligned(mz_name, QEDE_MAX_FDIR_PKT_LEN,

>    drivers/net/qede/base/bcm_osal.c: mz =

>rte_memzone_reserve_aligned_contig(mz_name, size,

>    drivers/net/qede/base/bcm_osal.c: mz =

>rte_memzone_reserve_aligned_contig(mz_name, size, socket_id, 0,

>    

>    I took a brief look at memzone in qede_fdir and it didn't look like

>memzone

>    was used for DMA, so i left it alone. Corrections welcome.


That’s right.
>

> drivers/net/qede/base/bcm_osal.c | 5 +++--

> 1 file changed, 3 insertions(+), 2 deletions(-)

>

>diff --git a/drivers/net/qede/base/bcm_osal.c

>b/drivers/net/qede/base/bcm_osal.c

>index fe42f32..707d553 100644

>--- a/drivers/net/qede/base/bcm_osal.c

>+++ b/drivers/net/qede/base/bcm_osal.c

>@@ -135,7 +135,7 @@ void *osal_dma_alloc_coherent(struct ecore_dev *p_dev,

> 	if (core_id == (unsigned int)LCORE_ID_ANY)

> 		core_id = 0;

> 	socket_id = rte_lcore_to_socket_id(core_id);

>-	mz = rte_memzone_reserve_aligned(mz_name, size,

>+	mz = rte_memzone_reserve_aligned_contig(mz_name, size,

> 					 socket_id, 0, RTE_CACHE_LINE_SIZE);

> 	if (!mz) {

> 		DP_ERR(p_dev, "Unable to allocate DMA memory "

>@@ -174,7 +174,8 @@ void *osal_dma_alloc_coherent_aligned(struct

>ecore_dev *p_dev,

> 	if (core_id == (unsigned int)LCORE_ID_ANY)

> 		core_id = 0;

> 	socket_id = rte_lcore_to_socket_id(core_id);

>-	mz = rte_memzone_reserve_aligned(mz_name, size, socket_id, 0, align);

>+	mz = rte_memzone_reserve_aligned_contig(mz_name, size, socket_id, 0,

>+			align);

> 	if (!mz) {

> 		DP_ERR(p_dev, "Unable to allocate DMA memory "

> 		       "of size %zu bytes - %s\n",

>-- 

>2.7.4


Acked-by: Harish Patil <harish.patil@cavium.com>


>