diff mbox

[dpdk-dev] net/dpaa: prefer defines for link speed values

Message ID 20180309175903.243639-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit March 9, 2018, 5:59 p.m. UTC 
  Use existing defines instead of hardcoded vales.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/dpaa/dpaa_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Shreyansh Jain March 12, 2018, 5:28 a.m. UTC | #1 
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Friday, March 9, 2018 11:29 PM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>; Shreyansh Jain
> <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
> Subject: [PATCH] net/dpaa: prefer defines for link speed values
> 
> Use existing defines instead of hardcoded vales.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---

Acked-by: Shreyansh Jain <Shreyansh.jain@nxp.com>
Ferruh Yigit March 27, 2018, 5:31 p.m. UTC | #2 
On 3/12/2018 5:28 AM, Shreyansh Jain wrote:
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Friday, March 9, 2018 11:29 PM
>> To: Hemant Agrawal <hemant.agrawal@nxp.com>; Shreyansh Jain
>> <shreyansh.jain@nxp.com>
>> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
>> Subject: [PATCH] net/dpaa: prefer defines for link speed values
>>
>> Use existing defines instead of hardcoded vales.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
> 
> Acked-by: Shreyansh Jain <Shreyansh.jain@nxp.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 9b69ef456..db493648a 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -275,9 +275,9 @@  static int dpaa_eth_link_update(struct rte_eth_dev *dev,
 	PMD_INIT_FUNC_TRACE();
 
 	if (dpaa_intf->fif->mac_type == fman_mac_1g)
-		link->link_speed = 1000;
+		link->link_speed = ETH_SPEED_NUM_1G;
 	else if (dpaa_intf->fif->mac_type == fman_mac_10g)
-		link->link_speed = 10000;
+		link->link_speed = ETH_SPEED_NUM_10G;
 	else
 		DPAA_PMD_ERR("invalid link_speed: %s, %d",
 			     dpaa_intf->name, dpaa_intf->fif->mac_type);