[dpdk-dev,12/13] ethdev: fix library version in meson build

Message ID 1521545187-27096-13-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Andrew Rybchenko March 20, 2018, 11:26 a.m. UTC
  Fixes: 701ac75666b9 ("ethdev: remove versioning of ethdev filter control function")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_ether/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Bruce Richardson March 23, 2018, 9:46 p.m. UTC | #1
On Tue, Mar 20, 2018 at 11:26:26AM +0000, Andrew Rybchenko wrote:
> Fixes: 701ac75666b9 ("ethdev: remove versioning of ethdev filter control function")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  lib/librte_ether/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_ether/meson.build b/lib/librte_ether/meson.build
> index 7fed860..12bdb6b 100644
> --- a/lib/librte_ether/meson.build
> +++ b/lib/librte_ether/meson.build
> @@ -2,7 +2,7 @@
>  # Copyright(c) 2017 Intel Corporation
>  
>  name = 'ethdev'
> -version = 8
> +version = 9

My copy of latest head in git shows this as still being 8. However, I see
it's down as 9 in next-net. Therefore I think we need to put this patch
into next-net, perhaps merging with the appropriate patch there which
updates the Makefile.

Ferruh, perhaps you could look at this one?

/Bruce
  
Ferruh Yigit April 5, 2018, 5:33 p.m. UTC | #2
On 3/23/2018 9:46 PM, Bruce Richardson wrote:
> On Tue, Mar 20, 2018 at 11:26:26AM +0000, Andrew Rybchenko wrote:
>> Fixes: 701ac75666b9 ("ethdev: remove versioning of ethdev filter control function")
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>>  lib/librte_ether/meson.build | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_ether/meson.build b/lib/librte_ether/meson.build
>> index 7fed860..12bdb6b 100644
>> --- a/lib/librte_ether/meson.build
>> +++ b/lib/librte_ether/meson.build
>> @@ -2,7 +2,7 @@
>>  # Copyright(c) 2017 Intel Corporation
>>  
>>  name = 'ethdev'
>> -version = 8
>> +version = 9
> 
> My copy of latest head in git shows this as still being 8. However, I see
> it's down as 9 in next-net. Therefore I think we need to put this patch
> into next-net, perhaps merging with the appropriate patch there which
> updates the Makefile.
> 
> Ferruh, perhaps you could look at this one?

Applied to dpdk-next-net/master, thanks.

(Not able to squash because next-net pulled from main tree and the original
commit is now part of main tree)
  

Patch

diff --git a/lib/librte_ether/meson.build b/lib/librte_ether/meson.build
index 7fed860..12bdb6b 100644
--- a/lib/librte_ether/meson.build
+++ b/lib/librte_ether/meson.build
@@ -2,7 +2,7 @@ 
 # Copyright(c) 2017 Intel Corporation
 
 name = 'ethdev'
-version = 8
+version = 9
 allow_experimental_apis = true
 sources = files('ethdev_profile.c',
 	'rte_ethdev.c',