[dpdk-dev,v3,2/6] config/common_base: Add Intel FPGA Build Configuration Macro

  Signed-off-by: Rosen Xu <rosen.xu@intel.com>
---
 config/common_base | 6 ++++++
 1 file changed, 6 insertions(+)
  

On Wed, Mar 28, 2018 at 05:29:52PM +0800, Rosen Xu wrote:
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> ---
>  config/common_base | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/config/common_base b/config/common_base
> index ad03cf4..08b7cce 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -134,6 +134,12 @@ CONFIG_RTE_LIBRTE_PCI_BUS=y
>  CONFIG_RTE_LIBRTE_VDEV_BUS=y
>  
>  #
> +# Compile the Intel FPGA bus
> +#
> +CONFIG_RTE_LIBRTE_IFPGA_BUS=y
> +CONFIG_RTE_LIBRTE_IFPGA_RAWDEV=y
> +
> +#

Please squash this patch with their relevant counterparts.
As it is, this won't trigger an error but the patch is meaningless.

>  # Compile ARK PMD
>  #
>  CONFIG_RTE_LIBRTE_ARK_PMD=y
> -- 
> 1.8.3.1
>
  

> -----Original Message-----
> From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Wednesday, March 28, 2018 21:27
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; shreyansh.jain@nxp.com;
> Zhang, Tianfei <tianfei.zhang@intel.com>; Wu, Hao <hao.wu@intel.com>
> Subject: Re: [PATCH v3 2/6] config/common_base: Add Intel FPGA Build
> Configuration Macro
> 
> On Wed, Mar 28, 2018 at 05:29:52PM +0800, Rosen Xu wrote:
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> >  config/common_base | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/config/common_base b/config/common_base index
> > ad03cf4..08b7cce 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -134,6 +134,12 @@ CONFIG_RTE_LIBRTE_PCI_BUS=y
> > CONFIG_RTE_LIBRTE_VDEV_BUS=y
> >
> >  #
> > +# Compile the Intel FPGA bus
> > +#
> > +CONFIG_RTE_LIBRTE_IFPGA_BUS=y
> > +CONFIG_RTE_LIBRTE_IFPGA_RAWDEV=y
> > +
> > +#
> 
> Please squash this patch with their relevant counterparts.
> As it is, this won't trigger an error but the patch is meaningless.

It's done by PATCH v4.

> >  # Compile ARK PMD
> >  #
> >  CONFIG_RTE_LIBRTE_ARK_PMD=y
> > --
> > 1.8.3.1
> >
> 
> --
> Gaëtan Rivet
> 6WIND
  

Hi Gaetan,

I have squash this patch with their relevant counterparts.
For PATCH v4 and later version CONFIG_RTE_LIBRTE_IFPGA_BUS is squashed with ifpga_bus driver,
And CONFIG_RTE_LIBRTE_IFPGA_RAWDEV is squashed with ifpga_rawdev driver.
Is it ok?

> -----Original Message-----
> From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Wednesday, March 28, 2018 21:27
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; shreyansh.jain@nxp.com;
> Zhang, Tianfei <tianfei.zhang@intel.com>; Wu, Hao <hao.wu@intel.com>
> Subject: Re: [PATCH v3 2/6] config/common_base: Add Intel FPGA Build
> Configuration Macro
> 
> On Wed, Mar 28, 2018 at 05:29:52PM +0800, Rosen Xu wrote:
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> >  config/common_base | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/config/common_base b/config/common_base index
> > ad03cf4..08b7cce 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -134,6 +134,12 @@ CONFIG_RTE_LIBRTE_PCI_BUS=y
> > CONFIG_RTE_LIBRTE_VDEV_BUS=y
> >
> >  #
> > +# Compile the Intel FPGA bus
> > +#
> > +CONFIG_RTE_LIBRTE_IFPGA_BUS=y
> > +CONFIG_RTE_LIBRTE_IFPGA_RAWDEV=y
> > +
> > +#
> 
> Please squash this patch with their relevant counterparts.
> As it is, this won't trigger an error but the patch is meaningless.
> 
> >  # Compile ARK PMD
> >  #
> >  CONFIG_RTE_LIBRTE_ARK_PMD=y
> > --
> > 1.8.3.1
> >
> 
> --
> Gaëtan Rivet
> 6WIND