[dpdk-dev,v3,3/6] mk/rte.app.mk: Add Intel FPGA Bus Build Configuration Macro To App Script

  Signed-off-by: Rosen Xu <rosen.xu@intel.com>
---
 mk/rte.app.mk | 3 +++
 1 file changed, 3 insertions(+)
  

On Wed, Mar 28, 2018 at 05:29:53PM +0800, Rosen Xu wrote:
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> ---
>  mk/rte.app.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 3eb41d1..958b6b5 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -107,6 +107,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE)        += -lrte_cmdline
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER)        += -lrte_reorder
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED)          += -lrte_sched
>  
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS)      += -lrte_bus_ifpga
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV)   += -lrte_ifpga_rawdev
> +

This however, should trigger a link error given that the relevant
libraries are not yet available. Same as before, please squash with the
patch introducing the libraries.

>  ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_KNI)            += -lrte_kni
>  endif
> -- 
> 1.8.3.1
>
  

> -----Original Message-----
> From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Wednesday, March 28, 2018 21:29
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; shreyansh.jain@nxp.com;
> Zhang, Tianfei <tianfei.zhang@intel.com>; Wu, Hao <hao.wu@intel.com>
> Subject: Re: [PATCH v3 3/6] mk/rte.app.mk: Add Intel FPGA Bus Build
> Configuration Macro To App Script
> 
> On Wed, Mar 28, 2018 at 05:29:53PM +0800, Rosen Xu wrote:
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> >  mk/rte.app.mk | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 3eb41d1..958b6b5
> > 100644
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -107,6 +107,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE)        += -
> lrte_cmdline
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER)        += -lrte_reorder
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED)          += -lrte_sched
> >
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS)      += -lrte_bus_ifpga
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV)   += -
> lrte_ifpga_rawdev
> > +
> 
> This however, should trigger a link error given that the relevant libraries are
> not yet available. Same as before, please squash with the patch introducing
> the libraries.

It's done by PATCH v4.

> >  ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_KNI)            += -lrte_kni
> >  endif
> > --
> > 1.8.3.1
> >
> 
> --
> Gaëtan Rivet
> 6WIND
  

Hi Gaetan,

> -----Original Message-----
> From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Wednesday, March 28, 2018 21:29
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; shreyansh.jain@nxp.com;
> Zhang, Tianfei <tianfei.zhang@intel.com>; Wu, Hao <hao.wu@intel.com>
> Subject: Re: [PATCH v3 3/6] mk/rte.app.mk: Add Intel FPGA Bus Build
> Configuration Macro To App Script
> 
> On Wed, Mar 28, 2018 at 05:29:53PM +0800, Rosen Xu wrote:
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> >  mk/rte.app.mk | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 3eb41d1..958b6b5
> > 100644
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -107,6 +107,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE)        += -
> lrte_cmdline
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER)        += -lrte_reorder
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED)          += -lrte_sched
> >
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS)      += -lrte_bus_ifpga
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV)   += -
> lrte_ifpga_rawdev
> > +
> 
> This however, should trigger a link error given that the relevant libraries are
> not yet available. Same as before, please squash with the patch introducing
> the libraries.

I have fixed the link error comment in my PATCH v5.
For squash comment I have fixed it in my PATCH v4.
Are they ok?

> >  ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_KNI)            += -lrte_kni
> >  endif
> > --
> > 1.8.3.1
> >
> 
> --
> Gaëtan Rivet
> 6WIND