diff mbox

[dpdk-dev] mlx: fix warnings for unused compiler arguments

Message ID 20180329133620.92710-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Shahaf Shuler
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Bruce Richardson March 29, 2018, 1:36 p.m. UTC 
  When linking the mlx glue code libraries using CC, the linker arguments in
LDFLAGS are not prefixed with -Wl. [The EXTRA_LDFLAGS are though.] This
leads to warning messages on build:

clang-5.0: warning: argument unused during compilation: '-e xport-dynamic'

Fix this by checking for $LINK_USING_CC in the Makefiles and prefixing the
LDFLAGS appropriately if set.

Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/mlx4/Makefile | 7 ++++++-
 drivers/net/mlx5/Makefile | 7 ++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

Comments

Yongseok Koh March 29, 2018, 8:53 p.m. UTC | #1 
> On Mar 29, 2018, at 6:36 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:
> 
> When linking the mlx glue code libraries using CC, the linker arguments in
> LDFLAGS are not prefixed with -Wl. [The EXTRA_LDFLAGS are though.] This
> leads to warning messages on build:
> 
> clang-5.0: warning: argument unused during compilation: '-e xport-dynamic'
> 
> Fix this by checking for $LINK_USING_CC in the Makefiles and prefixing the
> LDFLAGS appropriately if set.
> 
> Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
> Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks
Shahaf Shuler April 1, 2018, 7:39 a.m. UTC | #2 
Thursday, March 29, 2018 11:54 PM, Yongseok Koh:
> 
> > On Mar 29, 2018, at 6:36 AM, Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > When linking the mlx glue code libraries using CC, the linker
> > arguments in LDFLAGS are not prefixed with -Wl. [The EXTRA_LDFLAGS are
> > though.] This leads to warning messages on build:
> >
> > clang-5.0: warning: argument unused during compilation: '-e xport-
> dynamic'
> >
> > Fix this by checking for $LINK_USING_CC in the Makefiles and prefixing
> > the LDFLAGS appropriately if set.
> >
> > Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
> > Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, thanks. 

> 
> Thanks
diff mbox

Patch

diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
index cc800493b..b6c05ed42 100644
--- a/drivers/net/mlx4/Makefile
+++ b/drivers/net/mlx4/Makefile
@@ -132,8 +132,13 @@  ifeq ($(CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS),y)
 
 $(LIB): $(LIB_GLUE)
 
+ifeq ($(LINK_USING_CC),1)
+GLUE_LDFLAGS := $(call linkerprefix,$(LDFLAGS))
+else
+GLUE_LDFLAGS := $(LDFLAGS)
+endif
 $(LIB_GLUE): mlx4_glue.o
-	$Q $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) \
+	$Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
 		-Wl,-h,$(LIB_GLUE) \
 		-s -shared -o $@ $< -libverbs -lmlx4
 
diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
index 3bc9736c9..011335757 100644
--- a/drivers/net/mlx5/Makefile
+++ b/drivers/net/mlx5/Makefile
@@ -181,8 +181,13 @@  ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y)
 
 $(LIB): $(LIB_GLUE)
 
+ifeq ($(LINK_USING_CC),1)
+GLUE_LDFLAGS := $(call linkerprefix,$(LDFLAGS))
+else
+GLUE_LDFLAGS := $(LDFLAGS)
+endif
 $(LIB_GLUE): mlx5_glue.o
-	$Q $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) \
+	$Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
 		-Wl,-h,$(LIB_GLUE) \
 		-s -shared -o $@ $< -libverbs -lmlx5