diff mbox

[dpdk-dev,v2,11/13] ethdev: fix missing boolean values in flow command

Message ID 20180404144805.11966-12-adrien.mazarguil@6wind.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues

Commit Message

Adrien Mazarguil April 4, 2018, 2:58 p.m. UTC 
  Original implementation lacks the on/off toggle.

This patch shows up as a fix because it has been a popular request ever
since the first DPDK release with the original implementation but was never
addressed.

Fixes: abc3d81aca1b ("app/testpmd: add item raw to flow command")
Cc: stable@dpdk.org

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 app/test-pmd/cmdline_flow.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Nélio Laranjeiro April 5, 2018, 8:17 a.m. UTC | #1 
On Wed, Apr 04, 2018 at 04:58:05PM +0200, Adrien Mazarguil wrote:
> Original implementation lacks the on/off toggle.
> 
> This patch shows up as a fix because it has been a popular request ever
> since the first DPDK release with the original implementation but was never
> addressed.
> 
> Fixes: abc3d81aca1b ("app/testpmd: add item raw to flow command")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

> ---
>  app/test-pmd/cmdline_flow.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index dbf4afebf..30450f1a4 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -2695,6 +2695,7 @@ static const char *const boolean_name[] = {
>  	"false", "true",
>  	"no", "yes",
>  	"N", "Y",
> +	"off", "on",
>  	NULL,
>  };
>  
> -- 
> 2.11.0
diff mbox

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index dbf4afebf..30450f1a4 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -2695,6 +2695,7 @@  static const char *const boolean_name[] = {
 	"false", "true",
 	"no", "yes",
 	"N", "Y",
+	"off", "on",
 	NULL,
 };