[dpdk-dev,v3,10/21] vhost: turn of indirect descriptors for packed virtqueues

Message ID 20180405101031.26468-11-jfreimann@redhat.com (mailing list archive)
State Changes Requested, archived
Delegated to: Maxime Coquelin
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Jens Freimann April 5, 2018, 10:10 a.m. UTC
  Signed-off-by: Jens Freimann <jfreimann@redhat.com>
---
 lib/librte_vhost/socket.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Maxime Coquelin April 6, 2018, 8:12 a.m. UTC | #1
On 04/05/2018 12:10 PM, Jens Freimann wrote:
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> ---
>   lib/librte_vhost/socket.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index 72d769e6a..05193e368 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -852,6 +852,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
>   
>   #ifndef RTE_LIBRTE_VHOST_PQ
>   		vsocket->features &= ~(1ULL << VIRTIO_F_RING_PACKED);
> +		vsocket->features &= ~(1ULL << VIRTIO_RING_F_INDIRECT_DESC);
hmm.. Shouldn't be the opposite?
>   #endif
>   
>   	if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
>
  

Patch

diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index 72d769e6a..05193e368 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -852,6 +852,7 @@  rte_vhost_driver_register(const char *path, uint64_t flags)
 
 #ifndef RTE_LIBRTE_VHOST_PQ
 		vsocket->features &= ~(1ULL << VIRTIO_F_RING_PACKED);
+		vsocket->features &= ~(1ULL << VIRTIO_RING_F_INDIRECT_DESC);
 #endif
 
 	if ((flags & RTE_VHOST_USER_CLIENT) != 0) {