[dpdk-dev,dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get()

Message ID 20180409201843.2317-1-rami.rosen@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Rami Rosen April 9, 2018, 8:18 p.m. UTC
  This patch fixes a tirvial error in assigning max Rx/Tx 
queues in axgbe_dev_info_get() of the axgbe PMD driver. 

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
 drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Kumar, Ravi1 April 9, 2018, 1:56 p.m. UTC | #1
>This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver. 
>
>Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>---
> drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
>index 07c1337ac..a9a9fb570 100644
>--- a/drivers/net/axgbe/axgbe_ethdev.c
>+++ b/drivers/net/axgbe/axgbe_ethdev.c
>@@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
> 	struct axgbe_port *pdata = dev->data->dev_private;
> 
> 	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
>-	dev_info->max_rx_queues = pdata->tx_ring_count;
>-	dev_info->max_tx_queues = pdata->rx_ring_count;
>+	dev_info->max_rx_queues = pdata->rx_ring_count;
>+	dev_info->max_tx_queues = pdata->tx_ring_count;
> 	dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
> 	dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
> 	dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
>--
>2.14.3
>

Thanks a lot Remi. Wonderful catch. 

Regards,
Ravi
  
Ferruh Yigit April 9, 2018, 2:02 p.m. UTC | #2
On 4/9/2018 2:56 PM, Kumar, Ravi1 wrote:
>> This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver. 
>>
>> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>> ---
>> drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
>> index 07c1337ac..a9a9fb570 100644
>> --- a/drivers/net/axgbe/axgbe_ethdev.c
>> +++ b/drivers/net/axgbe/axgbe_ethdev.c
>> @@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
>> 	struct axgbe_port *pdata = dev->data->dev_private;
>>
>> 	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
>> -	dev_info->max_rx_queues = pdata->tx_ring_count;
>> -	dev_info->max_tx_queues = pdata->rx_ring_count;
>> +	dev_info->max_rx_queues = pdata->rx_ring_count;
>> +	dev_info->max_tx_queues = pdata->tx_ring_count;
>> 	dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
>> 	dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
>> 	dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
>> --
>> 2.14.3
>>
> 
> Thanks a lot Remi. Wonderful catch. 

I am adding your explicit ack for the patch:
Acked-by: Ravi Kumar <ravi1.kumar@amd.com>

> 
> Regards,
> Ravi
>
  
Ferruh Yigit April 12, 2018, 6:02 p.m. UTC | #3
On 4/9/2018 3:02 PM, Ferruh Yigit wrote:
> On 4/9/2018 2:56 PM, Kumar, Ravi1 wrote:
>>> This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver. 
>>>
>>> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>>> ---
>>> drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
>>> index 07c1337ac..a9a9fb570 100644
>>> --- a/drivers/net/axgbe/axgbe_ethdev.c
>>> +++ b/drivers/net/axgbe/axgbe_ethdev.c
>>> @@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
>>> 	struct axgbe_port *pdata = dev->data->dev_private;
>>>
>>> 	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
>>> -	dev_info->max_rx_queues = pdata->tx_ring_count;
>>> -	dev_info->max_tx_queues = pdata->rx_ring_count;
>>> +	dev_info->max_rx_queues = pdata->rx_ring_count;
>>> +	dev_info->max_tx_queues = pdata->tx_ring_count;
>>> 	dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
>>> 	dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
>>> 	dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
>>> --
>>> 2.14.3
>>>
>>
>> Thanks a lot Remi. Wonderful catch. 
> 
> I am adding your explicit ack for the patch:
> Acked-by: Ravi Kumar <ravi1.kumar@amd.com>

Squashed into relevant commit in next-net, thanks.
  

Patch

diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
index 07c1337ac..a9a9fb570 100644
--- a/drivers/net/axgbe/axgbe_ethdev.c
+++ b/drivers/net/axgbe/axgbe_ethdev.c
@@ -355,8 +355,8 @@  axgbe_dev_info_get(struct rte_eth_dev *dev,
 	struct axgbe_port *pdata = dev->data->dev_private;
 
 	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
-	dev_info->max_rx_queues = pdata->tx_ring_count;
-	dev_info->max_tx_queues = pdata->rx_ring_count;
+	dev_info->max_rx_queues = pdata->rx_ring_count;
+	dev_info->max_tx_queues = pdata->tx_ring_count;
 	dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
 	dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
 	dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;