diff mbox

[dpdk-dev,v1] net/failsafe: add TCP TSO default Tx capability

Message ID 1523341020-4534-1-git-send-email-ophirmu@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ophir Munk April 10, 2018, 6:17 a.m. UTC 
  Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
The net result of failsafe Tx capabilities is the logical AND of Tx
capabilities among all failsafe sub_devices and failsafe own default
capabilities.

Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
---
 drivers/net/failsafe/failsafe_ops.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit April 24, 2018, 12:49 p.m. UTC | #1 
On 4/10/2018 7:17 AM, Ophir Munk wrote:
> Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
> The net result of failsafe Tx capabilities is the logical AND of Tx
> capabilities among all failsafe sub_devices and failsafe own default
> capabilities.
> 
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>

Applied to dpdk-next-net/master, thanks.
Gaëtan Rivet April 24, 2018, 1:11 p.m. UTC | #2 
Hi Ophir,

On Tue, Apr 10, 2018 at 06:17:00AM +0000, Ophir Munk wrote:
> Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
> The net result of failsafe Tx capabilities is the logical AND of Tx
> capabilities among all failsafe sub_devices and failsafe own default
> capabilities.
> 
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>

Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

> ---
>  drivers/net/failsafe/failsafe_ops.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
> index 057e435..e33821a 100644
> --- a/drivers/net/failsafe/failsafe_ops.c
> +++ b/drivers/net/failsafe/failsafe_ops.c
> @@ -81,7 +81,8 @@ static struct rte_eth_dev_info default_infos = {
>  		DEV_TX_OFFLOAD_MULTI_SEGS |
>  		DEV_TX_OFFLOAD_IPV4_CKSUM |
>  		DEV_TX_OFFLOAD_UDP_CKSUM |
> -		DEV_TX_OFFLOAD_TCP_CKSUM,
> +		DEV_TX_OFFLOAD_TCP_CKSUM |
> +		DEV_TX_OFFLOAD_TCP_TSO,
>  	.flow_type_rss_offloads = 0x0,
>  };
>  
> -- 
> 2.7.4
> 

Thanks,
Ferruh Yigit April 24, 2018, 2:17 p.m. UTC | #3 
On 4/24/2018 2:11 PM, Gaëtan Rivet wrote:
> Hi Ophir,
> 
> On Tue, Apr 10, 2018 at 06:17:00AM +0000, Ophir Munk wrote:
>> Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
>> The net result of failsafe Tx capabilities is the logical AND of Tx
>> capabilities among all failsafe sub_devices and failsafe own default
>> capabilities.
>>
>> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> 
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Hi Gaetan,

My bad that I confused the maintainer for the PMD, that is why it went in
without waiting your ack, sorry about that.

I will update commit to add your ack.
Gaëtan Rivet April 24, 2018, 2:19 p.m. UTC | #4 
On Tue, Apr 24, 2018 at 03:17:31PM +0100, Ferruh Yigit wrote:
> On 4/24/2018 2:11 PM, Gaëtan Rivet wrote:
> > Hi Ophir,
> > 
> > On Tue, Apr 10, 2018 at 06:17:00AM +0000, Ophir Munk wrote:
> >> Add DEV_TX_OFFLOAD_TCP_TSO to failsafe Tx offload default capabilities.
> >> The net result of failsafe Tx capabilities is the logical AND of Tx
> >> capabilities among all failsafe sub_devices and failsafe own default
> >> capabilities.
> >>
> >> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> > 
> > Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> 
> Hi Gaetan,
> 
> My bad that I confused the maintainer for the PMD, that is why it went in
> without waiting your ack, sorry about that.
> 
> I will update commit to add your ack.

No problem, it was mostly to confirm that including this was ok.

Regards,
diff mbox

Patch

diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
index 057e435..e33821a 100644
--- a/drivers/net/failsafe/failsafe_ops.c
+++ b/drivers/net/failsafe/failsafe_ops.c
@@ -81,7 +81,8 @@  static struct rte_eth_dev_info default_infos = {
 		DEV_TX_OFFLOAD_MULTI_SEGS |
 		DEV_TX_OFFLOAD_IPV4_CKSUM |
 		DEV_TX_OFFLOAD_UDP_CKSUM |
-		DEV_TX_OFFLOAD_TCP_CKSUM,
+		DEV_TX_OFFLOAD_TCP_CKSUM |
+		DEV_TX_OFFLOAD_TCP_TSO,
 	.flow_type_rss_offloads = 0x0,
 };