[dpdk-dev,v5,2/5] vhost: support selective datapath
Checks
Commit Message
03/04/2018 10:02, Maxime Coquelin:
> On 04/02/2018 01:46 PM, Zhihong Wang wrote:
> > lib/librte_vhost/Makefile | 4 +-
> > lib/librte_vhost/rte_vdpa.h | 87 +++++++++++++++++++++++++
> > lib/librte_vhost/rte_vhost_version.map | 7 ++
> > lib/librte_vhost/vdpa.c | 115 +++++++++++++++++++++++++++++++++
>
> With the fix you suggested:
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
This patch is not OK. It is updating the Makefile but not meson.build.
I am fixing/amending it in master:
Comments
On 04/15/2018 07:39 PM, Thomas Monjalon wrote:
> 03/04/2018 10:02, Maxime Coquelin:
>> On 04/02/2018 01:46 PM, Zhihong Wang wrote:
>>> lib/librte_vhost/Makefile | 4 +-
>>> lib/librte_vhost/rte_vdpa.h | 87 +++++++++++++++++++++++++
>>> lib/librte_vhost/rte_vhost_version.map | 7 ++
>>> lib/librte_vhost/vdpa.c | 115 +++++++++++++++++++++++++++++++++
>>
>> With the fix you suggested:
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> This patch is not OK. It is updating the Makefile but not meson.build.
> I am fixing/amending it in master:
>
> --- a/lib/librte_vhost/meson.build
> +++ b/lib/librte_vhost/meson.build
> @@ -9,7 +9,8 @@ if has_libnuma == 1
> endif
> version = 4
> allow_experimental_apis = true
> -sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c',
> +sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vdpa.c',
> + 'vhost.c', 'vhost_user.c',
> 'virtio_net.c', 'vhost_crypto.c')
> -headers = files('rte_vhost.h', 'rte_vhost_crypto.h')
> +headers = files('rte_vhost.h', 'rte_vdpa.h', 'rte_vhost_crypto.h')
>
>
>
Right, thanks Thomas.
Sorry for not catching this, I'm in the process of improving my build
scripts, but as you can see it is not yet ready...
Cheers,
Maxime
@@ -9,7 +9,8 @@ if has_libnuma == 1
endif
version = 4
allow_experimental_apis = true
-sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c',
+sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vdpa.c',
+ 'vhost.c', 'vhost_user.c',
'virtio_net.c', 'vhost_crypto.c')
-headers = files('rte_vhost.h', 'rte_vhost_crypto.h')
+headers = files('rte_vhost.h', 'rte_vdpa.h', 'rte_vhost_crypto.h')