[dpdk-dev] examples/ip_pipeline: fix buffer not null terminated.
Checks
Commit Message
Coverity issue: 272563
Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object")
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
examples/ip_pipeline/swq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Monday, April 16, 2018 11:26 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated.
>
> Coverity issue: 272563
> Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/ip_pipeline/swq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ip_pipeline/swq.c b/examples/ip_pipeline/swq.c
> index c11bbf27e..be78704c1 100644
> --- a/examples/ip_pipeline/swq.c
> +++ b/examples/ip_pipeline/swq.c
> @@ -64,7 +64,7 @@ swq_create(const char *name, struct swq_params
> *params)
> }
>
> /* Node fill in */
> - strncpy(swq->name, name, sizeof(swq->name));
> + strncpy(swq->name, name, sizeof(swq->name) - 1);
> swq->r = r;
>
> /* Node add to list */
> --
> 2.13.6
Acked-by: Cristian.Dumitrescu <cristian.dumitrescu@intel.com>
Applied to next-pipeline tree, thanks!
@@ -64,7 +64,7 @@ swq_create(const char *name, struct swq_params *params)
}
/* Node fill in */
- strncpy(swq->name, name, sizeof(swq->name));
+ strncpy(swq->name, name, sizeof(swq->name) - 1);
swq->r = r;
/* Node add to list */