diff mbox

[dpdk-dev] examples/ip_pipeline: fix uninitialized scalar variable

Message ID 20180416104751.65646-1-roy.fan.zhang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Cristian Dumitrescu
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Fan Zhang April 16, 2018, 10:47 a.m. UTC 
  Coverity issue: 272575
Fixes: 133c2c6565d6 ("examples/ip_pipeline: add link object")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 examples/ip_pipeline/cli.c  | 2 +-
 examples/ip_pipeline/link.c | 8 +++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

Comments

Cristian Dumitrescu May 8, 2018, 2:28 p.m. UTC | #1 
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Monday, April 16, 2018 11:48 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix uninitialized scalar variable
> 
> Coverity issue: 272575
> Fixes: 133c2c6565d6 ("examples/ip_pipeline: add link object")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  examples/ip_pipeline/cli.c  | 2 +-

Acked-by: Cristian.Dumitrescu <cristian.dumitrescu@intel.com>

Applied to next-pipeline tree, thanks!
diff mbox

Patch

diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index 199a31ff8..ec43a2308 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -133,7 +133,7 @@  cmd_link(char **tokens,
 	char *out,
 	size_t out_size)
 {
-	struct link_params p;
+	struct link_params p = {0};
 	struct link_params_rss rss;
 	struct link *link;
 	char *name;
diff --git a/examples/ip_pipeline/link.c b/examples/ip_pipeline/link.c
index 26ff41ba9..25717808c 100644
--- a/examples/ip_pipeline/link.c
+++ b/examples/ip_pipeline/link.c
@@ -121,17 +121,19 @@  link_create(const char *name, struct link_params *params)
 		(params->tx.queue_size == 0))
 		return NULL;
 
-	port_id = params->port_id;
 	if (params->dev_name) {
 		status = rte_eth_dev_get_port_by_name(params->dev_name,
 			&port_id);
 
 		if (status)
 			return NULL;
-	} else
-		if (!rte_eth_dev_is_valid_port(port_id))
+	} else {
+		if (!rte_eth_dev_is_valid_port(params->port_id))
 			return NULL;
 
+		port_id = params->port_id;
+	}
+
 	rte_eth_dev_info_get(port_id, &port_info);
 
 	mempool = mempool_find(params->rx.mempool_name);