Message ID | 20180416150058.2620-11-adrien.mazarguil@6wind.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 06F8F199B5; Mon, 16 Apr 2018 18:22:39 +0200 (CEST) Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 95065D4A6 for <dev@dpdk.org>; Mon, 16 Apr 2018 18:22:19 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id q13so24273531wre.3 for <dev@dpdk.org>; Mon, 16 Apr 2018 09:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YyFFzqeWjOviwT8sqZkzEGbZovDYciK+v6ggP1/6CyE=; b=QTyz24RqFqEVXsUgTBCCBSqSjXzxrV9J4gZcpxZ+ur5tlpvrTdzOnlh+1HKSXzXYHO Dn+NJhQO4Wx1IJcWRKRx4BkQ3YK3p/ev+b4HRiznhJMWmB2R1esGnMCA90B9Ka4fWN5e lAEgjG99ZmLNvs2VKsnAmfft7S6rhOQgtUujaolxKra6+g4PIlNNijC6SBuMMRTe27+/ IbvSp07/zMkkCgpEAJrTnnDSMBDO1vaIalOWlyB5hD6yDDWYVc1AZfYNR4ogpkBdYbtx 1w1BK1gqVfaZDTKLcPdZQt/ZRKF5Du7jdIZpBdbeoVSonSCj5fwr0kq2SI7WDM52F60l R94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YyFFzqeWjOviwT8sqZkzEGbZovDYciK+v6ggP1/6CyE=; b=a4wm2ts/tOT4nQwLuXF4pG+Ae/Pi+ot4/SisHPsipEd2Zw04Hqbxv3K1hl5+H7ulX1 qfSHO6FmxbsDD0ME/MsN0dDD/AZWl9rIFtNOerNF5ERBSyBdPODJdUJtZ7KuROs9jba9 hkk5FYwx8XPyoLooh7972Q0vJGMZ0UZV/f1cfCqdkZzq0rVmItEIdoFijX//68jEZn49 8UFLDgYUUgaUJj0IUeF/xkgjxOC4ptvNx+x5mykL1CnnPPmqp1gkFG4bfaI852qwYrpd NfbRVAcJalHjbt4nJGvr+8eXBr2s9mMAYcpJ0JmzgSLYkXUQtLmpBlsBpkOl2ukyE2ge 5+zw== X-Gm-Message-State: ALQs6tCgCYoWKIizrRIRWKfB/kz7gsd+Bq8Vmq+yh5Cwt7HnRLO15AEe DKTtHeacBRCX8j8VuRCyZp88YtNm X-Google-Smtp-Source: AIpwx490SJWmIzt8MoN0bZOW20aYLOhKNfrtNC533BXcPHFc2U6kz5VwvB7yL6XogtCPYIq2q03z6g== X-Received: by 10.223.177.154 with SMTP id q26mr11061393wra.60.1523895739245; Mon, 16 Apr 2018 09:22:19 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f54sm13453560wra.80.2018.04.16.09.22.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 09:22:18 -0700 (PDT) Date: Mon, 16 Apr 2018 18:22:05 +0200 From: Adrien Mazarguil <adrien.mazarguil@6wind.com> To: dev@dpdk.org Cc: stable@dpdk.org Message-ID: <20180416150058.2620-11-adrien.mazarguil@6wind.com> References: <20180410161132.8776-1-adrien.mazarguil@6wind.com> <20180416150058.2620-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180416150058.2620-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v5 10/11] ethdev: fix missing boolean values in flow command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | fail | Compilation issues |
Commit Message
Adrien Mazarguil
April 16, 2018, 4:22 p.m. UTC
Original implementation lacks the on/off toggle. This patch shows up as a fix because it has been a popular request ever since the first DPDK release with the original implementation but was never addressed. Fixes: abc3d81aca1b ("app/testpmd: add item raw to flow command") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> --- app/test-pmd/cmdline_flow.c | 1 + 1 file changed, 1 insertion(+)
Comments
Hi Adrien I think the title should be "app/testpmd: ..." ... From: Adrien Mazarguil, Monday, April 16, 2018 7:22 PM > Original implementation lacks the on/off toggle. > > This patch shows up as a fix because it has been a popular request ever since > the first DPDK release with the original implementation but was never > addressed. > > Fixes: abc3d81aca1b ("app/testpmd: add item raw to flow command") > Cc: stable@dpdk.org > > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > --- > app/test-pmd/cmdline_flow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index fcd76b56e..f0b4b7bc4 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -2692,6 +2692,7 @@ static const char *const boolean_name[] = { > "false", "true", > "no", "yes", > "N", "Y", > + "off", "on", > NULL, > }; > > -- > 2.11.0
On Mon, Apr 16, 2018 at 07:17:44PM +0000, Matan Azrad wrote: > Hi Adrien > > I think the title should be "app/testpmd: ..." ... Indeed, I'll update it in the next iteration, thanks.
On 4/17/2018 9:25 AM, Adrien Mazarguil wrote: > On Mon, Apr 16, 2018 at 07:17:44PM +0000, Matan Azrad wrote: >> Hi Adrien >> >> I think the title should be "app/testpmd: ..." ... > > Indeed, I'll update it in the next iteration, thanks. If this is the only issue, it can be fixed while applying. Are there more outstanding issues, will there be a new version of the set?
On Wed, Apr 18, 2018 at 06:16:18PM +0100, Ferruh Yigit wrote: > On 4/17/2018 9:25 AM, Adrien Mazarguil wrote: > > On Mon, Apr 16, 2018 at 07:17:44PM +0000, Matan Azrad wrote: > >> Hi Adrien > >> > >> I think the title should be "app/testpmd: ..." ... > > > > Indeed, I'll update it in the next iteration, thanks. > > If this is the only issue, it can be fixed while applying. > Are there more outstanding issues, will there be a new version of the set? Yes, submitted after rebasing it [1]. [1] http://dpdk.org/ml/archives/dev/2018-April/098035.html
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index fcd76b56e..f0b4b7bc4 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -2692,6 +2692,7 @@ static const char *const boolean_name[] = { "false", "true", "no", "yes", "N", "Y", + "off", "on", NULL, };