diff mbox

[dpdk-dev,v3,03/11] compress/isal: add basic pmd ops

Message ID 1523972132-6894-4-git-send-email-lee.daly@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Daly, Lee April 17, 2018, 1:35 p.m. UTC 
  Signed-off-by: Lee Daly <lee.daly@intel.com>
---
 drivers/compress/isal/isal_compress_pmd_ops.c     | 62 +++++++++++++++++++++--
 drivers/compress/isal/isal_compress_pmd_private.h | 12 +++++
 2 files changed, 69 insertions(+), 5 deletions(-)

Comments

De Lara Guarch, Pablo April 24, 2018, 9:28 a.m. UTC | #1 
> -----Original Message-----
> From: Daly, Lee
> Sent: Tuesday, April 17, 2018 2:35 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Tucker, Greg B
> <greg.b.tucker@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Trahe,
> Fiona <fiona.trahe@intel.com>; Daly, Lee <lee.daly@intel.com>
> Subject: [PATCH v3 03/11] compress/isal: add basic pmd ops
> 
> Signed-off-by: Lee Daly <lee.daly@intel.com>
> ---
>  drivers/compress/isal/isal_compress_pmd_ops.c     | 62
> +++++++++++++++++++++--
>  drivers/compress/isal/isal_compress_pmd_private.h | 12 +++++
>  2 files changed, 69 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
> b/drivers/compress/isal/isal_compress_pmd_ops.c
> index cff05b4..ee1ee48 100644
> --- a/drivers/compress/isal/isal_compress_pmd_ops.c
> +++ b/drivers/compress/isal/isal_compress_pmd_ops.c
> @@ -2,18 +2,70 @@
>   * Copyright(c) 2018 Intel Corporation
>   */
> 
> +#include <rte_common.h>
>  #include <rte_compressdev_pmd.h>
> 
> +#include "isal_compress_pmd_private.h"
> +
> +static const struct rte_compressdev_capabilities isal_pmd_capabilities[] = {
> +	RTE_COMP_END_OF_CAPABILITIES_LIST()
> +};
> +
> +/** Configure device */
> +static int
> +isal_comp_pmd_config(struct rte_compressdev *dev __rte_unused,
> +		struct rte_compressdev_config *config __rte_unused) {
> +	return 0;
> +}
> +
> +/** Start device */
> +static int
> +isal_comp_pmd_start(__rte_unused struct rte_compressdev *dev) {
> +	return 0;
> +}
> +
> +/** Stop device */
> +static void
> +isal_comp_pmd_stop(__rte_unused struct rte_compressdev *dev) { }
> +
> +/** Close device */
> +static int
> +isal_comp_pmd_close(__rte_unused struct rte_compressdev *dev) {
> +	return 0;
> +}
> +
> +/** Get device info */
> +static void
> +isal_comp_pmd_info_get(struct rte_compressdev *dev __rte_unused,
> +		struct rte_compressdev_info *dev_info) {
> +	if (dev_info != NULL) {
> +		dev_info->capabilities = isal_pmd_capabilities;
> +		dev_info->feature_flags = RTE_COMPDEV_FF_CPU_AVX512 |
> +				RTE_COMPDEV_FF_CPU_AVX2 |
> +				RTE_COMPDEV_FF_CPU_AVX |
> +				RTE_COMPDEV_FF_CPU_SSE;
> +	}
> +}
> +
> +
> +
> +

Remove extra blank lines.
diff mbox

Patch

diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c
index cff05b4..ee1ee48 100644
--- a/drivers/compress/isal/isal_compress_pmd_ops.c
+++ b/drivers/compress/isal/isal_compress_pmd_ops.c
@@ -2,18 +2,70 @@ 
  * Copyright(c) 2018 Intel Corporation
  */
 
+#include <rte_common.h>
 #include <rte_compressdev_pmd.h>
 
+#include "isal_compress_pmd_private.h"
+
+static const struct rte_compressdev_capabilities isal_pmd_capabilities[] = {
+	RTE_COMP_END_OF_CAPABILITIES_LIST()
+};
+
+/** Configure device */
+static int
+isal_comp_pmd_config(struct rte_compressdev *dev __rte_unused,
+		struct rte_compressdev_config *config __rte_unused)
+{
+	return 0;
+}
+
+/** Start device */
+static int
+isal_comp_pmd_start(__rte_unused struct rte_compressdev *dev)
+{
+	return 0;
+}
+
+/** Stop device */
+static void
+isal_comp_pmd_stop(__rte_unused struct rte_compressdev *dev)
+{
+}
+
+/** Close device */
+static int
+isal_comp_pmd_close(__rte_unused struct rte_compressdev *dev)
+{
+	return 0;
+}
+
+/** Get device info */
+static void
+isal_comp_pmd_info_get(struct rte_compressdev *dev __rte_unused,
+		struct rte_compressdev_info *dev_info)
+{
+	if (dev_info != NULL) {
+		dev_info->capabilities = isal_pmd_capabilities;
+		dev_info->feature_flags = RTE_COMPDEV_FF_CPU_AVX512 |
+				RTE_COMPDEV_FF_CPU_AVX2 |
+				RTE_COMPDEV_FF_CPU_AVX |
+				RTE_COMPDEV_FF_CPU_SSE;
+	}
+}
+
+
+
+
 struct rte_compressdev_ops isal_pmd_ops = {
-		.dev_configure		= NULL,
-		.dev_start		= NULL,
-		.dev_stop		= NULL,
-		.dev_close		= NULL,
+		.dev_configure		= isal_comp_pmd_config,
+		.dev_start		= isal_comp_pmd_start,
+		.dev_stop		= isal_comp_pmd_stop,
+		.dev_close		= isal_comp_pmd_close,
 
 		.stats_get		= NULL,
 		.stats_reset		= NULL,
 
-		.dev_infos_get		= NULL,
+		.dev_infos_get		= isal_comp_pmd_info_get,
 
 		.queue_pair_setup	= NULL,
 		.queue_pair_release	= NULL,
diff --git a/drivers/compress/isal/isal_compress_pmd_private.h b/drivers/compress/isal/isal_compress_pmd_private.h
index 09ecfb7..efbe68b 100644
--- a/drivers/compress/isal/isal_compress_pmd_private.h
+++ b/drivers/compress/isal/isal_compress_pmd_private.h
@@ -18,6 +18,18 @@  struct isal_comp_private {
 	struct rte_mempool *priv_xform_mp;
 };
 
+/** ISA-L queue pair */
+struct isal_comp_qp {
+	/* Queue Pair Identifier */
+	uint16_t id;
+	/* Unique Queue Pair Name */
+	char name[RTE_COMPRESSDEV_NAME_MAX_LEN];
+	/* Queue pair statistics */
+	struct rte_compressdev_stats qp_stats;
+	/* Number of free elements on ring */
+	uint16_t num_free_elements;
+} __rte_cache_aligned;
+
 /** device specific operations function pointer structure */
 extern struct rte_compressdev_ops *isal_compress_pmd_ops;