diff mbox

[dpdk-dev,v4] doc: announce ethdev CRC strip flag deprecation

Message ID 20180417133949.32883-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit April 17, 2018, 1:39 p.m. UTC 
  Make CRC stripping default behavior, deprecate flag
DEV_RX_OFFLOAD_CRC_STRIP.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
v2:
* Make CRC behavior active in this release

v3:
* Distribute switch into next two releases for more smooth transition
  v18.08: add new flag to keep crc, and implement this in PMDs
  v18.11: remove crc strip flag and make default behavior to strip crc

v4:
* Remove git artifact
---
 doc/guides/rel_notes/deprecation.rst | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Shahaf Shuler April 17, 2018, 1:47 p.m. UTC | #1 
Tuesday, April 17, 2018 4:40 PM, Ferruh Yigit:
> Subject: [PATCH v4] doc: announce ethdev CRC strip flag deprecation
> 
> Make CRC stripping default behavior, deprecate flag
> DEV_RX_OFFLOAD_CRC_STRIP.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> v2:
> * Make CRC behavior active in this release
> 
> v3:
> * Distribute switch into next two releases for more smooth transition
>   v18.08: add new flag to keep crc, and implement this in PMDs
>   v18.11: remove crc strip flag and make default behavior to strip crc
> 
> v4:
> * Remove git artifact
> ---
>  doc/guides/rel_notes/deprecation.rst | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index fd9def20c..dbc405450 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -100,6 +100,22 @@ Deprecation Notices
>    between the VF representor and the VF or the parent PF. Those new fields
>    are to be included in ``rte_eth_dev_info`` struct.
> 
> +* ethdev: A new offloading flag ``DEV_RX_OFFLOAD_KEEP_CRC`` will be
> +added in v18.08,
> +  This will replace the usage of not setting
> +``DEV_RX_OFFLOAD_CRC_STRIP`` flag
> +  and will be implemented in PMDs accordingly.
> +  In v18.08 both ``DEV_RX_OFFLOAD_KEEP_CRC`` and
> +``DEV_RX_OFFLOAD_CRC_STRIP`` flags
> +  will be available, usage will be:
> +  ``CRC_STRIP``: Strip CRC from packet
> +  ``KEEP_CRC``: Keep CRC in packet
> +  Both ``CRC_STRIP`` & ``KEEP_CRC``: Invalid
> +  No flag: Keep CRC in packet
> +
> +* ethdev: In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be
> +removed, default
> +  behavior without any flag will be changed to CRC strip.
> +  To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required.
> +  ``KEEP_CRC``: Keep CRC in packet
> +  No flag: Strip CRC from packet
> +
>  * i40e: The default flexible payload configuration which extracts the first 16
>    bytes of the payload for RSS will be deprecated starting from 18.02. If
>    required the previous behavior can be configured using existing flow
> --
> 2.14.3

Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Thomas Monjalon May 28, 2018, 1:05 a.m. UTC | #2 
17/04/2018 15:47, Shahaf Shuler:
> Tuesday, April 17, 2018 4:40 PM, Ferruh Yigit:
> > Subject: [PATCH v4] doc: announce ethdev CRC strip flag deprecation
> > 
> > Make CRC stripping default behavior, deprecate flag
> > DEV_RX_OFFLOAD_CRC_STRIP.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>
Maxime Coquelin Aug. 1, 2018, 3:27 p.m. UTC | #3 
On 04/17/2018 03:39 PM, Ferruh Yigit wrote:
> Make CRC stripping default behavior, deprecate flag
> DEV_RX_OFFLOAD_CRC_STRIP.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> v2:
> * Make CRC behavior active in this release
> 
> v3:
> * Distribute switch into next two releases for more smooth transition
>    v18.08: add new flag to keep crc, and implement this in PMDs
>    v18.11: remove crc strip flag and make default behavior to strip crc
> 
> v4:
> * Remove git artifact
> ---
>   doc/guides/rel_notes/deprecation.rst | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Shahaf Shuler Aug. 2, 2018, 8:50 a.m. UTC | #4 
Wednesday, August 1, 2018 6:27 PM, Maxime Coquelin:
> Subject: Re: [dpdk-dev] [PATCH v4] doc: announce ethdev CRC strip flag
> deprecation
> 
> 
> 
> On 04/17/2018 03:39 PM, Ferruh Yigit wrote:
> > Make CRC stripping default behavior, deprecate flag
> > DEV_RX_OFFLOAD_CRC_STRIP.
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > ---
> > v2:
> > * Make CRC behavior active in this release
> >
> > v3:
> > * Distribute switch into next two releases for more smooth transition
> >    v18.08: add new flag to keep crc, and implement this in PMDs
> >    v18.11: remove crc strip flag and make default behavior to strip
> > crc
> >
> > v4:
> > * Remove git artifact
> > ---
> >   doc/guides/rel_notes/deprecation.rst | 16 ++++++++++++++++
> >   1 file changed, 16 insertions(+)
> >
> 
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Acked-by: Shahaf Shuler <shahafs@mellanox.com>
diff mbox

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index fd9def20c..dbc405450 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -100,6 +100,22 @@  Deprecation Notices
   between the VF representor and the VF or the parent PF. Those new fields
   are to be included in ``rte_eth_dev_info`` struct.
 
+* ethdev: A new offloading flag ``DEV_RX_OFFLOAD_KEEP_CRC`` will be added in v18.08,
+  This will replace the usage of not setting ``DEV_RX_OFFLOAD_CRC_STRIP`` flag
+  and will be implemented in PMDs accordingly.
+  In v18.08 both ``DEV_RX_OFFLOAD_KEEP_CRC`` and ``DEV_RX_OFFLOAD_CRC_STRIP`` flags
+  will be available, usage will be:
+  ``CRC_STRIP``: Strip CRC from packet
+  ``KEEP_CRC``: Keep CRC in packet
+  Both ``CRC_STRIP`` & ``KEEP_CRC``: Invalid
+  No flag: Keep CRC in packet
+
+* ethdev: In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be removed, default
+  behavior without any flag will be changed to CRC strip.
+  To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required.
+  ``KEEP_CRC``: Keep CRC in packet
+  No flag: Strip CRC from packet
+
 * i40e: The default flexible payload configuration which extracts the first 16
   bytes of the payload for RSS will be deprecated starting from 18.02. If
   required the previous behavior can be configured using existing flow