diff mbox

[dpdk-dev] net/axgbe: fix incorrect cache alignment macro

Message ID 20180417200458.23412-1-pbhagavatula@caviumnetworks.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Pavan Nikhilesh April 17, 2018, 8:04 p.m. UTC 
  Due to missing ____cacheline_aligned definition compiler treats it as a
global variable replace it with proper cache alignment macro.

Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup")

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 drivers/net/axgbe/axgbe_rxtx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit April 18, 2018, 5:17 p.m. UTC | #1 
On 4/17/2018 9:04 PM, Pavan Nikhilesh wrote:
> Due to missing ____cacheline_aligned definition compiler treats it as a
> global variable replace it with proper cache alignment macro.
> 
> Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup")
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit April 18, 2018, 5:44 p.m. UTC | #2 
On 4/18/2018 6:17 PM, Ferruh Yigit wrote:
> On 4/17/2018 9:04 PM, Pavan Nikhilesh wrote:
>> Due to missing ____cacheline_aligned definition compiler treats it as a
>> global variable replace it with proper cache alignment macro.
>>
>> Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup")
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
Kumar, Ravi1 April 23, 2018, 6:32 a.m. UTC | #3 
>On 4/18/2018 6:17 PM, Ferruh Yigit wrote:

>> On 4/17/2018 9:04 PM, Pavan Nikhilesh wrote:

>>> Due to missing ____cacheline_aligned definition compiler treats it as 

>>> a global variable replace it with proper cache alignment macro.

>>>

>>> Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup")

>>>

>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

>> 

>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

>

>Applied to dpdk-next-net/master, thanks.

>

Thanks a lot Ferruh.

Regards,
Ravi
diff mbox

Patch

diff --git a/drivers/net/axgbe/axgbe_rxtx.h b/drivers/net/axgbe/axgbe_rxtx.h
index 1ec6c2ca6..917da58ce 100644
--- a/drivers/net/axgbe/axgbe_rxtx.h
+++ b/drivers/net/axgbe/axgbe_rxtx.h
@@ -94,7 +94,7 @@  struct axgbe_rx_queue {
 	/* Number of mbufs allocated from pool*/
 	uint64_t mbuf_alloc;
 
-} ____cacheline_aligned;
+} __rte_cache_aligned;
 
 /*Tx descriptor format */
 struct axgbe_tx_desc {