[dpdk-dev] lib/librte_ip_frag:fix ip frag process log

Message ID 1524041497-25309-1-git-send-email-han.li1@zte.com.cn (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Li Han April 18, 2018, 8:51 a.m. UTC
  in ip_frag_process,some IP_FRAG_LOG content is wrong

Signed-off-by: Li Han <han.li1@zte.com.cn>
---
 lib/librte_ip_frag/ip_frag_internal.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
  

Comments

Thomas Monjalon May 13, 2018, 10:05 p.m. UTC | #1
Any review please?

18/04/2018 10:51, Li Han:
> in ip_frag_process,some IP_FRAG_LOG content is wrong
> 
> Signed-off-by: Li Han <han.li1@zte.com.cn>
  
Ananyev, Konstantin May 14, 2018, 11:05 a.m. UTC | #2
> -----Original Message-----
> From: Li Han [mailto:han.li1@zte.com.cn]
> Sent: Wednesday, April 18, 2018 9:52 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; Li Han <han.li1@zte.com.cn>
> Subject: [PATCH] lib/librte_ip_frag:fix ip frag process log
> 
> in ip_frag_process,some IP_FRAG_LOG content is wrong
> 
> Signed-off-by: Li Han <han.li1@zte.com.cn>
> ---

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
  
Thomas Monjalon May 14, 2018, 7:16 p.m. UTC | #3
14/05/2018 13:05, Ananyev, Konstantin:
> 
> > -----Original Message-----
> > From: Li Han [mailto:han.li1@zte.com.cn]
> > Sent: Wednesday, April 18, 2018 9:52 AM
> > To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> > Cc: dev@dpdk.org; Li Han <han.li1@zte.com.cn>
> > Subject: [PATCH] lib/librte_ip_frag:fix ip frag process log
> > 
> > in ip_frag_process,some IP_FRAG_LOG content is wrong
> > 
> > Signed-off-by: Li Han <han.li1@zte.com.cn>
> > ---
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

    Fixes: 4f1a8f633862 ("ip_frag: add IPv6 reassembly")
    Cc: stable@dpdk.org

Applied, thanks
  

Patch

diff --git a/lib/librte_ip_frag/ip_frag_internal.c b/lib/librte_ip_frag/ip_frag_internal.c
index 7397aa6..2560c77 100644
--- a/lib/librte_ip_frag/ip_frag_internal.c
+++ b/lib/librte_ip_frag/ip_frag_internal.c
@@ -152,7 +152,7 @@  struct rte_mbuf *
 				fp->frags[IP_LAST_FRAG_IDX].len);
 		else
 			IP_FRAG_LOG(DEBUG, "%s:%d invalid fragmented packet:\n"
-				"ipv4_frag_pkt: %p, key: <" IPv6_KEY_BYTES_FMT ", %#x>, "
+				"ipv6_frag_pkt: %p, key: <" IPv6_KEY_BYTES_FMT ", %#x>, "
 				"total_size: %u, frag_size: %u, last_idx: %u\n"
 				"first fragment: ofs: %u, len: %u\n"
 				"last fragment: ofs: %u, len: %u\n\n",
@@ -210,7 +210,7 @@  struct rte_mbuf *
 				fp->frags[IP_LAST_FRAG_IDX].len);
 		else
 			IP_FRAG_LOG(DEBUG, "%s:%d invalid fragmented packet:\n"
-				"ipv4_frag_pkt: %p, key: <" IPv6_KEY_BYTES_FMT ", %#x>, "
+				"ipv6_frag_pkt: %p, key: <" IPv6_KEY_BYTES_FMT ", %#x>, "
 				"total_size: %u, frag_size: %u, last_idx: %u\n"
 				"first fragment: ofs: %u, len: %u\n"
 				"last fragment: ofs: %u, len: %u\n\n",
@@ -331,7 +331,7 @@  struct ip_frag_pkt *
 		if (p1->key.key_len == IPV4_KEYLEN)
 			IP_FRAG_LOG(DEBUG, "%s:%d:\n"
 					"tbl: %p, max_entries: %u, use_entries: %u\n"
-					"ipv6_frag_pkt line0: %p, index: %u from %u\n"
+					"ipv4_frag_pkt line0: %p, index: %u from %u\n"
 			"key: <%" PRIx64 ", %#x>, start: %" PRIu64 "\n",
 					__func__, __LINE__,
 					tbl, tbl->max_entries, tbl->use_entries,
@@ -357,7 +357,7 @@  struct ip_frag_pkt *
 		if (p2->key.key_len == IPV4_KEYLEN)
 			IP_FRAG_LOG(DEBUG, "%s:%d:\n"
 					"tbl: %p, max_entries: %u, use_entries: %u\n"
-					"ipv6_frag_pkt line1: %p, index: %u from %u\n"
+					"ipv4_frag_pkt line1: %p, index: %u from %u\n"
 			"key: <%" PRIx64 ", %#x>, start: %" PRIu64 "\n",
 					__func__, __LINE__,
 					tbl, tbl->max_entries, tbl->use_entries,