[dpdk-dev] eal: fix memory leak
Checks
Commit Message
params is not freed if pthread_create() fails. The fix is
straight-forward.
Fixes: 3d09a6e26d8b ("eal: fix threads block on barrier")
Reported-by: Olivier Matz <olivier.matz@6wind.com>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
lib/librte_eal/common/eal_common_thread.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
On Wed, May 02, 2018 at 10:26:32AM +0000, Jianfeng Tan wrote:
> params is not freed if pthread_create() fails. The fix is
> straight-forward.
>
> Fixes: 3d09a6e26d8b ("eal: fix threads block on barrier")
>
> Reported-by: Olivier Matz <olivier.matz@6wind.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
02/05/2018 13:09, Olivier Matz:
> On Wed, May 02, 2018 at 10:26:32AM +0000, Jianfeng Tan wrote:
> > params is not freed if pthread_create() fails. The fix is
> > straight-forward.
> >
> > Fixes: 3d09a6e26d8b ("eal: fix threads block on barrier")
> >
> > Reported-by: Olivier Matz <olivier.matz@6wind.com>
> > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
@@ -183,8 +183,10 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
pthread_barrier_init(¶ms->configured, NULL, 2);
ret = pthread_create(thread, attr, rte_thread_init, (void *)params);
- if (ret != 0)
+ if (ret != 0) {
+ free(params);
return ret;
+ }
if (name != NULL) {
ret = rte_thread_setname(*thread, name);