diff mbox

[dpdk-dev] net/mlx4: fix compilation issues in glue mode

Message ID 20180502152554.23257-1-adrien.mazarguil@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Adrien Mazarguil May 2, 2018, 3:28 p.m. UTC 
  Since the commit referenced below, compiling mlx4 along with its glue
library (CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS=y) triggers a compilation
failure due to undefined symbols.

They are caused by Verbs calls made directly from the PMD instead of going
through the glue library.

Fixes: ffc7411cabfe ("net/mlx4: fix inner RSS support for broken kernels")

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 drivers/net/mlx4/mlx4.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Ferruh Yigit May 2, 2018, 5:12 p.m. UTC | #1 
On 5/2/2018 4:28 PM, Adrien Mazarguil wrote:
> Since the commit referenced below, compiling mlx4 along with its glue
> library (CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS=y) triggers a compilation
> failure due to undefined symbols.
> 
> They are caused by Verbs calls made directly from the PMD instead of going
> through the glue library.
> 
> Fixes: ffc7411cabfe ("net/mlx4: fix inner RSS support for broken kernels")
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Squashed into relevant commit in next-net, thanks.
diff mbox

Patch

diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index c1cc95786..47451b651 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -469,14 +469,14 @@  mlx4_hw_rss_sup(struct ibv_context *ctx, struct ibv_pd *pd,
 		     " quirk");
 		hw_rss_sup &= ~IBV_RX_HASH_INNER;
 	} else {
-		claim_zero(ibv_destroy_qp(qp));
+		claim_zero(mlx4_glue->destroy_qp(qp));
 	}
 	if (ind)
-		claim_zero(ibv_destroy_rwq_ind_table(ind));
+		claim_zero(mlx4_glue->destroy_rwq_ind_table(ind));
 	if (wq)
-		claim_zero(ibv_destroy_wq(wq));
+		claim_zero(mlx4_glue->destroy_wq(wq));
 	if (cq)
-		claim_zero(ibv_destroy_cq(cq));
+		claim_zero(mlx4_glue->destroy_cq(cq));
 	return hw_rss_sup;
 }