diff mbox

[dpdk-dev,1/2] crypto/ccp: enable CCP crypto poll mode driver by default

Message ID 1525327041-128382-1-git-send-email-Ravi1.kumar@amd.com (mailing list archive)
State Superseded, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Kumar, Ravi1 May 3, 2018, 5:57 a.m. UTC 
  Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
---
 config/common_base | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

De Lara Guarch, Pablo May 3, 2018, 7:23 a.m. UTC | #1 
Hi Ravi,

> -----Original Message-----
> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
> Sent: Thursday, May 3, 2018 6:57 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> thomas@monjalon.net; hemant.agrawal@nxp.com
> Subject: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default
> 
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> ---
>  config/common_base | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/common_base b/config/common_base index
> 03a8688..802035b 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -555,7 +555,7 @@ CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
>  #
>  # Compile PMD for AMD CCP crypto device  # -
> CONFIG_RTE_LIBRTE_PMD_CCP=n
> +CONFIG_RTE_LIBRTE_PMD_CCP=y
>  CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=n
> 
>  #
> --
> 2.7.4

I think this cannot be enabled by default, since it has an external dependency on OpenSSL.

Pablo
Kumar, Ravi1 May 9, 2018, 5:53 a.m. UTC | #2 
>Hi Ravi,
>
>> -----Original Message-----
>> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
>> Sent: Thursday, May 3, 2018 6:57 AM
>> To: dev@dpdk.org
>> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; 
>> thomas@monjalon.net; hemant.agrawal@nxp.com
>> Subject: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by 
>> default
>> 
>> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
>> ---
>>  config/common_base | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/config/common_base b/config/common_base index 
>> 03a8688..802035b 100644
>> --- a/config/common_base
>> +++ b/config/common_base
>> @@ -555,7 +555,7 @@ CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
>>  #
>>  # Compile PMD for AMD CCP crypto device  # - 
>> CONFIG_RTE_LIBRTE_PMD_CCP=n
>> +CONFIG_RTE_LIBRTE_PMD_CCP=y
>>  CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=n
>> 
>>  #
>> --
>> 2.7.4
>
>I think this cannot be enabled by default, since it has an external dependency on OpenSSL.

Hi Pablo,

We were asked to enable the PMD by default in one of the previous emails. Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the option in this case. We could leave this patch-set and have the code as-is, I mean the older compile-time option. If not, then this is our only option. 

Regards,
Ravi

>
>Pablo
>
Thomas Monjalon May 9, 2018, 7:58 a.m. UTC | #3 
09/05/2018 07:53, Kumar, Ravi1:
> >
> >I think this cannot be enabled by default, since it has an external dependency on OpenSSL.
> 
> Hi Pablo,
> 
> We were asked to enable the PMD by default in one of the previous emails. Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the option in this case. We could leave this patch-set and have the code as-is, I mean the older compile-time option. If not, then this is our only option. 

If you have a dependency, you cannot enable by default.
Kumar, Ravi1 May 9, 2018, 8:11 a.m. UTC | #4 
>09/05/2018 07:53, Kumar, Ravi1:
>> >
>> >I think this cannot be enabled by default, since it has an external dependency on OpenSSL.
>> 
>> Hi Pablo,
>> 
>> We were asked to enable the PMD by default in one of the previous emails. Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the option in this case. We could leave this patch-set and have the code as-is, I mean the older compile-time option. If not, then this is our only option. 
>
>If you have a dependency, you cannot enable by default.
>
Hi Thomas,

Ok. Could we still submit the 2nd patch for changing compile time to run time option and remove the first one?

Regards,
Ravi
Thomas Monjalon May 9, 2018, 8:19 a.m. UTC | #5 
09/05/2018 10:11, Kumar, Ravi1:
> >09/05/2018 07:53, Kumar, Ravi1:
> >> >
> >> >I think this cannot be enabled by default, since it has an external dependency on OpenSSL.
> >> 
> >> Hi Pablo,
> >> 
> >> We were asked to enable the PMD by default in one of the previous emails. Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the option in this case. We could leave this patch-set and have the code as-is, I mean the older compile-time option. If not, then this is our only option. 
> >
> >If you have a dependency, you cannot enable by default.
> >
> Hi Thomas,
> 
> Ok. Could we still submit the 2nd patch for changing compile time to run time option and remove the first one?

Yes, sure
De Lara Guarch, Pablo May 9, 2018, 8:36 a.m. UTC | #6 
Hi Ravi,

> -----Original Message-----
> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
> Sent: Wednesday, May 9, 2018 9:11 AM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org;
> hemant.agrawal@nxp.com
> Subject: RE: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by
> default
> 
> >09/05/2018 07:53, Kumar, Ravi1:
> >> >
> >> >I think this cannot be enabled by default, since it has an external
> dependency on OpenSSL.
> >>
> >> Hi Pablo,
> >>
> >> We were asked to enable the PMD by default in one of the previous emails.
> Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the
> option in this case. We could leave this patch-set and have the code as-is, I
> mean the older compile-time option. If not, then this is our only option.
> >
> >If you have a dependency, you cannot enable by default.
> >
> Hi Thomas,
> 
> Ok. Could we still submit the 2nd patch for changing compile time to run time
> option and remove the first one?

I have two comments on the other patch. Could you submit a v2 of that patch and drop this first patch?

Thanks,
Pablo

> 
> Regards,
> Ravi
Kumar, Ravi1 May 9, 2018, 8:58 a.m. UTC | #7 
>Hi Ravi,
>
>> -----Original Message-----
>> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
>> Sent: Wednesday, May 9, 2018 9:11 AM
>> To: Thomas Monjalon <thomas@monjalon.net>
>> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; 
>> dev@dpdk.org; hemant.agrawal@nxp.com
>> Subject: RE: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode 
>> driver by default
>> 
>> >09/05/2018 07:53, Kumar, Ravi1:
>> >> >
>> >> >I think this cannot be enabled by default, since it has an 
>> >> >external
>> dependency on OpenSSL.
>> >>
>> >> Hi Pablo,
>> >>
>> >> We were asked to enable the PMD by default in one of the previous emails.
>> Unfortunately, we can't remove the dependency on OpenSSL. Kindly 
>> suggest the option in this case. We could leave this patch-set and 
>> have the code as-is, I mean the older compile-time option. If not, then this is our only option.
>> >
>> >If you have a dependency, you cannot enable by default.
>> >
>> Hi Thomas,
>> 
>> Ok. Could we still submit the 2nd patch for changing compile time to 
>> run time option and remove the first one?
>
>I have two comments on the other patch. Could you submit a v2 of that patch and drop this first patch?
>
>Thanks,
>Pablo

Hi Pablo,

Sure. I will submit v2 with the changes.

Regards,
Ravi
>
>> 
>> Regards,
>> Ravi
>
>
diff mbox

Patch

diff --git a/config/common_base b/config/common_base
index 03a8688..802035b 100644
--- a/config/common_base
+++ b/config/common_base
@@ -555,7 +555,7 @@  CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
 #
 # Compile PMD for AMD CCP crypto device
 #
-CONFIG_RTE_LIBRTE_PMD_CCP=n
+CONFIG_RTE_LIBRTE_PMD_CCP=y
 CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=n
 
 #